First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 198779
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: optical media herd <media-optical@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: James Ranson <euclid80@users.sf.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
cdrtools-2.01.01_alpha34-extraflags.patch Adds "with-acl" and "without-acl" options to the configure script. patch James Ranson 2007-11-11 09:18 0000 902 bytes Details | Diff
cdrtools-ebuild.patch Adds 'acl' USE flag to cdrtools ebuild patch James Ranson 2007-11-11 09:20 0000 1010 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 198779 depends on: Show dependency tree
Show dependency graph
Bug 198779 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2007-11-11 09:16 0000 
The build scripts for cdrtools will detect the presence of the acl libraries
and use them automatically.  However, this leads to dependencies that Portage
doesn't know about, so I suggest that the use of acl be controlled by a USE
flag.

Reproducible: Always

Steps to Reproduce:
1.install sys-apps/acl
2.install cdrtools
3.remove sys-apps/acl

Actual Results:  
cdrtools has missing dynamic links

Expected Results:  
a warning when sys-apps/acl is unmerged

I'll upload a patch for this.  It may need some cleaning up, as I am not an
ebuild expert.

------- Comment #1 From James Ranson 2007-11-11 09:18:39 0000 ------- 
Created an attachment (id=135718) [edit]
Adds "with-acl" and "without-acl" options to the configure script.

------- Comment #2 From James Ranson 2007-11-11 09:20:47 0000 ------- 
Created an attachment (id=135719) [edit]
Adds 'acl' USE flag to cdrtools ebuild

------- Comment #3 From Lars Weiler (RETIRED) 2007-11-11 12:04:45 0000 ------- 
cdrtools-2.01.01a36 has some changes according to ACL (see
ftp://ftp.berlios.de/pub/cdrecord/alpha/AN-2.01.01a36).  Probably your patch is
not needed any more on that version.

Furthermore you check for 'acllib.h' in your patch (actually, cdrtools check
for that file as well), but this one does not get installed by sys-apps/acl. 
So your patch will always fail.

On the other hand I try to keep cdrtools as unpatched as needed, as it seems to
be a fragile framework for patches.  Especially when you need support from
upstream and use a heavily patched version.  So I'm more in favour of adding
sys-apps/acl as a hard dependency rather than creating a patch and test for the
existance of those header-files.

------- Comment #4 From Steve Dibb 2008-01-05 06:15:38 0000 ------- 
(In reply to comment #3)
> cdrtools-2.01.01a36 has some changes according to ACL (see
> ftp://ftp.berlios.de/pub/cdrecord/alpha/AN-2.01.01a36).  Probably your patch is
> not needed any more on that version.
> 
> Furthermore you check for 'acllib.h' in your patch (actually, cdrtools check
> for that file as well), but this one does not get installed by sys-apps/acl. 
> So your patch will always fail.
> 
> On the other hand I try to keep cdrtools as unpatched as needed, as it seems to
> be a fragile framework for patches.  Especially when you need support from
> upstream and use a heavily patched version.  So I'm more in favour of adding
> sys-apps/acl as a hard dependency rather than creating a patch and test for the
> existance of those header-files.
> 

Agreed, added to cdrtools-2.01.01_alpha36-r1.ebuild

------- Comment #5 From Rémi Cardona 2008-01-06 14:51:03 0000 ------- 
Is there any chance the hard ACL dep could be discussed with (and the patch
approved by) upstream devs?

Thanks
First Last Prev Next    No search results available      Search page      Enter new bug