Bug 198546 – genkernel-3.4.9_pre8: genkernel.conf has bad LVM strings

• Status: RESOLVED FIXED
• Product: Gentoo Hosted Projects

[Description Robin Johnson 2007-11-09 11:02:37 UTC]

Looks like a bad search and replace s/LVM2/LVM/ in the source code, and not done in the ebuild. I missed it earlier, because I merged my genkernel.conf by hand and didn't notice the lack of value of LVM_VER on the new side, but hit it on my G5 doing a test clean install.

The upstream PN value is 'LVM2', so we need to preserve it on 3 lines in genkernel.conf.

See attached patch.

[Comment 1 Robin Johnson 2007-11-09 11:02:54 UTC]

Created attachment 135563 [details, diff]
genkernel-3.4.9_pre8-lvm-variable-fixes.patch

[Comment 2 Chris Gianelloni (RETIRED) 2007-11-13 23:00:23 UTC]

What is this:

epatch "${FILESDIR}"/${PN}-3.4.9_pre8-lvm2fix.patch

[Comment 3 Robin Johnson 2007-11-14 01:14:49 UTC]

Oops, I merged the ebuild patch and the genkernel-3.4.9_pre8-lvm2fix.patch files.
The second patch on the end of the attachment is that file.

[Comment 4 Chris Gianelloni (RETIRED) 2007-11-16 00:52:11 UTC]

Could you regen what I need as applicable patches, please?  I'd rather not make mistakes.

Thanks

[Comment 5 Robin Johnson 2007-11-16 01:02:55 UTC]

Created attachment 136069 [details, diff]
Fix ebuild LVM variable usage.

this is the patch for the ebuild, to fix the usage of the variables.

[Comment 6 Robin Johnson 2007-11-16 01:03:36 UTC]

Created attachment 136071 [details, diff]
Fix the name of the upstream distfiles

The upstream distfiles have LVM2 as their PN.

[Comment 7 Robin Johnson 2007-11-16 01:04:43 UTC]

Chris: see the two patches above. One is for the ebuild, so that the 'VERSION_LVM' replacement works correctly again. The second is for the SVN itself (against the latest SVN), so that it uses the correct name for the upstream distfiles.

[Comment 8 Chris Gianelloni (RETIRED) 2007-11-16 23:19:36 UTC]

This is fixed in 3.4.9_pre9-r1 and beyond.