Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 198546
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Genkernel Maintainers <genkernel@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Robin Johnson <robbat2@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
genkernel-3.4.9_pre8-lvm-variable-fixes.patch genkernel-3.4.9_pre8-lvm-variable-fixes.patch patch Robin Johnson 2007-11-09 11:02 0000 2.63 KB Details | Diff
genkernel-3.4.9_pre9-ebuild-lvm-vars-fix.patch Fix ebuild LVM variable usage. patch Robin Johnson 2007-11-16 01:02 0000 1.93 KB Details | Diff
genkernel-svn560-lvm-variable-fix.patch Fix the name of the upstream distfiles patch Robin Johnson 2007-11-16 01:03 0000 626 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 198546 depends on: Show dependency tree
Bug 198546 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2007-11-09 11:02 0000 
Looks like a bad search and replace s/LVM2/LVM/ in the source code, and not
done in the ebuild. I missed it earlier, because I merged my genkernel.conf by
hand and didn't notice the lack of value of LVM_VER on the new side, but hit it
on my G5 doing a test clean install.

The upstream PN value is 'LVM2', so we need to preserve it on 3 lines in
genkernel.conf.

See attached patch.

------- Comment #1 From Robin Johnson 2007-11-09 11:02:54 0000 ------- 
Created an attachment (id=135563) [details]
genkernel-3.4.9_pre8-lvm-variable-fixes.patch

------- Comment #2 From Chris Gianelloni (RETIRED) 2007-11-13 23:00:23 0000 ------- 
What is this:

epatch "${FILESDIR}"/${PN}-3.4.9_pre8-lvm2fix.patch

------- Comment #3 From Robin Johnson 2007-11-14 01:14:49 0000 ------- 
Oops, I merged the ebuild patch and the genkernel-3.4.9_pre8-lvm2fix.patch
files.
The second patch on the end of the attachment is that file.

------- Comment #4 From Chris Gianelloni (RETIRED) 2007-11-16 00:52:11 0000 ------- 
Could you regen what I need as applicable patches, please?  I'd rather not make
mistakes.

Thanks

------- Comment #5 From Robin Johnson 2007-11-16 01:02:55 0000 ------- 
Created an attachment (id=136069) [details]
Fix ebuild LVM variable usage.

this is the patch for the ebuild, to fix the usage of the variables.

------- Comment #6 From Robin Johnson 2007-11-16 01:03:36 0000 ------- 
Created an attachment (id=136071) [details]
Fix the name of the upstream distfiles

The upstream distfiles have LVM2 as their PN.

------- Comment #7 From Robin Johnson 2007-11-16 01:04:43 0000 ------- 
Chris: see the two patches above. One is for the ebuild, so that the
'VERSION_LVM' replacement works correctly again. The second is for the SVN
itself (against the latest SVN), so that it uses the correct name for the
upstream distfiles.

------- Comment #8 From Chris Gianelloni (RETIRED) 2007-11-16 23:19:36 0000 ------- 
This is fixed in 3.4.9_pre9-r1 and beyond.
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug