Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 198083 - app-misc/livecd-tools-1.0.35-r1: dhcp broadcasting is no-op
Summary: app-misc/livecd-tools-1.0.35-r1: dhcp broadcasting is no-op
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Release Media
Classification: Unclassified
Component: LiveCD/DVD/USB (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Release Team
URL:
Whiteboard:
Keywords:
: 383429 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-11-04 19:09 UTC by Paweł Hajdan, Jr. (RETIRED)
Modified: 2020-11-06 00:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
autoconfig.patch (for livecd-tools 1.0.39) (autoconfig.patch,690 bytes, patch)
2008-04-11 16:57 UTC, Paweł Hajdan, Jr. (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2007-11-04 19:09:54 UTC
I think there is a bug in /etc/init.d/autoconfig script.

Is:

if [ "${DHCP}" = "yes" ]
then
     einfo "Network device ${HILITE}${nics}${NORMAL} detected, DHCP broadcasting for IP ..."
fi

Should be:

if [ "${DHCP}" = "yes" ]
then
     einfo "Network device ${HILITE}${nics}${NORMAL} detected, DHCP broadcasting for IP ..."
     dhcpcd "${nics}"
fi

(notice added dhcpcd call)
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2007-11-05 16:28:24 UTC
Well, yes and no.

See, dhcpcd is automatically called on all interfaces that are discovered via udev, unless their configuration tells the system not to do so.  A blank configuration means DHCP, which is default.  As such, when udevtrigger is run, dhcpcd should be run.  We have not manually run dhcpcd for some time now, and in fact, causing it to run manually caused even more issues.  That little snippet really isn't supposed to do anything but give a display.  I'll likely just remove the functionality altogether, to reduce confusion.
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2007-11-20 19:29:19 UTC
OK.  Instead, I wrote code to try to determine if we've gotten an address or not and to run dhcpcd only if we don't have an address already.  This should resolve this bug.
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2007-11-20 19:29:36 UTC
Err... I should have mentioned that this is FIXED in 1.0.39
Comment 4 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2008-04-11 16:57:21 UTC
There is one small issue with this for me, please take a look at suggested patch (will attach in a moment). Basically it fixes it for me, and hopefully doesn't broke for others.
Comment 5 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2008-04-11 16:57:58 UTC
Created attachment 149415 [details, diff]
autoconfig.patch (for livecd-tools 1.0.39)
Comment 6 Oleg Bulatov 2011-09-18 14:06:46 UTC
*** Bug 383429 has been marked as a duplicate of this bug. ***
Comment 7 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2011-09-19 01:13:49 UTC
@William,

can you provide some input? I've been looking at the autoconfig script and noticed the update for bl2 changed the way dhcp is run on the interfaces.
Comment 8 Larry the Git Cow gentoo-dev 2020-11-06 00:29:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/livecd-tools.git/commit/?id=58948705bcf5136401621a8855e9f0c15049e1dd

commit 58948705bcf5136401621a8855e9f0c15049e1dd
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-11-06 00:27:40 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-11-06 00:29:07 +0000

    autoconfig: Fix logic error
    
    When the system starts, the PID file will not exist because we haven't
    started dhcpcd. Also update /var/run -> /run while we're here.
    
    Closes: https://bugs.gentoo.org/198083
    Closes: https://bugs.gentoo.org/439912
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 init.d/autoconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)