First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 197678
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Joe Peterson <lavajoe@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
usbutils-0.73-freebsd.patch files/usbutils-0.73-freebsd.patch patch Joe Peterson 2007-10-31 20:02 0000 503 bytes Details | Diff
diff usbutils-0.73.ebuild patch Joe Peterson 2007-10-31 20:03 0000 405 bytes Details | Diff
diff usbutils-0.73.ebuild patch Joe Peterson 2007-11-01 16:10 0000 1.08 KB Details | Diff
usbutils-0.73-byteorder.patch files/usbutils-0.73-byteorder.patch patch Joe Peterson 2007-11-01 16:12 0000 1.14 KB Details | Diff
usbutils-0.73-byteorder.patch files/usbutils-0.73-byteorder.patch patch Joe Peterson 2007-11-13 15:29 0000 1.35 KB Details | Diff
usbutils-0.73-byteorder.patch files/usbutils-0.73-byteorder.patch patch Joe Peterson 2007-11-13 15:31 0000 1.35 KB Details | Diff
usbutils-0.73-byteorder.patch files/usbutils-0.73-byteorder.patch patch Joe Peterson 2007-11-13 15:37 0000 1.35 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 197678 depends on: Show dependency tree
Bug 197678 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2007-10-31 20:00 0000 
The new version uses asm/byteorder.h and its function __le16_to_cpu, which do
not exist in FreeBSD.  I will attach a patch.

Please let me know if it is OK to check in the patch.

------- Comment #1 From Joe Peterson 2007-10-31 20:02:01 0000 ------- 
Created an attachment (id=134833) [edit]
files/usbutils-0.73-freebsd.patch

Patch to use an alternate method in FreeBSD

------- Comment #2 From Joe Peterson 2007-10-31 20:03:27 0000 ------- 
Created an attachment (id=134834) [edit]
usbutils-0.73.ebuild

The ebuild change to use this patch

------- Comment #3 From SpanKY 2007-11-01 00:20:09 0000 ------- 
usbutils uses autotools ... so should you

------- Comment #4 From Joe Peterson 2007-11-01 05:08:40 0000 ------- 
Mike, can you elaborate: how would you patch this?

------- Comment #5 From SpanKY 2007-11-01 06:17:09 0000 ------- 
system related defines are not valid in autotool based systems

add proper configure checks and key off of those defines

------- Comment #6 From Joe Peterson 2007-11-01 16:10:07 0000 ------- 
Created an attachment (id=134912) [edit]
usbutils-0.73.ebuild

New ebuild to patch and reconf autotools instead

------- Comment #7 From Joe Peterson 2007-11-01 16:12:23 0000 ------- 
Created an attachment (id=134913) [edit]
files/usbutils-0.73-byteorder.patch

New patch using autotools to determine how to deal with byteorder.  Mike, let
me know what you think.

------- Comment #8 From Joe Peterson 2007-11-05 18:55:57 0000 ------- 
This patch has been submitted to upstream.  Please advise on how to proceed for
0.73.  Thanks, Joe

------- Comment #9 From SpanKY 2007-11-12 07:27:25 0000 ------- 
i'd indent stuff myself ...
#if moo
# include ...
# if ...
#  ....
but otherwise looks fine

did you submit this upstream ?

------- Comment #10 From SpanKY 2007-11-12 07:30:59 0000 ------- 
on second thought, dont use _BYTE_ORDER

there is an AC macro:
AC_C_BIGENDIAN

this will define "WORDS_BIGENDIAN" if targetting a big endian machine

------- Comment #11 From Joe Peterson 2007-11-13 15:29:27 0000 ------- 
Created an attachment (id=135897) [edit]
files/usbutils-0.73-byteorder.patch

OK, see new patch and let me know how this looks.

I did submit to upstream, but I'm sure they will accept this change as well.

------- Comment #12 From Joe Peterson 2007-11-13 15:31:16 0000 ------- 
Created an attachment (id=135899) [edit]
files/usbutils-0.73-byteorder.patch

Use this one instead.

------- Comment #13 From Joe Peterson 2007-11-13 15:37:16 0000 ------- 
Created an attachment (id=135900) [edit]
files/usbutils-0.73-byteorder.patch

This one is even more clear I think...

------- Comment #14 From SpanKY 2007-11-14 08:11:19 0000 ------- 
one space, not two ... but otherwise looks fine

side note, never use "#" comments in configure.ac files ... use "dnl"

------- Comment #15 From Joe Peterson 2007-11-14 16:50:28 0000 ------- 
Fixed the indentation (using one space now) and committed.  Thanks Mike!
Submitted new AC endian macro tweak upstream.
First Last Prev Next    No search results available      Search page      Enter new bug