Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 196822 - gnome-base/nautilus-2.20.0 sound preview not working
Summary: gnome-base/nautilus-2.20.0 sound preview not working
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: x86 Linux
: High major (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on: gnome2.22-tracker
Blocks:
  Show dependency tree
 
Reported: 2007-10-23 18:39 UTC by Sebastian Kannengießer
Modified: 2008-08-25 09:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Kannengießer 2007-10-23 18:39:06 UTC
nautilus feature of previewing sound files does not work due to nautilus-2.19.90-noesd.patch

Reproducible: Always

Steps to Reproduce:
1. Emerge nautilus-2.20.0 "with" new esd useflag (incorporated by above mentioned patch) enabled.
2. Be sure esd is running.
3. Do mouseover on any mp3 file and experience missing sound previewing.

Actual Results:  
no sound preview of mp3, the small note icon usually turning up does not come either, leading to the assumption, that the specific code is not running at all.

Expected Results:  
sound should preview as it was previewed in nautilus releases up to 2.18.3 here with no problem

The issue can be worked around by copying the nautilus ebuild to overlay and removing the use of the above mentioned noesd patch for having esd optionally (why at all? having esd on a machine is not too much of overhead for a gnome user, which can anyway decide, whether or not to have it run).

By removing the patch and emerging from overlay, the sound preview starts working again.
Comment 1 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-10-27 14:57:55 UTC
So, I went to test this, and I get no sound preview no matter what I do, with or without the patch.  What exactly am I supposed to do to get sound preview?  Hover my mouse over an mp3 in nautilus?  Select it?  What?
Comment 2 Pacho Ramos gentoo-dev 2007-10-27 15:25:06 UTC
(In reply to comment #1)
> So, I went to test this, and I get no sound preview no matter what I do, with
> or without the patch.  What exactly am I supposed to do to get sound preview? 
> Hover my mouse over an mp3 in nautilus?  Select it?  What?
> 

When you move your mouse over an audio file icon, without clicking on it 
Comment 3 Pacho Ramos gentoo-dev 2007-10-27 18:03:10 UTC
There is a patch and more info in:
http://bugzilla.gnome.org/show_bug.cgi?id=486827
Comment 4 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-10-29 15:01:50 UTC
Thanks for pointing me to that bug; I'll see about getting gstreamer preview in.  However, looking at the code, I don't see how esound preview can possibly work in 2.20.0, even unpatched.  It hardcodes the define for USE_OLD_AUDIO_PREVIEW, which should disable esound preview, no matter what.  Color me confused...
Comment 5 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-10-29 17:29:47 UTC
Okay, I've committed nautilus-2.20.0-r1, which has the new totem/gstreamer sound preview; however, it only has it if you give -esd.  I was unable to test the esd sound preview, for lack of a box with working esd.

I'm tempted to remove potential esd support in nautilus at all, but I'll wait on feedback for the new preview systems.
Comment 6 Sebastian Kannengießer 2007-10-29 18:14:15 UTC
(In reply to comment #5)

There is nothing at all wrong with esd support in nautilus-2.20.0 if, as i said before, you leave away that noesd patch, which incorporates all that defines.

Anyway, I'm glad, you added gstreamer support as the redhat people did.
Comment 7 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-10-29 18:31:36 UTC
I *did* take out the esd patch when testing, and could not get esound support working.  And, as I said, I looked at the code, and esound support cannot be enabled, even without the patch.  I think what you must have been seeing was not the esound support, but rather the old direct play via mpg123 and ogg123.
Comment 8 Pacho Ramos gentoo-dev 2007-10-29 18:48:23 UTC
(In reply to comment #7)
> I *did* take out the esd patch when testing, and could not get esound support
> working.  And, as I said, I looked at the code, and esound support cannot be
> enabled, even without the patch.  I think what you must have been seeing was
> not the esound support, but rather the old direct play via mpg123 and ogg123.
> 

I don't have gnome 2.20 yet, but, for using sound preview with esd, you have to enabled esd and, also, set to ESD from Autodetect on first tab in gnome-sound-properties
Comment 9 Sebastian Kannengießer 2007-11-02 14:04:17 UTC
(In reply to comment #7)

Actually, you are partly right. I am previewing files using mpg123, but esound is a "must have" in my case. When shutting down esound, preview does no longer work, which means that nautilus code is in need for esound, which is what the nautilus guys told me as well, in order to preview. 

What do you actually mean by "esound support cannot be enabled" ?

You are definitely right as far as mpg123 is not using esd to output sound, but this method is anyway in need for esd.


Comment 10 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-11-03 14:53:50 UTC
I mean that the preview code in nautilus that uses esound cannot ever be enabled at compile time, without my patch.  It is forced off, and the alternative (using mpg123/ogg123) is forced on.  So, adding my patch presumably breaks your preview because it *does* enable esound, rather than because it *doesn't* enable esound.
Comment 11 Pacho Ramos gentoo-dev 2007-11-24 11:40:33 UTC
(In reply to comment #5)
> Okay, I've committed nautilus-2.20.0-r1, which has the new totem/gstreamer
> sound preview; however, it only has it if you give -esd.  I was unable to test
> the esd sound preview, for lack of a box with working esd.
> 
> I'm tempted to remove potential esd support in nautilus at all, but I'll wait
> on feedback for the new preview systems.
> 

About new preview systems, I am using totem way now and works fine :-D, I dropped esd and upgrade to gnome-2.20 and all works ok :-)
Comment 12 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-03-02 19:21:29 UTC
just to confirm, as far as my test goes, it's not possible to make nautilus to play anything with esd use flag enabled. I suggest we drop this flag and go the gstreamer way. Maybe one day, someone will provide a pulseaudio patch that will make its way upstream to replace this piece of dead code.
Comment 13 Rémi Cardona (RETIRED) gentoo-dev 2008-05-27 19:50:11 UTC
Sound preview works fine in 2.22. the esound dep is just left-over cruft that has been finally removed in 2.23.
Comment 14 Rémi Cardona (RETIRED) gentoo-dev 2008-08-25 09:03:51 UTC
Ok, so sound preview in nautilus 2.22 still works fine as long as gstreamer is properly configured. Closing FIXED.

And for the record, the "esd" USE flag has been completely removed from nautilus 2.23/2.24 (yay!)