Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 194864 - media-libs/libpng-1.2.21 causes several KDE apps to crash/not start
Summary: media-libs/libpng-1.2.21 causes several KDE apps to crash/not start
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 195147 (view as bug list)
Depends on:
Blocks: 195261
  Show dependency tree
 
Reported: 2007-10-05 23:57 UTC by teidakankan
Modified: 2007-10-14 17:37 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge info (emergeinfo.txt,8.65 KB, text/plain)
2007-10-05 23:57 UTC, teidakankan
Details
Altered patch (libpng-1.2.21-off-by-one.patch,571 bytes, patch)
2007-10-06 21:38 UTC, Peter Sääf
Details | Diff
libpng-1.2.21-null-termination.patch (libpng-1.2.21-null-termination.patch,1.11 KB, patch)
2007-10-09 15:28 UTC, Doug Goldstein (RETIRED)
Details | Diff
Correct the typo but nothing more (libpng-1.2.21-null-termination-v2.patch,541 bytes, patch)
2007-10-14 17:36 UTC, Pierre Poissinger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description teidakankan 2007-10-05 23:57:05 UTC
1.  skim won't start
2.  krusader use to start with: krusader -caption "%c" %i %m but now only starts 
    with krusader -caption "%c"
3.  ktorrent won't start

Okay after reinstalling media-libs/libpng-1.2.20

Reproducible: Always
Comment 1 teidakankan 2007-10-05 23:57:43 UTC
Created attachment 132689 [details]
emerge info
Comment 2 Norberto Bensa 2007-10-06 01:27:14 UTC
add yakuake to the list
Comment 3 Peter Sääf 2007-10-06 10:42:43 UTC
Not having seen what error you get I can't say if it's the same issue but.
bmpx crashes with libpng-1.2.21 with the following message.

swany@gentoo ~ $ /usr/libexec/beep-media-player-2-bin 
** Message: sm.cc:270: Connection opened, client id is 11c0a80001000119166709100000019680007
** Message: sm.cc:53: XSMP Version: 1  Revision: 0
** Message: sm.cc:56: Session manager: GnomeSM 
** Message: sm.cc:60: Release: 2.20.0
*** glibc detected *** /usr/libexec/beep-media-player-2-bin: malloc(): memory corruption: 0x088889b8 ***
======= Backtrace: =========
/lib/libc.so.6[0xb6e54a8f]
/lib/libc.so.6[0xb6e56d20]
/lib/libc.so.6(__libc_malloc+0x90)[0xb6e58410]
/usr/lib/libglib-2.0.so.0(g_try_malloc+0x33)[0xb70a6563]
/usr/lib/libpng12.so.0(png_malloc+0x3d)[0xb6b5eb7d]

Works fine with libpng-1.2.20
Comment 4 Peter Sääf 2007-10-06 10:50:24 UTC
It's probably this bug. http://sourceforge.net/mailarchive/forum.php?thread_name=47067C84.7010205%40playstation.sony.com&forum_name=png-mng-implement

It will be fixed for 1.2.22. libpng-1.2.21 should probably be masked.
Comment 5 SpanKY gentoo-dev 2007-10-06 14:05:19 UTC
thanks for the link, ive added the one-liner fix to 1.2.21-r1
Comment 6 teidakankan 2007-10-06 21:03:05 UTC
1.2.21-r1 didn't resolve anything here.  I'll just wait for 1.2.22.
Comment 7 Peter Sääf 2007-10-06 21:38:06 UTC
Created attachment 132772 [details, diff]
Altered patch

The attached patch works for me.

Shamelessly copied from the 1.2.21 => 1.2.22beta changes.   :D
Comment 8 teidakankan 2007-10-06 22:52:29 UTC
(In reply to comment #7)
> Created an attachment (id=132772) [edit]
> Altered patch
> 
> The attached patch works for me.
> 
> Shamelessly copied from the 1.2.21 => 1.2.22beta changes.   :D
> 

That fixed it.  Many thanks!
Comment 9 SpanKY gentoo-dev 2007-10-06 22:57:21 UTC
unfortunately, the mailing list only showed the one change, and libpng doesnt have a public scm for me to check, so i just went with what was on the mailing list

ive updated the patch for 1.2.21-r2, thanks
Comment 10 SpanKY gentoo-dev 2007-10-08 22:13:55 UTC
*** Bug 195147 has been marked as a duplicate of this bug. ***
Comment 11 Kovid Goyal 2007-10-09 01:34:57 UTC
1.2.21-r2 still causes crashes for me in several apps, kopete being the most prominent. 
Comment 12 Doug Goldstein (RETIRED) gentoo-dev 2007-10-09 15:16:48 UTC
That patch can't be right.
Comment 13 Doug Goldstein (RETIRED) gentoo-dev 2007-10-09 15:28:28 UTC
Created attachment 133005 [details, diff]
libpng-1.2.21-null-termination.patch

Looks a bit better and should solve all issues.
Comment 14 Doug Goldstein (RETIRED) gentoo-dev 2007-10-10 21:35:21 UTC
I committed this patch as -r3
Comment 15 Pierre Poissinger 2007-10-14 17:36:08 UTC
Created attachment 133460 [details, diff]
Correct the typo but nothing more

Ok, fall with same bug with nautilus
(cf http://bugs.gentoo.org/show_bug.cgi?id=195536)
==> the original patch seems a little bit too paranoid for me:
first hunk: strncpy of xxx with strlen(xxx)+1 will set a trailing null, no need to 2 call to strlen
second hunk: IMHO, not needed...