Bugzilla Bug 193701

gcalctool doesn't compile, log attached

Reproducible: Always

Steps to Reproduce:
1. emerge gcalctool
2.
3.

Actual Results:  
gtk.c:3521: error: 'struct Xobject' has no member named 'kframe'

gtk.c:3522: error: 'struct Xobject' has no member named 'kframe'

gtk.c: In function 'set_item':

gtk.c:3537: error: 'struct Xobject' has no member named 'base'

gtk.c:3541: error: 'struct Xobject' has no member named 'disp'

gtk.c:3545: error: 'struct Xobject' has no member named 'trig'

gtk.c: In function 'set_title':

gtk.c:3562: error: 'struct Xobject' has no member named 'kframe'

gtk.c:3564: error: 'struct Xobject' has no member named 'rframe'

gtk.c: In function 'show_ascii_frame':

gtk.c:3609: error: 'struct Xobject' has no member named 'aframe'

gtk.c:3613: error: 'struct Xobject' has no member named 'aframe'

gtk.c:3614: error: 'struct Xobject' has no member named 'kframe'

gtk.c:3614: error: 'struct Xobject' has no member named 'aframe'

gtk.c:3616: error: 'struct Xobject' has no member named 'kframe'

gtk.c:3616: error: 'struct Xobject' has no member named 'aframe_ch'

gtk.c:3617: error: 'struct Xobject' has no member named 'aframe'

gtk.c: In function 'show_menu':

gtk.c:3628: error: 'struct Xobject' has no member named 'sci_buttons'

gtk.c:3630: error: 'struct Xobject' has no member named 'sci_buttons'

gtk.c:3632: error: 'struct Xobject' has no member named 'adv_buttons'

gtk.c:3634: error: 'struct Xobject' has no member named 'sci_buttons'

gtk.c:3636: error: 'struct Xobject' has no member named 'sci_buttons'

gtk.c:3638: error: 'struct Xobject' has no member named 'adv_buttons'

gtk.c:3640: error: 'struct Xobject' has no member named 'sci_buttons'

gtk.c:3642: error: 'struct Xobject' has no member named 'adv_buttons'

gtk.c: In function 'show_precision_frame':

gtk.c:3669: error: 'struct Xobject' has no member named 'spframe'

gtk.c:3673: error: 'struct Xobject' has no member named 'spframe'

gtk.c:3674: error: 'struct Xobject' has no member named 'kframe'

gtk.c:3674: error: 'struct Xobject' has no member named 'spframe'

gtk.c:3676: error: 'struct Xobject' has no member named 'spframe'

gtk.c:3676: error: 'struct Xobject' has no member named 'spframe_val'

gtk.c:3677: error: 'struct Xobject' has no member named 'spframe'

gtk.c: In function 'start_tool':

gtk.c:3697: error: 'struct Xobject' has no member named 'kframe'

gtk.c: In function 'win_display':

gtk.c:3747: error: 'struct Xobject' has no member named 'rframe'

gtk.c:3756: error: 'struct Xobject' has no member named 'kframe'

make[2]: *** [gtk.o] Error 1

make[2]: *** Waiting for unfinished jobs....

./ce_parser.y: conflicts: 153 shift/reduce, 22 reduce/reduce

make[2]: Leaving directory
`/var/tmp/portage/gnome-extra/gcalctool-5.9.14/work/gcalctool-5.9.14/gcalctool'

make[1]: *** [all-recursive] Error 1

make[1]: Leaving directory
`/var/tmp/portage/gnome-extra/gcalctool-5.9.14/work/gcalctool-5.9.14'

make: *** [all] Error 2

 * 

 * ERROR: gnome-extra/gcalctool-5.9.14 failed.

 * Call stack:

 *   ebuild.sh, line 1654:   Called dyn_compile

 *   ebuild.sh, line 990:   Called qa_call 'src_compile'

 *   ebuild.sh, line 44:   Called src_compile

 *   ebuild.sh, line 1334:   Called gnome2_src_compile

 *   gnome2.eclass, line 71:   Called die

 * 

 * compile failure

 * If you need support, post the topmost build error, and the call
stack if relevant.

 * A complete build log is located at
'/var/log/portage/gnome-extra:gcalctool-5.9.14:20070925-000716.log'.

 * 


Expected Results:  
Successful compile.

Possibly limited to amd64.

Created an attachment (id=131816) [edit]
build log

gnome-applets-2.18.0-r2 fails with a very similar error

Good call ... those packages should _not_ use these #defines in stable release
tarballs.

-DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED
-DGNOME_DISABLE_DEPRECATED

Thanks :)

Wait for an update then, or can  fix it? :)

We will probably fix it if possible, yes. For gcalctool I actually see no big
problems for unmasking 5.10 for it, but if it's an easy fix, then I think we'll
just fix it without a revbump (build error only), yeah.

Okay, great. Gnome-applets is causing me more of a problem as it won't build on
a new system (I have 3 with Gnome broke now). I will try some older/newer
packages to resolve the issue and wait for a proper fix. Thanks :)

*** Bug 193981 has been marked as a duplicate of this bug. ***

I can also confirm this bug on x86.

Created an attachment (id=132041) [edit]
build log on clean install

Created an attachment (id=132047) [edit]
gcalctool-gtk+-2.12.0-compat.patch

This patch patches gcalctool/Makefile.am to remove the flags and whatnot that
break compilation.

(I think I did it right, let me know if I did, thanks :) )

Created an attachment (id=132055) [edit]
gcalctool-5.9.14-r1.ebuild

An ebuild that applies the patch I just posted and runs eautoreconf.

Thanks, one hurdle down :-)

It fails due to scrollkeeper now though. Sure I read something about this.

make[2]: Nothing to be done for `install-exec-am'.
test -z "/usr/share/applications" || /bin/mkdir -p
"/var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/image//usr/share/applications"
 /usr/bin/install -c -m 644 'gcalctool.desktop'
'/var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/image//usr/share/applications/gcalctool.desktop'
GCONF_CONFIG_SOURCE=xml:merged:/etc/gconf/gconf.xml.defaults
/usr/bin/gconftool-2 --makefile-install-rule ./gcalctool.schemas
GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL is set, not installing schemas
test -z "/etc/gconf/schemas" || /bin/mkdir -p
"/var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/image//etc/gconf/schemas"
 /usr/bin/install -c -m 644 'gcalctool.schemas'
'/var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/image//etc/gconf/schemas/gcalctool.schemas'
make[2]: Leaving directory
`/var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/work/gcalctool-5.9.14'
make[1]: Leaving directory
`/var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/work/gcalctool-5.9.14'
>>> Completed installing gcalctool-5.9.14-r1 into /var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/image/

ecompressdir: bzip2 -9 usr/share/man
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment
   usr/bin/gcalctool
 * QA Notice: // installed in ${D}/${D}
 * QA Notice: //var installed in ${D}/${D}
 * QA Notice: //var/lib installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/C installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/C/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/C/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/am installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/am/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/am/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/az installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/az/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/az/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/be installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/be/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/be/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ca installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ca/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ca/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/cs installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/cs/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/cs/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/da installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/da/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/da/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/de installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/de/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/de/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/el installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/el/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/el/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/es installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/es/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/es/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/fr installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/fr/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/fr/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/hu installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/hu/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/hu/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/it installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/it/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/it/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ja installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ja/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ja/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/kn installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/kn/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/kn/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ko installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ko/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ko/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/nl installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/nl/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/nl/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/no installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/no/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/no/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/pl installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/pl/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/pl/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/pt_BR installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/pt_BR/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/pt_BR/scrollkeeper_extended_cl.xml
installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ro installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ro/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ro/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ru installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ru/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/ru/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sk installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sk/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sk/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sl installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sl/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sl/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sr installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sr/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sr/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sr@Latn installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sr@Latn/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sr@Latn/scrollkeeper_extended_cl.xml
installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sv installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sv/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/sv/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/tr installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/tr/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/tr/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/uk installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/uk/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/uk/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/vi installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/vi/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/vi/scrollkeeper_extended_cl.xml installed
in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/zh_CN installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/zh_CN/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/zh_CN/scrollkeeper_extended_cl.xml
installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/zh_TW installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/zh_TW/scrollkeeper_cl.xml installed in
${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/zh_TW/scrollkeeper_extended_cl.xml
installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/TOC installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/TOC/0 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/TOC/1 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/TOC/2 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/TOC/3 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/TOC/4 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/TOC/5 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/index installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/index/0 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/index/1 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/index/2 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/index/3 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/index/4 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/index/5 installed in ${D}/${D}
 * QA Notice: //var/lib/scrollkeeper/scrollkeeper_docs installed in ${D}/${D}
 * 
 * ERROR: gnome-extra/gcalctool-5.9.14-r1 failed.
 * Call stack:
 *   misc-functions.sh, line 566:  Called install_qa_check
 *   misc-functions.sh, line 204:  Called die
 * The specific snippet of code:
 *              die "Aborting due to QA concerns: ${INSTALLTOD} files installed
in ${D}/${D}"
 *  The die message:
 *   Aborting due to QA concerns: 115 files installed in
/var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/image///var/tmp/portage/gnome-extra/gcalctool-5.9.14-r1/image/
 * 
 * If you need support, post the topmost build error, and the call stack if
relevant.
 * A complete build log is located at
'/var/log/portage/gnome-extra:gcalctool-5.9.14-r1:20070928-100635.log'.
 * This ebuild is from an overlay: '/usr/local/portage/'
 * 
!!! install_qa_check failed; exiting.

Keith,

thanks for the patches, I'll take a look at them this weekend. I'll try to fix
all the other packages as well.

Should you provide more patches, here are a few tips :
 - don't attach the final ebuild, attach a patch to the current ebuild, it's
easier for us to know what's changed (trivial in this case)
 - use gnome2_src_unpack instead of unpack && cd if it's a gnome2 ebuild

Thanks again :)

Created an attachment (id=132085) [edit]
gcalctool-5.9.14.ebuild.patch

Okay, this patch against gcalctool-5.9.14.ebuild actually compiles and installs
when tested using ebuild. I'm putting it into my overlay now and testing
merging it. There is a new QA failure though:

>>> Completed installing gcalctool-5.9.14 into /var/tmp/portage/gnome-extra/gcalctool-5.9.14/image/

ecompressdir: bzip2 -9 usr/share/man
strip: i686-pc-linux-gnu-strip --strip-unneeded -R .comment
   usr/bin/gcalctool

 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * ce_parser.tab.c:1533: warning: implicit declaration of function 'celex'
lr_parser.tab.c:1498: warning: implicit declaration of function 'lrlex'

But it still installs regardless.

Created an attachment (id=132087) [edit]
gcalctool-5.9.14.ebuild.patch.2

I actually looked at the eclass and it looks like ${A} and cd ${S} were
completely unnecessary.

This patch no longer has that.

I can confirm that it works as I just merged the package.

I can also confirm that this fixes the issue for me here (~amd64).

Created an attachment (id=132144) [edit]
Similar patch for gnome-applets

Patches one of the Makefile.am in gnome-applets the same way as for gcalctool.

Created an attachment (id=132146) [edit]
Ebuild for gnome-applets with gtk-2.12 compatibility patch

Ebuild to use the patch

Fixed in CVS in ~arch :
- gcalctool-5.9.14-r1
- gnome-applets-2.18.3-r1

gnome-applets is already fixed upstream, gcalctool isn't so I filed bug 481558
upstream.

Please test. If it all works ok, I'll CC arches to stabilize those packages (or
not, herd what do you think?)

Confirmed new gcalctool ebuild in portage compiles okay here. I still have one
box with scrollkeeper errors at work. I will look into that Monday.

Fix working and is in portage.

If everyone is happy I'll close this bug :)

Upstream bug is fixed as well (with a better patch)

Thanks everyone

Any chance for unmasking this in x86 any time soon?

It is not masked. It is at the SAME visibility level as gtk+-2.12.x
If you get gtk+-2.12.x from ~arch on a stable system through package.keywords,
then it's up to you to get other necessary things via that method as well.
Having said that, gtk+-2.12 is intended to go stable in the coming days, and
the prerequisite is to get these gcalctool and gnome-applets revisions stable,
so I'll be filing stabilization bugs soon enough.