Bugzilla Bug 193169

Wesnoth has a dedicated and a server useflag. Both can be used together to let
it run as a server on headless machines. Headless machines do not have X
installed in most cases, so there is no need for libsdl being build with X
useflag. The ebuild for Wesnoth has a check which always fails on these
headless machines if they have libsdl built without X. The check is wrong!

Reproducible: Always

Steps to Reproduce:
1. USE="-X dedicated server" emerge libsdl wesnoth


Actual Results:  
"Please emerge media-libs/libsdl with USE=X"


Expected Results:  
A fine and complete build

This is the wrong check:
        if ! built_with_use media-libs/libsdl X ; then
                die "Please emerge media-libs/libsdl with USE=X"
        fi

This would be a correct check:
        if ! use dedicated && ! built_with_use media-libs/libsdl X ; then
                die "Please emerge media-libs/libsdl with USE=X"
        fi

used to be broken for that case.  Nice they've fixed it since then.  Thanks for
the bug report.

Sorry, but the bug is not fixed, someone forgot the exclamation mark in front
of the "use dedicated". And it was only used on the latest stable version,
1.2.6, not on the versions before.

The correct check is:
if ! use dedicated && ! built_with_use media-libs/libsdl X ; then
                die "Please emerge media-libs/libsdl with USE=X"
fi

Tried it here, works perfect. (The game server itself does work, too. I don't
know if they ever had problems upstream, works here since one year or even
longer.)

whoops, yes, I forgot the bang.  fixed now.

the bug is back again in version 1.4.2

no, see bug #222033

Ok, dunno why the other bug happens, i use "dedicated lite server" as useflags
for wesnoth and it still builds with my libsdl without X support! So it might
not be an upstream bug, but rather some mix of use flags which do not work.

eix wesnoth -I
[I] games-strategy/wesnoth
     Available versions:  1.2.8 ~1.4.1 1.4.2 {dedicated editor gnome kde lite
nls server static tools}
     Installed versions:  1.4.2(17:38:44 28.05.2008)(dedicated lite nls server
-editor -static -tools)

emerge --info:
Portage 2.1.4.4 (hardened/x86/2.6, gcc-3.4.6, glibc-2.6.1-r0,
2.6.23-hardened-r4
 i686)
=================================================================
System uname: 2.6.23-hardened-r4 i686 VIA Samuel 2
Timestamp of tree: Fri, 30 May 2008 03:46:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.4.4-r9
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.61-r1
sys-devel/automake:  1.7.9-r1, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="x86"
CBUILD="i586-pc-linux-gnu"
CFLAGS="-Os -march=c3 -mtune=i686 -mmmx -m3dnow -pipe"
CHOST="i586-pc-linux-gnu"
CONFIG_PROTECT="/etc /var/bind"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf
/etc/gcon
f /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/
/etc/php/cli-p
hp5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c
/etc/udev/rul
es.d"
CXXFLAGS="-Os -march=c3 -mtune=i686 -mmmx -m3dnow -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="bash-completion ccache collision-protect cvs distlocks
metadata-transf
er parallel-fetch sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://ftp.rz.tu-bs.de/pub/mirror/ftp.gentoo.org/gentoo-distfiles
/"
LANG="de_DE.UTF-8"
LC_ALL="de_DE.UTF-8"
LINGUAS="de en"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress 
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclu
de=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="3dnow acpi apache2 bash-completion berkdb bzip2 chroot cracklib crypt cups 
gif hardened ipv6 jpeg logrotate midi mmx mysql ncurses nls nptl nptlonly
offens
ive oss pcre perl pic png python readline samba sasl ssl tcpd tiff unicode
urand
om vhosts x86 xorg zlib" ALSA_CARDS="via82xx" ALSA_PCM_PLUGINS="adpcm alaw
 asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa
lflo
at linear meter mulaw multi null plug rate route share shm softvol"
APACHE2_MODU
LES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm
authn_d
efault authn_file authz_dbm authz_default authz_groupfile authz_host
authz_owner
 authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env
e
xpires ext_filter file_cache filter headers ident imagemap include info
log_conf
ig logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer
pr
oxy_connect proxy_http rewrite setenvif so speling status unique_id userdir
user
track vhost_alias" APACHE2_MPMS="prefork" ELIBC="glibc" INPUT_DEVICES="mouse
key
board" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216
lcd
m001 mtxorb ncurses text" LINGUAS="de en" USERLAND="GNU" VIDEO_CARDS="s3"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS,
MAKEOPTS,
 PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

This " ! dedicated && " part could be used only for 1.4.2 version in 1.4.4 it
allways need X use for libsdl... i would sugges closing this as upstream and
fixing 1.4.2 ebuild.

We'll just use 1.4.4 and ditch 1.4.2 completely.