Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 191989 - app-editors/gedit has automagic dependency on libattr (sys-apps/attr)
Summary: app-editors/gedit has automagic dependency on libattr (sys-apps/attr)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-10 15:19 UTC by Daniel Drake (RETIRED)
Modified: 2008-08-03 19:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gedit-libattr-shadow-depend-remove (gedit-libattr.patch,1.03 KB, patch)
2007-09-13 14:55 UTC, Doug Goldstein (RETIRED)
Details | Diff
app-editors:gedit-2.20.3:20071129-170920.log (20071129-170920.log,38.84 KB, text/plain)
2007-11-29 17:52 UTC, Jeroen Roovers (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Drake (RETIRED) gentoo-dev 2007-09-10 15:19:46 UTC
I tweaked USE flags a bit, did all world updates (with --newuse) then depclean, and sys-apps/attr was removed. Then gedit stopped working:

gedit: error while loading shared libraries: libattr.so.1: cannot open shared object file: No such file or directory

From gedit's configure.ac:
AC_CHECK_LIB(attr, attr_copy_fd)

I suggest this is either made an unconditional dependency (based on which functionality it provides) or is conditional via a USE flag.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-09-10 15:41:52 UTC
same problem that bug #191426
Comment 2 Daniel Drake (RETIRED) gentoo-dev 2007-09-10 16:12:41 UTC
No it's not. gedit correctly looks for the dynamic libattr which was on my system.  It's not any more, libattr is *completely* gone.

The issue is with the ebuild dependency graph not being consistent with the dependencies of gedit itself when installed on a system with libattr present.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-09-12 23:05:34 UTC
I turned attr into unconditional dependency because upstream doesn't provide a switch for this. It's probably not the best thing to do but I'll look for a cleaner solution and bug upstream when I get enough time for that.

fix is in CVS, thanks for reporting and sorry for the initial answer's confusion.

Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2007-09-13 14:55:08 UTC
Unnecessary depend... and I hate unnecessary depends on my system.

The problem is dsd had sys-apps/attr on his system when he emerged attr. Now he got rid of it and gedit is upset.

The exact "functionality" this depend provides is minimal at best. When you open file "test.file" and save your changes as "zomg.new.file", it will copy the attributes from the old file to the new file.

The established USE flag for this is called "acl" and should be used. Look at sys-apps/coreutils for an example.

Attaching a patch for gedit, please kick it upstream as well.
Comment 5 Doug Goldstein (RETIRED) gentoo-dev 2007-09-13 14:55:42 UTC
Created attachment 130833 [details, diff]
gedit-libattr-shadow-depend-remove
Comment 6 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-09-13 16:21:14 UTC
applied, thanks.
Comment 7 Mart Raudsepp gentoo-dev 2007-11-28 04:24:04 UTC
<solar> FYI.. stable gedit with USE="-xattr" if libattr.so is installed will still link with it.

Paste showing the problem:

miranda:hardened  ~ # emerge -pvq gedit
[ebuild   R   ] app-editors/gedit-2.20.3  USE="spell -debug -doc -python -xattr" 
miranda:hardened  ~ # qlist -oe gedit | scanelf -f - -n -q | grep libattr.so| wc -l
11
miranda:hardened  ~ # emerge -Cq attr ; emerge gedit -q
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2007-11-29 17:52:50 UTC
Created attachment 137326 [details]
app-editors:gedit-2.20.3:20071129-170920.log

The gedit-2.20.3.ebuild reintroduced the problem, probably because the patch isn't applied in that ebuild and upstream hasn't done anything yet either.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2007-11-29 17:57:18 UTC
The same patch does apply to 2.20.3 so maybe the ebuild needs a simple update.
Comment 10 Jeroen Roovers (RETIRED) gentoo-dev 2007-11-29 18:15:33 UTC
(In reply to comment #9)
> The same patch does apply to 2.20.3 so maybe the ebuild needs a simple update.
> 

Fixed in CVS.
Comment 11 Jeroen Roovers (RETIRED) gentoo-dev 2007-11-29 18:36:43 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > The same patch does apply to 2.20.3 so maybe the ebuild needs a simple update.
> > 
> 
> Fixed in CVS.

Damn, it's not fixed at all. Reverting.
Comment 12 Jeroen Roovers (RETIRED) gentoo-dev 2007-11-29 18:50:58 UTC
This seems to do it:

--- configure.ac.       2007-10-18 11:12:44.000000000 +0200
+++ configure.ac        2007-11-29 19:41:10.000000000 +0100
@@ -139,8 +139,6 @@
 dnl libattr checks
 dnl ================================================================

-AC_CHECK_LIB(attr, attr_copy_fd)
-
 AC_MSG_CHECKING([whether libattr support is requested])
 AC_ARG_ENABLE([attr],
        AS_HELP_STRING([--enable-attr],[Enable libattr support]),
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2007-11-29 19:23:45 UTC
Fixed in CVS.
Comment 14 Jeroen Roovers (RETIRED) gentoo-dev 2007-11-29 19:34:18 UTC
http://svn.gnome.org/viewvc/gedit/branches/gnome-2-20/configure.ac?r1=5919&r2=5929

It seems the fix was never correctly applied in the first place: the original library check at line 142 was never replaced.
Comment 15 Arun Raghavan (RETIRED) gentoo-dev 2008-05-20 06:54:46 UTC
(In reply to comment #14)
> http://svn.gnome.org/viewvc/gedit/branches/gnome-2-20/configure.ac?r1=5919&r2=5929
> 
> It seems the fix was never correctly applied in the first place: the original
> library check at line 142 was never replaced.

It still not fixed (as of 2.23.1). Is there an upstream bug for this?
Comment 16 Arun Raghavan (RETIRED) gentoo-dev 2008-05-20 06:56:54 UTC
(In reply to comment #15)
> It still not fixed (as of 2.23.1). Is there an upstream bug for this?

Just to clarify, I mean this hasn't been fixed upstream.
Comment 17 Arun Raghavan (RETIRED) gentoo-dev 2008-06-13 21:06:12 UTC
This seems to have magically been fixed in 2.22.3. and trunk (http://svn.gnome.org/viewvc/gedit/trunk/configure.ac?view=markup).

Good to close.
Comment 18 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-08-03 19:06:31 UTC
indeed, it is in 2.22.3, closing.