dia-0.96.1 has been in the tree for 5 months and no bug was reported; I've used the application intensively in the last week and found no problems, so please stabilize. I'm on x86. Furthermore, this package is hard-masked by a stale entry that was added in package.mask to block some old beta releases (now removed from Portage).
I've unmasked dia. It can't go stable until it's been unmasked for 30 days, so re-open then, if we forget.
A month has passed and no bug has been filed for dia-0.96.1. So I reopen this bug for stabilization, as requested.
no bugs since at least 2007-08-01. I'd vote for stabilizing 1.2.4
oops wrong, bug. I'll look into fixing the python bug first and then ask for stabilization.
(In reply to comment #4) > oops wrong, bug. I'll look into fixing the python bug first and then ask for > stabilization. > What python bug? Isn't dia-0.96.1 ready for stabilization yet?
(In reply to comment #5) > Isn't dia-0.96.1 ready for stabilization yet? I guess not, as some more bugs "emerged" :) in the mean time ( i.e. bug #199598 )
unless I get bug reports in between, this is going in in 30 days.
Hi arches, this ebuild fixes a couple of problems and has been in the tree for almost 30 days. Please proceed with stabilization. Target keywords are: alpha amd64 hppa ia64 ppc ppc64 sparc x86 @mips, please either keyword 0.96-r1 ~mips or state if it's ok to drop keyword when I get to clean 0.95.
ppc stable
====AMD64 AT REPORT==== *Installation[OK] using the following use flags: USE="cairo doc gnome gnome-print png python zlib -debug" *No Test *Functionality[OK]: -Created an UML diagram, save file, load file [OK] -Help->Dia Object Types [OK] -Tested Undo/Redo,Antialiased and Full screen. *Documentation[OK] *rdep compilation: [OK] app-office/dia2code [OK] app-office/inkscape [OK] bug 219927, but compiles well. emerge --info: Portage 2.1.4.4 (default-linux/amd64/2007.0, gcc-4.1.2, glibc-2.6.1-r0, 2.6.24-gentoo-r4 x86_64) ================================================================= System uname: 2.6.24-gentoo-r4 x86_64 AMD Athlon(tm) 64 Processor 3200+ Timestamp of tree: Wed, 30 Apr 2008 11:30:02 +0000 app-shells/bash: 3.2_p17-r1 dev-lang/python: 2.4.4-r9 dev-python/pycrypto: 2.0.1-r6 sys-apps/baselayout: 1.12.11.1 sys-apps/sandbox: 1.2.18.1-r2 sys-devel/autoconf: 2.13, 2.61-r1 sys-devel/automake: 1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1 sys-devel/binutils: 2.18-r1 sys-devel/gcc-config: 1.4.0-r4 sys-devel/libtool: 1.5.26 virtual/os-headers: 2.6.23-r3 ACCEPT_KEYWORDS="amd64" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=k8 -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="/etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/udev/rules.d" CXXFLAGS="-march=k8 -O2 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="collision-protect distlocks metadata-transfer multilib-strict parallel-fetch sandbox sfperms strict test unmerge-orphans userfetch" GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo" LINGUAS="en es" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="3dnow X a52 acl acpi alsa amd64 berkdb bzip2 cairo cdr cli cracklib crypt dbus dga dri dvdr ffmpeg flac gdbm glitz gmp gnome gnome-keyring gpm gtk hal iconv ipv6 isdnlog ithreads jpeg lcms libnotify mad midi mmx mp3 mudflap ncurses network nls nptl nptlonly ogg opengl openmp pam pcre perl png pppd python readline reflection sdl session spell spl sse sse2 ssl startup-notification svg tcpd theora threads tiff truetype unicode v4l vorbis x264 xcomposite xorg xscreensaver xulrunner xv xvid zlib" ALSA_CARDS="emu10k1" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev keyboard mouse joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en es" USERLAND="GNU" VIDEO_CARDS="nvidia none" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
alpha/ia64/sparc stable
amd64/x86 stable
Stable for HPPA.
ppc64 stable
i'm working on gnome keywording for mips. i'll let you know if/when we keyword libgnomeprint. it should be a couple of weeks. could you keep the old ebuild until then?
Created attachment 152419 [details] dia-0.96.1-r1-x86_64-emergeinfo_buildlog Stable? I don't think so. Not one amd64, anyway.
* QA Notice: Package has poor programming practices which may compile * fine but exhibit random runtime failures. * dia_xml.c:575: warning: implicit declaration of function ‘isnan’ dia_xml.c:575: warning: implicit declaration of function ‘isinf’ arrows.c:454: warning: implicit declaration of function ‘finite’ boundingbox.c:496: warning: implicit declaration of function ‘finite’ diarenderer.c:496: warning: implicit declaration of function ‘isnan’ arc.c:481: warning: implicit declaration of function ‘finite’ load_save.c:939: warning: implicit declaration of function ‘fchmod’ load_save.c:943: warning: implicit declaration of function ‘fdopen’ * QA Notice: Package has poor programming practices which may compile * but will almost certainly crash on 64bit architectures. * Function `fdopen' implicitly converted to pointer at load_save.c:943 * * ERROR: app-office/dia-0.96.1-r1 failed. * Call stack: * misc-functions.sh, line 635: Called install_qa_check * misc-functions.sh, line 339: Called die * The specific snippet of code: * alpha*|ia64*|powerpc64*|mips64*|sparc64*|x86_64*) die "this code is not 64bit clean";; * The die message: * this code is not 64bit clean * * If you need support, post the topmost build error, and the call stack if relevant. * A complete build log is located at '/var/tmp/portage/app-office/dia-0.96.1-r1/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/app-office/dia-0.96.1-r1/temp/environment'. * !!! install_qa_check failed; exiting. Shingoshi
(In reply to comment #17) > * QA Notice: Package has poor programming practices which may compile > * fine but exhibit random runtime failures. > * QA Notice: Package has poor programming practices which may compile > * but will almost certainly crash on 64bit architectures. > * Function `fdopen' implicitly converted to pointer at load_save.c:943 > * this code is not 64bit clean > * The program works in my testings on amd64 and x86 and from comment #10. Poor programming practice is to be fixed upstream or please provide patches. Thanks. @ryan, sure, no problem. Changing keywords accordingly.
@mips, pingy :)
(In reply to comment #18) > (In reply to comment #17) > > * QA Notice: Package has poor programming practices which may compile > > * fine but exhibit random runtime failures. > > * QA Notice: Package has poor programming practices which may compile > > * but will almost certainly crash on 64bit architectures. > > * Function `fdopen' implicitly converted to pointer at load_save.c:943 > > * this code is not 64bit clean > > * > > The program works in my testings on amd64 and x86 and from comment #10. Poor > programming practice is to be fixed upstream or please provide patches. Thanks. > I have got this "poor programming" problem too, but Dia is already compiled and it is possible to use it running /var/tmp/portage/app-office/dia-0.96.1-r1/work/dia-0.96.1/app/run_dia.sh. It has never crashed and looks stable.
Created attachment 158911 [details, diff] upstream patch for 64bit compile failure This is the upstream patch from comment #1 at http://bugzilla.gnome.org/show_bug.cgi?id=436343 The patch applies cleanly and allows app-office/dia-0.96.1-r1 to install on ~amd64.
Created attachment 159793 [details] dia-0.96.1-r2.ebuild Patch applied with this ebuild, compiles and runs (64 bit) with the above patch. Can someone test this ebuild/patch for 32-bit, and then hopefully get it in portage soon?
Just wanted to note that bug 277093 (which was marked as duplicate of bug 271855) is related to this one. dia-0.96-r1 fails to compile on amd64.
closing fixed, mips keywording got it's own report as bug #277869.
