Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 191216 - net-fs/openafs-1.4.4_p20070724: stable request
Summary: net-fs/openafs-1.4.4_p20070724: stable request
Status: RESOLVED DUPLICATE of bug 199876
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Stefaan De Roeck (RETIRED)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2007-09-04 06:49 UTC by Stefaan De Roeck (RETIRED)
Modified: 2007-11-23 21:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Compile failure on ppc64 (openafs,929 bytes, text/plain)
2007-09-09 02:15 UTC, Joe Jezak (RETIRED)
Details
Patch to correct ppc64 build error (openafs-1.4.4-ppc64.patch,581 bytes, patch)
2007-09-09 11:00 UTC, Sergey Temerkhanov
Details | Diff
Fixes ppc64 build error (openafs-ppc64.patch,1.04 KB, patch)
2007-09-18 15:17 UTC, Joe Jezak (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefaan De Roeck (RETIRED) gentoo-dev 2007-09-04 06:49:31 UTC
net-fs/openafs-1.4.4_p20070724 and net-fs/openafs-kernel-1.4.4_p20070724

Reason: required when running linux-2.6.22
Has been in tree for 42 days, tested by a number of people (including myself on alpha, ~x86 and amd64)
Comment 1 Joe Jezak (RETIRED) gentoo-dev 2007-09-09 02:15:42 UTC
Created attachment 130383 [details]
Compile failure on ppc64

Marked ppc stable.  Doesn't compile on ppc64 with the attached error.
Comment 2 Joe Jezak (RETIRED) gentoo-dev 2007-09-09 02:16:05 UTC
Forgot to remove ppc from the CC list, sorry.
Comment 3 Sergey Temerkhanov 2007-09-09 11:00:26 UTC
Created attachment 130399 [details, diff]
Patch to correct ppc64 build error

(In reply to comment #1)
> Created an attachment (id=130383) [edit]
> Compile failure on ppc64
> 
> Marked ppc stable.  Doesn't compile on ppc64 with the attached error.
> 

Please try the attached patch.
Comment 4 Markus Meier gentoo-dev 2007-09-13 20:13:01 UTC
x86 stable
Comment 5 Joe Jezak (RETIRED) gentoo-dev 2007-09-18 15:17:33 UTC
Created attachment 131217 [details, diff]
Fixes ppc64 build error

Close, but another file needed the same fix.  This fixes it for ppc64.  Do you want to commit it, or should I?
Comment 6 Stefaan De Roeck (RETIRED) gentoo-dev 2007-09-18 15:22:42 UTC
(In reply to comment #5)
> Close, but another file needed the same fix.  This fixes it for ppc64.  Do you
> want to commit it, or should I?
Feel free. I can't test it anyway.
Thanks for the fix!!
Comment 7 Joe Jezak (RETIRED) gentoo-dev 2007-09-18 21:06:22 UTC
Okay, so there was one more issue that cropped up, klog was failing on both ppc and ppc64.  I just figured out why. :)  In the openafs ebuild, you're not actually applying the patch.  I think we should do an -r1, and make everyone re-test, there are a lot of changes, but it's up to you.  With the cvs update patch applied and the ppc64 patch here in the bug, klog and openafs work okay on ppc/ppc64.
Comment 8 Stefaan De Roeck (RETIRED) gentoo-dev 2007-09-19 14:17:23 UTC
Ouch...  Indeed.  I only applied the cvs-patch to the openafs-kernel ebuild.  
Fixed in net-fs/openafs-1.4.4_p20070724-r1

For the arches who have stabled the ebuilds, I see no reason to revert, as support for linux-2.6.22 kernels is fixed by the stabling...  The exception being ppc, on which klog seems to fail without the cvs-patch.  (Am I correct in assuming klog failed on the plain 1.4.4-ebuild as well?)

Joe: at first sight it looks as if your ppc64-patch is only needed for openafs, not openafs-kernel.  please ping me if this turns out to be incorrect.  
Comment 9 Joe Jezak (RETIRED) gentoo-dev 2007-09-19 15:37:26 UTC
No, the ppc64 build patch is required for openafs-kernel, the userspace tools build fine without it, but it doesn't hurt in the regular build.  Would you be fine with an early stable marking for -r1 on ppc/ppc64?  Or should we just wait since only authentication is broken?

As far as I can tell, not having the CVS patch included probably would have broken klog on all arches except for amd64 and x86.  Your call. :)
Comment 10 Stefaan De Roeck (RETIRED) gentoo-dev 2007-09-19 16:38:23 UTC
(In reply to comment #9)
> No, the ppc64 build patch is required for openafs-kernel
Now in net-fs/openafs-kernel-1.4.4_p20070724-r1
Comment 11 Joe Jezak (RETIRED) gentoo-dev 2007-09-23 01:55:49 UTC
Okay, marked ppc/ppc64 stable, thanks for taking care of the patches. :)
Comment 12 Stefaan De Roeck (RETIRED) gentoo-dev 2007-10-02 14:20:46 UTC
net-fs/openafs-1.4.4_p20070724-r1 and net-fs/openafs-kernel-1.4.4_p20070724-r2 now stable on alpha
Comment 13 Stefaan De Roeck (RETIRED) gentoo-dev 2007-10-22 08:04:19 UTC
I find this "enhancement" severity a bit ill-advised, because the current stable openafs on amd64 simply won't run on linux-2.6.22.
Comment 14 Christoph Mende (RETIRED) gentoo-dev 2007-11-23 21:31:38 UTC
this bug has been superseded by 199876

*** This bug has been marked as a duplicate of bug 199876 ***