Bugzilla Bug 190682

on gfbsd redland fails compilation:

 i686-gentoo-freebsd6.2-gcc -DHAVE_CONFIG_H -I. -I. -I.
-DPKGDATADIR=\"/usr/share/redland\" -DLIBRDF_INTERNAL=1 -march=athlon64 -pipe
-O2 -mfpmath=sse -msse2 -MT rdf_node.lo -MD -MP -MF .deps/rdf_node.Tpo -c
rdf_node.c  -fPIC -DPIC -o .libs/rdf_node.o
In file included from ./rdf_init.h:32,
                 from ./librdf.h:275,
                 from ./redland.h:42,
                 from rdf_node.c:42:
./rdf_init_internal.h:94: error: expected specifier-qualifier-list before
'pthread_mutex_t'
rdf_node.c: In function 'librdf_new_node_from_uri_string_or_uri':
rdf_node.c:173: error: 'librdf_world' has no member named 'nodes_mutex'
rdf_node.c:226: error: 'librdf_world' has no member named 'nodes_mutex'
rdf_node.c: In function 'librdf_new_node_from_typed_counted_literal':
rdf_node.c:444: error: 'librdf_world' has no member named 'nodes_mutex'
rdf_node.c:552: error: 'librdf_world' has no member named 'nodes_mutex'
i686-gentoo-freebsd6.2-gcc -DHAVE_CONFIG_H -I. -I. -I.
-DPKGDATADIR=\"/usr/share/redland\" -DLIBRDF_INTERNAL=1 -march=athlon64 -pipe
-O2 -mfpmath=sse -msse2 -MT rdf_statement.lo -MD -MP -MF
.deps/rdf_statement.Tpo -c rdf_statement.c  -fPIC -DPIC -o
.libs/rdf_statement.o

rdf_node.c: In function 'librdf_new_node_from_blank_identifier':
rdf_node.c:619: error: 'librdf_world' has no member named 'nodes_mutex'
rdf_node.c:680: error: 'librdf_world' has no member named 'nodes_mutex'
rdf_node.c: In function 'librdf_free_node':
rdf_node.c:724: error: 'librdf_world' has no member named 'nodes_mutex'
rdf_node.c:736: error: 'librdf_world' has no member named 'nodes_mutex'
rdf_node.c:788: error: 'librdf_world' has no member named 'nodes_mutex'
In file included from ./rdf_init.h:32,
                 from ./librdf.h:275,
                 from ./redland.h:42,
                 from rdf_statement.c:42:
./rdf_init_internal.h:94: error: expected specifier-qualifier-list before
'pthread_mutex_t'
rdf_statement.c: In function 'librdf_free_statement':
rdf_statement.c:262: error: 'librdf_world' has no member named
'statements_mutex'
rdf_statement.c:268: error: 'librdf_world' has no member named
'statements_mutex'
gmake[3]: *** [rdf_node.lo] Error 1
gmake[3]: *** Waiting for unfinished jobs....
gmake[3]: *** [rdf_statement.lo] Error 1
gmake[2]: *** [all-recursive] Error 1
gmake[1]: *** [all] Error 2
gmake: *** [all-recursive] Error 1


this problem is due to a missing #include pthread.h into the file
'rdf_init_internal.h', without it all the librdf/rdf_*.c files fails the
compilation as previously reported.

attached there are the patch that fix the problem and the ebuild patch.

NOTE: this package is required by KDE4, so fixing this issue now will save time
in the future when KDE4 will be an ~arch package.

Reproducible: Always

Created an attachment (id=129568) [details]
redland-1.0.6-fbsd.patch

Created an attachment (id=129570) [details]
redland-1.0.6.ebuild.patch

NOTE: as AT i have tested the patchset both on Gentoo/Linux and Gentoo/FreeBSD
and the package compile and work correctly. i'm not sure if my fix is the
proper solution at the problem, so it must be sended upstream?

inherit db-use eutils flag-o-matic
append-cppflags -I$(db_includedir)

We need that for berkdb support, aside from that everything looks good.

Have you sent the patch upstream?

(In reply to comment #3)
> NOTE: as AT i have tested the patchset both on Gentoo/Linux and Gentoo/FreeBSD
> and the package compile and work correctly. i'm not sure if my fix is the
> proper solution at the problem, so it must be sended upstream?

Yup, I really think this should be sent upstream. Wanna do me a favor and do
that ? If not, no problem.

(In reply to comment #4)
> inherit db-use eutils flag-o-matic
> append-cppflags -I$(db_includedir)
> 
> We need that for berkdb support, aside from that everything looks good.

If I do that, we have to rip of the check in configure, as its also including
db-4.3 (at least here).

--

i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I. -I/usr/include/db4.5
-I/usr/include/db4.3 -DPKGDATADIR=\"/usr/share/redland\" -I/usr/include/db4.5
-I/usr/include/db4.3 -DLIBRDF_INTERNAL=1 -O2 -pipe -march=i686 -g -ggdb2 -MT
rdf_parser_raptor.lo -MD -MP -MF .deps/rdf_parser_raptor.Tpo -c
rdf_parser_raptor.c -o rdf_parser_raptor.o >/dev/null 2>&1

(In reply to comment #6)
> (In reply to comment #4)
> > inherit db-use eutils flag-o-matic
> > append-cppflags -I$(db_includedir)
> > 
> > We need that for berkdb support, aside from that everything looks good.
> 
> If I do that, we have to rip of the check in configure, as its also including
> db-4.3 (at least here).

Actually it looks like its failing w/ db-4.5, at least when looking at the
config.log. Gonna file a separate bug for that.

That should not matter - as long as the right include dir is first.

OK, the initial fbsd issue should be fixed in CVS now.

(In reply to comment #5)
> Yup, I really think this should be sent upstream. Wanna do me a favor and do
> that ? If not, no problem.

sure, i'll do today and than i link here the bugreport.

here the upstream bugreport:
http://bugs.librdf.org/mantis/view.php?id=230