sys-admin/sysstat-7.0.4-r2 and sys-admin/sysstat-7.1.6 are needed to fix for multilib. I created patches.
Created attachment 129473 [details, diff] sysstat-7.0.4-r3.ebuild.diff sed s/lib/$(get_libdir) $FILESDIR/sysstat.init.d used prepalldocs instead of ecompress installed sysstat.crond.sample to /etc/cron.d/sysstat added pkg_postinst
Created attachment 129474 [details, diff] sysstat-7.1.6-r1.ebuild.diff same as sysstat-7.0.4-r3.ebuild.diff removed $FILESDIR/$PN-7.1.4-strip.patch because LFALGS is overwritten in emake added sa_lib_dir env var for multilib support. cleanup ebuild
Created attachment 129475 [details] files/sysstat.in this is for sysstat-7.1.6-r1.ebuild
I fixed the trivial (ebuild QA) issues without revision bumps. The multilib patch seems useful, but the other changes are controversial. I would like to see _separate_ bugs for those, because it's not all about cleaning up the ebuilds, but about making changes (with regard to crontab scripts, for instance) that I couldn't readily approve of. Could you please give me a 7.1.6 patch that focuses solely on getting multilib support? I will then do a revision bump with just the multilib changes and fix any remaining issues in later revisions.
Created attachment 129511 [details, diff] sysstat-7.1.6-multilib.diff ok, this patch is for multilib. I replaced ${S}/sysstat.in to solve @SU_C_OWNER@ variable. Please see configure.in and sysstat.in.
Created attachment 129535 [details, diff] sysstat-7.1.6-cron.diff install sysstat.crond.sample to /etc/cron.d/sysstat. its no affect because all lines are commented.
Comment on attachment 129473 [details, diff] sysstat-7.0.4-r3.ebuild.diff 7.0 is going away (bug #191656) soon.
Comment on attachment 129511 [details, diff] sysstat-7.1.6-multilib.diff The multilib issue is fixed in 8.0.0 ebuild.
Comment on attachment 129535 [details, diff] sysstat-7.1.6-cron.diff We're already installing a crontab example - I'll leave the choice of actually using it to the users.
(In reply to comment #3) > Created an attachment (id=129475) [edit] > files/sysstat.in > > this is for sysstat-7.1.6-r1.ebuild @matsuu: Could you explain what this is supposed to achieve? Are you doing something like `CRON_OWNER=foo emerge sysstat` or something? That seems to be the only thing that SU_C_OWNER sets: /var/tmp/portage/app-admin/sysstat-8.0.0/work/sysstat-8.0.0 # grep SU_C_O WNER * ... configure: SU_C_OWNER="su $CRON_OWNER -c " ...
Comment on attachment 129475 [details] files/sysstat.in ah, sorry. my check is inadequate. I think it doesn't need. btw, ${PN}-7.1.4-strip.patch is not need because LFLAGS is overwritten in emake.
(In reply to comment #11) > (From update of attachment 129475 [details] [edit]) > ah, sorry. my check is inadequate. I think it doesn't need. > > btw, ${PN}-7.1.4-strip.patch is not need because LFLAGS is overwritten in > emake. Fixed in 8.0.0 without revision bump (nothing changed in the output, really).
