Bugzilla Bug 190442

A new version for tovid is out (actually there was one other release before
that but i wanted to test it out before i bump it and bang they released
another version ;) )

Things i remarked during the tests of the newest version:

1. the devs moved their code-repository to googlecode
2. the patches we had to apply for the last official version in the portage
tree are not necessary any more
3. for the rest you should check-out the changelog here:
http://tovid.wikia.com/wiki/Tovid_changelog



Reproducible: Always

Created an attachment (id=129353) [details]
tovid-0.31.ebuild

This ebuild, and the tovid-0.30-r2.ebuild, needs to include sys-devel/bc as a
runtime dependency.  I was surprised when I discovered that bc isn't included
in the 2007.0 system profile.

This ebuild also needs the tovid-0.xx-configure.patch in order to force
configure to use /usr/lib/python.../site-packages instead of
/usr/local/.../site-packages since Gentoo doesn't include /usr/local/ in the
PYTHONPATH by default.

Also, there is a patch to todisc for 0.31 that needs to be included in this
ebuild.  I will attach both of the required patches and a modified ebuild that
includes sys-devel/bc as a runtime dependency.

Created an attachment (id=135231) [details]
Updated tovid-0.31.ebuild

Updated tovid-0.31.ebuild with bc dependency and extra patches.

Created an attachment (id=135232) [details]
tovid-0.31-configure patch

tovid-0.30-configure.patch renamed to tovid-0.31-configure.patch

Created an attachment (id=135234) [details]
tovid-0.31-todisc patch

tovid-0.31-todisc patch.

If no one is having issues, can we get this into Portage?

Been using this for a while on x86 with no problems

Created an attachment (id=140248) [details]
updated ebuild to use current configure patch in tree / new useflag 

I have add a new useflag and removed cruft if gtk/tk useflags are not set.
Upstream is working toward such configure options to handle this.

Created an attachment (id=140249) [details]
correction to post install for gtk/tk useflag.

This is just an update to the post install to display tovidgui and todiscgui if
gtk/tk useflag are enable else do not print them as being avaliable.

Created an attachment (id=140344) [details]
small correction for python${PYVER} detection.

This is the final revision, works perfectly.

The latest tovid-0.31.ebuild refers to tovid-0.30-configure.patch in this line:

epatch "${FILESDIR}/${PN}-0.30-configure.patch"

Shouldn't it be 

epatch "${FILESDIR}/${PN}-0.31-configure.patch" ?

there you go: http://bugs.gentoo.org/attachment.cgi?id=135232

when it comes to the contents of the patch it's completely the same as my
patch, just the version-string was changed. so maybe i'll update the latest
ebuild and remove the version-string of the patch tomorrow...

(In reply to comment #12)
> The latest tovid-0.31.ebuild refers to tovid-0.30-configure.patch in this line:
> 
> epatch "${FILESDIR}/${PN}-0.30-configure.patch"
> 
> Shouldn't it be 
> 
> epatch "${FILESDIR}/${PN}-0.31-configure.patch" ?
> 

There is no need to rename the patch it applies clean it is already apart of
portage so we can use it without adding anything.

(In reply to comment #3)

> Also, there is a patch to todisc for 0.31 that needs to be included in this
> ebuild.  


hmm ok but do you have more explanations why this is needed ? what does it fix
? how ? any information or link would be appreciated

(In reply to comment #15)
> (In reply to comment #3)
> 
> > Also, there is a patch to todisc for 0.31 that needs to be included in this
> > ebuild.  
> 
> 
> hmm ok but do you have more explanations why this is needed ? what does it fix
> ? how ? any information or link would be appreciated
> 
http://tovid.wikia.com/wiki/Known_bugs

finally committed, thanks everyone !

(In reply to comment #17)
> finally committed, thanks everyone !
> 

This should be reopened. There is a bug in the ebuild which still installs the
desktop files even when -wxgtk is specified.