Bugzilla Bug 190006

After remerging kexi, I got an elog mail:

/usr/share/applications/kde/kexi.desktop: value
"application/x-kexiproject-sqlite;application/x-sqlite2;application/x-kexiproject-shortcut;application/x-kexiproject-sqlite2;application/x-kexiproject-sqlite3;application/x-sqlite3;application/x-kexi-connectiondata;application/x-msaccess"
for string list key "MimeType" in group "Desktop Entry" does not have a
semicolon (';') as trailing character

Checking all my desktop files, I found the following KOffice ebuilds had
installed files containing errors:

app-office/karbon-1.6.2
app-office/kchart-1.6.3
app-office/kexi-1.6.3
app-office/kformula-1.6.2
app-office/kivio-1.6.2
app-office/koffice-data-1.6.3
app-office/koffice-libs-1.6.3
app-office/kplato-1.6.2
app-office/kpresenter-1.6.3
app-office/krita-1.6.3
app-office/kspread-1.6.2
app-office/kugar-1.6.2
app-office/kword-1.6.3-r1

As Jakub changed the Summary to give an explicit package name, I should say
that I've got koffice-meta here, as you can probably tell from the above
package list.
I would assume, however, that the single package would contain the same errors.

Ok, I am going to work on this bug, but I would prefer the input from some
gentoo devs on the best way to go about it. Would it be best to sed the file?
Or would a patch that is sendable to upstream be more appropriate? Either way I
can do it, but the question of what type of fix to use is stopping me from
fixing it. Thanks.

Created an attachment (id=129236) [details]
Ebuild diff for app-portage/kexi-1.6.3 to fix the desktop file.

I'll put patches for the others as I finish them

Created an attachment (id=129238) [details]
Karbon patch

I tested this one, Philantrop. :)

Created an attachment (id=129268) [details]
Patch for Kformula

Created an attachment (id=129269) [details]
Patch for Kword

Created an attachment (id=129319) [details]
Patch for Krita

Thanks to kojiro for help with the regular expression.

Created an attachment (id=129321) [details]
Patch for Kchart

Created an attachment (id=129377) [details]
Patch for Kivio

*** Bug 197113 has been marked as a duplicate of this bug. ***

With the 1.6.3_p20090204 ebuilds the desktop files are all fixed - at least to
the degree it's possible, given that KDE's desktop files are not entirely
standard compliant.



A general remark - a patch should always be preferred to sed expressions for at
least two reasons: As a Gentoo dev we signed¹, that our fixes reach upstream
and not doing so is bad practice. A sed expression is also to be avoided,
because it may linger around in ebuilds/eclasses, even 
when it isn't needed anymore. Expensive QA work is the result. sed expressions
are only to be used for inevitable dynamic changes, stuff not going upstream,
like branding etc.. When you fix desktop files, please rerun
desktop-file-validate yourself and fix the (suppressed) warnings as well.


[1] http://www.gentoo.org/main/en/contract.xml