Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 189796 - Stabilize x11-libs/fltk-1.1.7-r2
Summary: Stabilize x11-libs/fltk-1.1.7-r2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: MIPS Porters
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2007-08-22 07:53 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2007-12-15 21:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2007-08-22 07:53:04 UTC
Stabilize x11-libs/fltk-1.1.7-r2.
Comment 1 Santiago M. Mola (RETIRED) gentoo-dev 2007-08-22 09:29:39 UTC
Changes from 1.1.7 to 1.1.7-r2:

  07 Jul 2007; Mike Frysinger <vapier@gentoo.org> fltk-1.1.7-r2.ebuild:
  The amd64 patch is *not* amd64 specific, so apply it for everyone.

  16 Jun 2007; Diego Pettenò <flameeyes@gentoo.org> +fltk-1.1.7-r2.ebuild:
  Fix fltk-config not to report the C(XX)FLAGS used to build fltk.

  16 May 2007; Samuli Suominen <drac@gentoo.org> +files/FLTKConfig.cmake,
  +fltk-1.1.7-r1.ebuild:
  Install FLTKConfig.cmake and FLTKUse.cmake for bug 175006.

No major changes in the code and two months in the tree. So, stabilisation seems reasonable to me.
Comment 2 Ferris McCormick (RETIRED) gentoo-dev 2007-08-22 15:46:01 UTC
Um, if we look at FL/Fl_Spinner.H, we see:
double        maxinum() const { return (maximum_); }
double        mininum() const { return (minimum_); }

at lines 130, 132.  These are wrong (should be maximum, minimum, of course).  Is this something to worry about?  (Some applications --- e.g., ruby-fltk --- will not build without a fix.  Yes, I know ruby-fltk is not in our tree, but that does not stop me from playing with it.)

I don't think this is a regression; I am asking if it's worth awaiting a patch.  Otherwise, fltk-1.1.7-r2 seems fine on sparc; I'm just awaiting your recommendation.
Comment 3 Santiago M. Mola (RETIRED) gentoo-dev 2007-08-22 16:42:23 UTC
Applied the following fix from latest 1.1.x snapshot:

   double       maxinum() const { return (maximum_); }
+  double       maximum() const { return (maximum_); }
   void         maximum(double m) { maximum_ = m; }
   double       mininum() const { return (minimum_); }
+  double       minimum() const { return (minimum_); }
Comment 4 Ferris McCormick (RETIRED) gentoo-dev 2007-08-22 17:07:36 UTC
Sparc is stable.
Comment 5 Jurek Bartuszek (RETIRED) gentoo-dev 2007-08-22 17:26:16 UTC
x86 stable
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2007-08-23 16:56:35 UTC
Stable for HPPA.
Comment 7 Raúl Porcel (RETIRED) gentoo-dev 2007-08-24 21:16:03 UTC
alpha/ia64 stable
Comment 8 Wulf Krueger (RETIRED) gentoo-dev 2007-08-26 07:12:54 UTC
 * QA Notice: Pre-stripped files found:
 * /var/tmp/portage/x11-libs/fltk-1.1.7-r2/image/usr/bin/fluid

 Marked stable on amd64.
Comment 9 nixnut (RETIRED) gentoo-dev 2007-08-28 18:23:30 UTC
stable on ppc
Comment 10 Markus Rothe (RETIRED) gentoo-dev 2007-10-08 10:18:35 UTC
ppc64 stable
Comment 11 Santiago M. Mola (RETIRED) gentoo-dev 2007-12-15 21:18:37 UTC
@mips: it's no worth to stable -r2. -r3 stabilization will come soon.