Bugzilla Bug 189665

While trying to play a DVD that I ripped to my hard disk, I encountered an
mplayer segfault:

----
mplayer -dvd-device /media/firefly/FIREFLY_D1/ dvd://1
MPlayer dev-SVN-rUNKNOWN-4.1.2 (C) 2000-2007 MPlayer Team
CPU: Genuine Intel(R) CPU           T2600  @ 2.16GHz (Family: 6, Model: 14,
Stepping: 8)
CPUflags:  MMX: 1 MMX2: 1 3DNow: 0 3DNow2: 0 SSE: 1 SSE2: 1
Compiled for x86 CPU with extensions: MMX MMX2 SSE SSE2

Playing dvd://1.
libdvdread: Couldn't find device name.
There are 10 titles on this DVD.
There are 21 chapters in this DVD title.
There are 1 angles in this DVD title.


MPlayer interrupted by signal 11 in module: open_stream
- MPlayer crashed by bad usage of CPU/FPU/RAM.
  Recompile MPlayer with --enable-debug and make a 'gdb' backtrace and
  disassembly. Details in DOCS/HTML/en/bugreports_what.html#bugreports_crash.
- MPlayer crashed. This shouldn't happen.
  It can be a bug in the MPlayer code _or_ in your drivers _or_ in your
  gcc version. If you think it's MPlayer's fault, please read
  DOCS/HTML/en/bugreports.html and follow the instructions there. We can't and
  won't help unless you provide this information when reporting a possible bug.
----

(Strangely enough, it didn't seem to occur if I used the DVD media itself.)

I tracked this back (no thanks to mplayer's inability to use --enable-debug) to
a buffer/stack overrun in the libdvdcss code.

Upstream has already found this (see URL referenced above) and applying that
trivial patch fixed my issue.  I recommend either a version bump or the simple
application of the above patch.


Reproducible: Always

Steps to Reproduce:
1. Run mplayer against certain DVDs
2. Watch it crash


Actual Results:  
sigsegv

Expected Results:  
I expected it to play the DVD properly.

Bug exists in stable mplayer (media-video/mplayer-1.0.20070622-r1).  Latest
version of mplayer in portage (media-video/mplayer-1.0.20070814) has patch.

So, it does work in latest MPlayer?

Also, debug is disabled per upstream's request, as it's currently broken.

(In reply to comment #1)
> So, it does work in latest MPlayer?

Yes.  It appears to work in media-video/mplayer-1.0.20070814.

> Also, debug is disabled per upstream's request, as it's currently broken.

Yea, I saw references to that elsewhere.  I don't fault Gentoo.  I'm more
annoyed at upstream.  If they want decent bug reports it seems like that they
really should fix it (or stop telling people to use it). :-)

In mplayer-1.0.20070622-r4, thanks