First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 189334
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo KDE team <kde@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: pTeppic <gentoobugzilla@craven.dyndns.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 189334 depends on: Show dependency tree
Bug 189334 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-08-18 10:01 0000
When submitting ed2k links from Konqueror kmldonkey always opens the 'Failed to
submit link' message dialog, even if the detailed message is that the link was
added successfully.

Reproducible: Always

Steps to Reproduce:
1.Find ed2k link
2.Follow from Konqueror
3.Allow Konqueror to follow the link

Actual Results:  
Link added by client, but 'Failed to submit link' message dialog appears.

Expected Results:  
Link added by client and no error message.

A patch to fix is below.

--- ./src/scripts/submit.cpp.orig       2005-07-26 17:40:40.000000000 +0100
+++ ./src/scripts/submit.cpp    2007-08-18 10:04:14.000000000 +0100
@@ -48,7 +48,7 @@
 {
     kdDebug() << "Callback cmd: " << cmd << endl;
     kdDebug() << "Callback result: " << res << endl;
-    if (res.lower() != "done" && !res.contains("parsing http url", false)) {
+    if (!res.contains("Added link", false)) {
        /*
        if (res.contains("force_download")) {
            if (KMessageBox::warningYesNo(0, i18n("Failed to submit URL
%1\n\nForce download?")

------- Comment #1 From Jakub Moc (RETIRED) 2007-08-18 11:43:33 0000 -------
Submit this upstream, please. Not a Gentoo bug.

------- Comment #2 From Wulf Krueger (RETIRED) 2007-09-01 23:32:37 0000 -------
I've contacted upstream about this to find out if he's even still maintaining
kmldonkey.

------- Comment #3 From Wulf Krueger (RETIRED) 2007-09-02 21:58:59 0000 -------
As I expected, upstream informed me that kmldonkey is unmaintained. I've added
the patch and it works for me but if further problems arise, this package might
leave the tree.

Nevertheless: Thanks for the patch, pTeppic!

First Last Prev Next    No search results available      Search page      Enter new bug