Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 189118
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Science Related Packages <sci@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Kirill Sokolovsky <ksokolov@mpifr-bonn.mpg.de>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
ds9-5.1.ebuild-no_etags.patch Remove the emacs dependency entirely patch Henry Gebhardt 2008-02-19 00:59 0000 1.20 KB Details | Diff
ds9-5.1.ebuild.patch Remove TAGS from "all" make target patch Ulrich Müller 2008-03-22 14:09 0000 524 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 189118 depends on: Show dependency tree
Bug 189118 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-08-16 15:20 0000
sci-astronomy/ds9 ebuild needs etags command, which is part of
app-editors/emacs. If app-editors/emacs is not present in the system ds9 fails
to emerge. It would be nice if somebody could write this dependency into
sci-astronomy/ds9 ebuild. :)

Reproducible: Always

Steps to Reproduce:
1. make shure etags command is not present in $PATH (ie app-editors/emacs is
not installed)
2. emerge sci-astronomy/ds9

------- Comment #1 From Ulrich Müller 2007-08-16 20:59:23 0000 -------
etags is provided by both GNU Emacs and XEmacs, so the (build-time) dependency
should probably be something like: || ( virtual/emacs virtual/xemacs )

------- Comment #2 From Sébastien Fabbro 2007-08-17 09:56:59 0000 -------
fixed, thanks all.

------- Comment #3 From Henry Gebhardt 2008-02-19 00:59:18 0000 -------
Created an attachment (id=143928) [details]
Remove the emacs dependency entirely

------- Comment #4 From Christian Faulhammer 2008-02-19 07:38:38 0000 -------
(In reply to comment #3)
> Created an attachment (id=143928) [edit] [details]
> Remove the emacs dependency entirely

 Can you state a reason?  Apart from people not wanting Emacs.  Is the
functionality crippled without etags?

------- Comment #5 From Henry Gebhardt 2008-02-19 19:56:32 0000 -------
(In reply to comment #4)
>  Can you state a reason?  Apart from people not wanting Emacs.

No, I just don't want 100Mb of Emacs. So this is merely an unimportant
enhancement. Sorry for any inconvenience.

> Is the
> functionality crippled without etags?

No. The resulting installation is the same, although I noticed that the
/usr/bin/ds9 binary has a different md5sum after every compile (independent of
etags). The size stays exactly the same, my CFLAGS="-Wall -O2 -march=pentium4m
-pipe", so should be safe.

In any case I don't notice a difference when I run ds9. Thanks.

------- Comment #6 From Ulrich Müller 2008-03-22 14:09:02 0000 -------
Created an attachment (id=146899) [details]
Remove TAGS from "all" make target

Henry, could you please test if attached (less intrusive) approach also works?

------- Comment #7 From Henry Gebhardt 2008-03-24 22:05:29 0000 -------
Hi, thanks for the patch. I don't use ds9 extensively anymore, but basic tasks
as well as basic XPA-commands work very well. I certainly don't notice a
difference running it.

However, I did notice that the size of the /usr/bin/ds9 binary differs by 2
bytes: 10297167 with etags versus 10297169 with your patch. My CFLAGS currently
are "-march=pentium3 -msse2 -O2 -pipe" on a pentium4m (some of my numerical
apps are noticably faster that way, weird...), so it could be related to that.

Of course, the md5sum is still different after each compile, but that is
independent of any patches presented here.

Also, there was a segmentation fault when closing the "ROSAT All-Sky (MPE/MPG)"
Archive, but it doesn't always occurr. In any case, I doubt it was related to
this bug, as it occurred multiple times with etags as well as with your patch.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug