Bug 188778 – net-nds/ypbind init script uses bashisms

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arthur Hagen 2007-08-14 00:50:10 UTC]

The new version of net-nds/ypbind-1.19.1-r1 (new version without bump) has bash dependency regression bugs in /etc/init.d/ypbind.



Reproducible: Always

Steps to Reproduce:
tree init.d # diff ._cfg0000_ypbind ypbind
4c4
< # $Header: /var/cvsroot/gentoo-x86/net-nds/ypbind/files/ypbind.initd,v 1.4 200
7/05/23 07:20:55 eradicator Exp $
---
> # $Header: /var/cvsroot/gentoo-x86/net-nds/ypbind/files/ypbind.initd,v 1.3 200
6/04/10 19:57:11 eradicator Exp $
13,15c13
<       if [[ -n "${YPBIND_OPTS}" ]]; then
<               YOPTS="-- ${YPBIND_OPTS}"
<       fi
---
>       if [ -n "${YPBIND_OPTS}" ]; then YOPTS="-- ${YPBIND_OPTS}"; fi
17,18c15
<       local ret=$?
<       if [[ $ret -eq 0 ]] ; then
---
>       if [ -n "$?" ] ; then
25c22
<               if [[ $notfound -eq 1 ]] ; then
---
>               if [ $notfound -eq 1 ] ; then
31c28
<               eend $ret
---
>               eend $?




runscript should not depend on bash being the shell, and care should be taken not to use bashisms in init.d scripts.

[Comment 1 Arthur Hagen 2007-08-14 00:58:50 UTC]

Fixes for bug #169422 is probably where the regression to bash occurred.

[Comment 2 Jeremy Huddleston (RETIRED) 2007-08-15 17:52:58 UTC]

Fixed, thanks.  I was under the impression runscript always used bash.