188691 – app-text/djvu-3.5.19 shouldn't install .desktop without USE=qt3

Bug 188691 - app-text/djvu-3.5.19 shouldn't install .desktop without USE=qt3

Summary: app-text/djvu-3.5.19 shouldn't install .desktop without USE=qt3

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High trivial (vote)
Assignee:	Peter Volkov (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-08-13 09:03 UTC by Justin Blanchard
Modified:	2007-08-13 10:27 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Justin Blanchard 2007-08-13 09:03:42 UTC

app-text/djvu installs "djview" (standalone viewer) only under USE=qt3.
Since it installs the icon and /usr/share/applications entry unconditionally, anyone without USE=qt3 gets an unusable desktop menu item.

Reproducible: Always

Steps to Reproduce:




This bug can be fixed by making lines 100-101 of djvu-3.5.19.ebuild conditional:
+if use qt3 ; then
    insinto /usr/share/icons/hicolor/32x32/apps && newins hi32-djview3.png djvulibre-djview3.png
    insinto /usr/share/applications/ && doins djvulibre-djview3.desktop
+fi

Thanks :)

Comment 1 Peter Volkov (RETIRED) gentoo-dev

2007-08-13 10:27:38 UTC

Thank you for report, Justin. Fixed in djvu-3.5.19-r1.ebuild.