First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 187882
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Sound Team <sound@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: marty rosenberg <marty.rosenberg@gmail.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 187882 depends on: Show dependency tree
Show dependency graph
Bug 187882 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2007-08-06 07:55 0000 
Not really gentoo specific, unless this is a problem caused by a gentoo patch.
in flac-1.2.0/src/flac/encode.c, on line 2181, 

if(e->use_ogg && e->total_samples_to_encode > 0 && e->total_samp
les_to_encode / e->sample_rate / 10 > 230)

should be

if(
#if FLAC__HAS_OGG
e->use_ogg &&
#endif
 e->total_samples_to_encode > 0 && e->total_samp
les_to_encode / e->sample_rate / 10 > 230)

or something else equivalent.  Personally, I think that the 'changing contents
of if statement based on compile time flags' is disgusting, but whatever.

------- Comment #1 From Samuli Suominen 2007-08-06 10:45:43 0000 ------- 
(In reply to comment #0)
> Not really gentoo specific, unless this is a problem caused by a gentoo patch.
> in flac-1.2.0/src/flac/encode.c, on line 2181, 

It's not because of our patches but definately a problem, thanks.. looking at
it.

------- Comment #2 From Samuli Suominen 2007-08-06 11:12:46 0000 ------- 
Applied upstream patch fixing this. Thanks again for reporting :)
First Last Prev Next    No search results available      Search page      Enter new bug