Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 187581 - sys-power/cpufreqd-2.2.1: logical error for CPU_ALL in cpu_evaluate
Summary: sys-power/cpufreqd-2.2.1: logical error for CPU_ALL in cpu_evaluate
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mobile Herd (OBSOLETE)
URL: http://sourceforge.net/tracker/index....
Whiteboard:
Keywords:
Depends on:
Blocks: 178169
  Show dependency tree
 
Reported: 2007-08-03 12:52 UTC by Martin von Gagern
Modified: 2009-10-27 09:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch correcting the logic (2.2.1-cpu_all.patch,1.31 KB, patch)
2007-08-03 12:55 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2007-08-03 12:52:20 UTC
There is a logical bug in sys-power/cpufreqd-2.2.1. I have a patch ready and submitted it upstream, see URL. I don't know how fast upstream will be to react; maybe Gentoo wants to provide a patched revision. Maybe you even want this fixed before stabilizing as requested by 178169, I'm not sure.
Comment 1 Martin von Gagern 2007-08-03 12:55:59 UTC
Created attachment 126797 [details, diff]
patch correcting the logic

The same patch as upstream, as the Gentoo bug tracker has nicer patch display.
Comment 2 Martin von Gagern 2008-04-07 19:18:18 UTC
Still an issue, still not fixed upstream, so I still vote for Gentoo including this fix at least on the distro level.
Comment 3 Martin von Gagern 2008-09-04 09:01:17 UTC
Fix still not included in upstream 2.3.3 (see bug 233481 for bump request).
Comment 4 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-10-20 09:49:11 UTC
so this hasn't made it into 2.3.4 either? why?

i'd prefer if bugs like these where handled by upstream...
Comment 5 Martin von Gagern 2009-10-20 10:09:12 UTC
(In reply to comment #4)
> so this hasn't made it into 2.3.4 either?

No, judging from the fact that my patch in my local overlay still applies cleanly, and the fact that the source file in question hasn't seen a change in over a year.

> why?

Whish I knew. I guess upstream doesn't regularly look at the patches tracker, and either they forgot about a mail they got when I first submitted the thing, or there was no such mail. I guess I could try poking them on some mailing list, see if I can get a reaction there. Or do you know of a reliable way to contact the cpufreqd devs?

> i'd prefer if bugs like these where handled by upstream...

So do I. But I'd rather have it handled by Gentoo than not handled at all.
Comment 6 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-10-20 10:13:55 UTC
yes - please try to contact upstream again. the new maintainer may just not have looked into it yet...
thanks
Comment 7 Martin von Gagern 2009-10-20 10:59:43 UTC
(In reply to comment #6)
> yes - please try to contact upstream again.

Done that:
http://sourceforge.net/mailarchive/forum.php?thread_name=4ADD8D70.9000903%40gmx.net&forum_name=cpufreqd-devel
Looking at the archive, the 6th most recent thread is by me as well, dating over a year back now. That might have caused trouble due to my use of GPG/MIME, though, so maybe they couldn't read it. The archives certainly have trouble.

> the new maintainer may just not have looked into it yet...

They have a new maintainer? There you know more than me. Looking at the git commits, it seems that Mattia Dongili has done all commits, and he's been the main committer for as long as the CVS can remember, as far as I can see.

Thanks to my investigations on this issue I have found out that they have moved from CVS to git, so the source browser at the SF project page is outdated. My statement about cpufreqd_cpu.c being unchanged for over a year remains valid.
Comment 8 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-10-20 11:26:57 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > yes - please try to contact upstream again.
> 
> Done that:
> http://sourceforge.net/mailarchive/forum.php?thread_name=4ADD8D70.9000903%40gmx.net&forum_name=cpufreqd-devel
> Looking at the archive, the 6th most recent thread is by me as well, dating
> over a year back now. That might have caused trouble due to my use of GPG/MIME,
> though, so maybe they couldn't read it. The archives certainly have trouble.
> 

yes - and mattia responded already. good news..
while we are at it, perhaps you want to push the lm_sensors patch from bug #233481?

> > the new maintainer may just not have looked into it yet...
> 
> They have a new maintainer? There you know more than me. Looking at the git
> commits, it seems that Mattia Dongili has done all commits, and he's been the
> main committer for as long as the CVS can remember, as far as I can see.
> 

ah - ok. i got the impression, due to the new homepage and the copyright notice there....

thanks
Comment 9 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-10-27 09:09:16 UTC
cpufreqd-2.3.4-r1 has this patch.
thanks for the work.