First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 186901
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Crypto team <crypto@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: virdiq <virdiq@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
truecrypt-4.3a_kernel_2.6.23_fix.patch truecrypt-4.3a_kernel_2.6.23_fix.patch (patches truecrypt 4.3a to work with the 2.6.23-rc1 kernel) patch virdiq 2007-07-28 14:00 0000 501 bytes Details | Diff
truecrypt-4.3a-r1.ebuild app-crypt/truecrypt/truecrypt-4.3a-r1.ebuild text/plain virdiq 2007-07-28 14:02 0000 3.23 KB Details
truecrypt_ebuild_4.3a_to_4.3a-r1.patch diff of changes between 4.3a and 4.3a-r1 ebuilds patch virdiq 2007-07-28 14:06 0000 433 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 186901 depends on: Show dependency tree
Bug 186901 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-07-28 13:59 0000
I know this is in relation to the beta kernel, but I thought I'd post it here
to help out anyone who may have a similar problem in the future. This may also
be useful if the 2.6.23 kernel is released before a fix from the truecrypt
developers is available.

The 2.6.23-rc1 kernel (vanilla) has made a change to the kmem_cache_create()
function where it now has one less argument. A patch is required for the
truecrypt source code so that this extra argument is dropped.

I have attached a new .patch and a new truecrypt 4.3a r1 ebuild to solve these
problems.

Reproducible: Always

Steps to Reproduce:
1. emerge -av truecrypt

Actual Results:  
/var/tmp/portage/app-crypt/truecrypt-4.3a-r1/work/truecrypt-4.3a-source-code/Linux/Kernel/Dm-target.c:
In function 'dm_truecrypt_init':
/var/tmp/portage/app-crypt/truecrypt-4.3a-r1/work/truecrypt-4.3a-source-code/Linux/Kernel/Dm-target.c:659:
error: too many arguments to function 'kmem_cache_create'
make[2]: ***
[/var/tmp/portage/app-crypt/truecrypt-4.3a-r1/work/truecrypt-4.3a-source-code/Linux/Kernel/Dm-target.o]
Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: ***
[_module_/var/tmp/portage/app-crypt/truecrypt-4.3a-r1/work/truecrypt-4.3a-source-code/Linux/Kernel]
Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.23-rc1'
make: *** [truecrypt] Error 2

!!! ERROR: app-crypt/truecrypt-4.3a-r1 failed.
Call stack:
  ebuild.sh, line 1621:   Called dyn_compile
  ebuild.sh, line 973:   Called qa_call 'src_compile'
  ebuild.sh, line 44:   Called src_compile
  truecrypt-4.3a-r1.ebuild, line 54:   Called linux-mod_src_compile
  linux-mod.eclass, line 516:   Called die

!!! Unable to make  KERNEL_SRC=/usr/src/linux NO_WARNINGS=1 truecrypt.

------- Comment #1 From virdiq 2007-07-28 14:00:48 0000 -------
Created an attachment (id=126223) [edit]
truecrypt-4.3a_kernel_2.6.23_fix.patch (patches truecrypt 4.3a to work with the
2.6.23-rc1 kernel)

------- Comment #2 From virdiq 2007-07-28 14:02:30 0000 -------
Created an attachment (id=126224) [edit]
app-crypt/truecrypt/truecrypt-4.3a-r1.ebuild

New ebuild for truecrypt 4.3a which has a src_unpack() function added to patch
the source code if the kernel version is greater than or equal to 2.6.23. This
patch is required in order to compile the truecrypt kernel module on
2.6.23-rc1.

------- Comment #3 From virdiq 2007-07-28 14:06:24 0000 -------
Created an attachment (id=126226) [edit]
diff of changes between 4.3a and 4.3a-r1 ebuilds

------- Comment #4 From Alon Bar-Lev (RETIRED) 2007-07-28 19:26:55 0000 -------
Thanks!
But kernel tends to add more issues until it is released...
So we will wait for final before fixing anything.

------- Comment #5 From Alon Bar-Lev (RETIRED) 2007-10-10 21:27:28 0000 -------
.

------- Comment #6 From Kevin Funk 2007-10-11 15:13:25 0000 -------
2.6.23 is now released, please commit the patched ebuild.

------- Comment #7 From Jakub Moc (RETIRED) 2007-10-14 19:08:00 0000 -------
*** Bug 195859 has been marked as a duplicate of this bug. ***

------- Comment #8 From Jakub Moc (RETIRED) 2007-10-14 19:08:46 0000 -------
Reopen.

------- Comment #9 From Alon Bar-Lev (RETIRED) 2007-10-14 19:11:20 0000 -------
Why?
Works...
Can anyone paste some logs? and emerge --info?

------- Comment #10 From virdiq 2007-10-15 07:36:46 0000 -------
I'm confirming that the patch is no longer required with the following
specifications (trimmed emerge --info):

Portage 2.1.3.9 (default-linux/amd64/2007.0, gcc-4.1.2, glibc-2.5-r4, 2.6.23
x86_64)
=================================================================
System uname: 2.6.23 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
Timestamp of tree: Mon, 15 Oct 2007 06:50:01 +0000
app-shells/bash:     3.2_p17
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.4.4-r5
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.9-r2
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17-r1
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -msse3 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CXXFLAGS="-march=athlon64 -msse3 -O2 -pipe"
FEATURES="distlocks metadata-transfer sandbox sfperms strict unmerge-orphans
userfetch"
MAKEOPTS="-j3"


I'm not sure what changed, but this ebuild doesn't seem to be need patching. It
is either something that changed in one of the later -rc's of 2.6.23 or was
caused by an upgrade from 2.6.21 headers to the latest stable 2.6.22 headers.

------- Comment #11 From throw_away_2002@yahoo.com 2007-10-29 13:01:30 0000 -------
4.3 still fails (with slightly more verbose logs due to the new portage :) )

/var/tmp/portage/app-crypt/truecrypt-4.3/work/truecrypt-4.3-source-code/Linux/Kernel/Dm-target.c:659:
error: too many arguments to function ‘kmem_cache_create’
make[2]: ***
[/var/tmp/portage/app-crypt/truecrypt-4.3/work/truecrypt-4.3-source-code/Linux/Kernel/Dm-target.o]
Error 1
make[1]: ***
[_module_/var/tmp/portage/app-crypt/truecrypt-4.3/work/truecrypt-4.3-source-code/Linux/Kernel]
Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.23-gentoo'
make: *** [truecrypt] Error 2
 *
 * ERROR: app-crypt/truecrypt-4.3 failed.
 * Call stack:
 *              ebuild.sh, line 1695:  Called dyn_compile
 *              ebuild.sh, line 1033:  Called qa_call 'src_compile'
 *              ebuild.sh, line   44:  Called src_compile
 *   truecrypt-4.3.ebuild, line   45:  Called linux-mod_src_compile
 *       linux-mod.eclass, line  518:  Called die
 * The specific snippet of code:
 *                      emake HOSTCC="$(tc-getBUILD_CC)" CC="$(get-KERNEL_CC)"
LDFLAGS="$(get_abi_LDFLAGS)" \
 *                                ${BUILD_FIXES} ${BUILD_PARAMS}
${BUILD_TARGETS} \
 *                              || die "Unable to make ${BUILD_FIXES}
${BUILD_PARAMS} ${BUILD_TARGETS}."
 *  The die message:
 *   Unable to make  KERNEL_SRC=/usr/src/linux NO_WARNINGS=1 truecrypt.
 *
 * If you need support, post the topmost build error, and the call stack if
relevant.
 * A complete build log is located at
'/var/log/portage/app-crypt:truecrypt-4.3:20071029-102626.log'.

Portage 2.1.3.16 (default-linux/x86/2007.0/desktop, gcc-4.1.2, glibc-2.6.1-r0,
2.6.23-gentoo i686)
=================================================================
System uname: 2.6.23-gentoo i686 Intel(R) Pentium(R) 4 CPU 3.00GHz
Timestamp of tree: Mon, 29 Oct 2007 02:30:01 +0000
app-shells/bash:     3.2_p17
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.4.4-r6
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.9-r2
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium4 -O2 -pipe -fomit-frame-pointer -mfpmath=sse"
CHOST="i686-pc-linux-gnu"
CXXFLAGS="-march=pentium4 -O2 -pipe -fomit-frame-pointer -mfpmath=sse"
FEATURES="distlocks metadata-transfer sandbox sfperms strict unmerge-orphans
userfetch"
MAKEOPTS="-j3"

$ diff /usr/portage/app-crypt/truecrypt/truecrypt-4.3.ebuild
/usr/portage/app-crypt/truecrypt/truecrypt-4.3a.ebuild
3c3
< # $Header: /var/cvsroot/gentoo-x86/app-crypt/truecrypt/truecrypt-4.3.ebuild,v
1.4 2007/04/28 16:10:05 armin76 Exp $
---
> # $Header: /var/cvsroot/gentoo-x86/app-crypt/truecrypt/truecrypt-4.3a.ebuild,v 1.2 2007/10/10 21:27:00 alonbl Exp $
23c23
< KEYWORDS="amd64 x86"
---
> KEYWORDS="~amd64 ~x86"
43a44,49
> src_unpack() {
>       unpack ${A}
>       cd "${S}"
>       epatch "${FILESDIR}/${P}-2.6.23.patch"
> }
>

Shouldn't the (only) stable version have the patch, as well?

------- Comment #12 From Alon Bar-Lev (RETIRED) 2007-10-29 13:44:11 0000 -------
> Shouldn't the (only) stable version have the patch, as well?
No.
As 2.6.23 is not stable either.

------- Comment #13 From Daniel Drake 2007-10-29 15:55:51 0000 -------
Reopening as this is broken in the stable tree.. I'm now working towards 2.6.23
stabling in 2 weeks time, so this stuff should ideally be fixed in stable if
possible.

------- Comment #14 From Alon Bar-Lev (RETIRED) 2007-10-30 20:56:43 0000 -------
Please don't reopen bugs for stable request.
Opened bug#197557.
Thanks.

------- Comment #15 From Jakub Moc (RETIRED) 2007-10-31 22:21:57 0000 -------
*** Bug 197692 has been marked as a duplicate of this bug. ***

First Last Prev Next    No search results available      Search page      Enter new bug