Bugzilla Bug 186750

type about:buildconfig in mozilla-firefox or epiphany built on xulrunner,
you'll see
-Wno-non-virtual-dtor -Wno-long-long -march=athlon64 -pipe -fPIC
-Wno-return-type -w -fshort-wchar -pthread -pipe -DARON_WAS_HERE  <---
same in seamonkey
Wno-non-virtual-dtor -Wno-long-long -march=athlon64 -pipe -fPIC
-Wno-return-type -w -fshort-wchar -pthread -pipe
-DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\"
-DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\"  <---

The reason is that we substitute the seamonkey builconfig.html residing in xpfe
also in mozilla-firefox and xulrunner ebuilds.
However, there is a second buildconfig.html in toolkit/content that is the
correct one for toolkit applications like mozilla-firefox and xulrunner
patch for the ebuild to follow

Reproducible: Always

Created an attachment (id=126107) [edit]
mozilla-firefox-2.0.0.5.ebuild patch

Created an attachment (id=126108) [edit]
xulrunner-1.8.1.5 patch

Hmmm? What's exactly wrong with that?

(In reply to comment #3)
> Hmmm? What's exactly wrong with that?
> 
For some problems with econf the define
-DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\" cannot be used during
configuring, therefor the placeholder -DARON_WAS_HERE is used, that becomes
substituted by sed during compile time. In case of mozilla-firefox and
xulrunner we have to do the substition in buildconfig.html in the
toolkit/content directory and not in the xpfe/global directory. The latter is
for seamonkey. When we do the substitution in the correct file, we see also in
mozilla-firefox or xulrunner embedded browsers in about:buildconfig
-DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\"
-DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\" and not
-DARON_WAS_HERE
Of course, this is only cosmetics, therefore of only minor severity but its
easy to fix.

changing Summary to be more precise

Fixed on firefox, seamonkey, and xulrunner, i'll leave this bug open so i don't
forget about thunderbird

Thanks

(In reply to comment #6)
> Fixed on firefox, seamonkey, and xulrunner, i'll leave this bug open so i don't
> forget about thunderbird
> 
> Thanks
> 

Thanks for fixing this, however I didn't post a patch for Seamonkey as in this
particular case 
${S}/xpfe/global/buildconfig.html
was correct.
For thunderbird we won't need a fix as we don't support plugins.

Yes, this change should be reverted in seamonkey ebuilds until seamonkey-2.0 is
out which will use toolkit as well...

Okay, all done then.

Thanks

(In reply to comment #9)
> Okay, all done then.
> 
> Thanks
> 

Sorry to bother again, the correct substitution for firefox and xulrunner is
/toolkit/content/ not /toolkit/global/ as it's now in the new ebuilds.

Fixed again, thanks, sorry for making mistakes, my head fails a bit :)