Bug 186750 – mozilla-firefox/xulrunner ebuilds sed substitution of wrong file

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Walter Meinl 2007-07-27 06:37:10 UTC]

type about:buildconfig in mozilla-firefox or epiphany built on xulrunner, you'll see
-Wno-non-virtual-dtor -Wno-long-long -march=athlon64 -pipe -fPIC -Wno-return-type -w -fshort-wchar -pthread -pipe -DARON_WAS_HERE  <---
same in seamonkey
Wno-non-virtual-dtor -Wno-long-long -march=athlon64 -pipe -fPIC -Wno-return-type -w -fshort-wchar -pthread -pipe -DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\" -DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\"  <---

The reason is that we substitute the seamonkey builconfig.html residing in xpfe also in mozilla-firefox and xulrunner ebuilds.
However, there is a second buildconfig.html in toolkit/content that is the correct one for toolkit applications like mozilla-firefox and xulrunner
patch for the ebuild to follow

Reproducible: Always

[Comment 1 Walter Meinl 2007-07-27 06:38:23 UTC]

Created attachment 126107 [details, diff]
mozilla-firefox-2.0.0.5.ebuild patch

[Comment 2 Walter Meinl 2007-07-27 06:39:00 UTC]

Created attachment 126108 [details, diff]
xulrunner-1.8.1.5 patch

[Comment 3 Jakub Moc (RETIRED) 2007-07-27 06:47:48 UTC]

Hmmm? What's exactly wrong with that?

[Comment 4 Walter Meinl 2007-07-27 15:40:58 UTC]

(In reply to comment #3)
> Hmmm? What's exactly wrong with that?
> 
For some problems with econf the define -DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\" cannot be used during configuring, therefor the placeholder -DARON_WAS_HERE is used, that becomes substituted by sed during compile time. In case of mozilla-firefox and xulrunner we have to do the substition in buildconfig.html in the toolkit/content directory and not in the xpfe/global directory. The latter is for seamonkey. When we do the substitution in the correct file, we see also in mozilla-firefox or xulrunner embedded browsers in about:buildconfig -DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\"
-DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\" and not -DARON_WAS_HERE
Of course, this is only cosmetics, therefore of only minor severity but its easy to fix.

[Comment 5 Walter Meinl 2007-09-20 06:50:48 UTC]

changing Summary to be more precise

[Comment 6 Raúl Porcel (RETIRED) 2007-10-21 20:53:10 UTC]

Fixed on firefox, seamonkey, and xulrunner, i'll leave this bug open so i don't forget about thunderbird

Thanks

[Comment 7 Walter Meinl 2007-10-21 21:13:30 UTC]

(In reply to comment #6)
> Fixed on firefox, seamonkey, and xulrunner, i'll leave this bug open so i don't
> forget about thunderbird
> 
> Thanks
> 

Thanks for fixing this, however I didn't post a patch for Seamonkey as in this particular case 
${S}/xpfe/global/buildconfig.html
was correct.
For thunderbird we won't need a fix as we don't support plugins.

[Comment 8 Lars Wendler (Polynomial-C) (RETIRED) 2007-10-22 07:26:43 UTC]

Yes, this change should be reverted in seamonkey ebuilds until seamonkey-2.0 is out which will use toolkit as well...

[Comment 9 Raúl Porcel (RETIRED) 2007-10-22 09:38:45 UTC]

Okay, all done then.

Thanks

[Comment 10 Walter Meinl 2007-10-22 14:22:36 UTC]

(In reply to comment #9)
> Okay, all done then.
> 
> Thanks
> 

Sorry to bother again, the correct substitution for firefox and xulrunner is /toolkit/content/ not /toolkit/global/ as it's now in the new ebuilds.

[Comment 11 Raúl Porcel (RETIRED) 2007-10-22 14:35:50 UTC]

Fixed again, thanks, sorry for making mistakes, my head fails a bit :)