Bugzilla Bug 186393

see summary. new version available. thanks!


Reproducible: Always

Steps to Reproduce:

1.04 is available

Created an attachment (id=136103) [edit]
ebuild for nullmailer from debian/stable

I also added two use-flags:

*ipv6* to enable/disable ipv6 patch. Seems, it's right assumption that ipv6
patch adds ipv6 support (is not ipv6-related bugfix patch).

*djb* to disable daemontools scripts usage as init.d script may be enough.

Created an attachment (id=142401) [edit]
ebuild for nullmailer-1.04 from debian/testing

I replaced use-flag "djb" with "nodjb" for backwards-compatibility with
existing ebuild.

1.04 fixed one annoying bug:
- Fixed rewriting mail to @localhost if defaultdomain is set by not
  appending .defaultdomain to *@localhost.
(from http://untroubled.org/nullmailer/NEWS)
so now «nullmailer-inject localuser@localhost» works better

robin: any objections, if i put some effort into getting this in the tree?
qmqp is broken in older versions....

Created an attachment (id=144034) [edit]
nullmailer-1.02-r2-1.03-r1.ebuild

I haven't tested 1.04 at all, but upstream 1.03 was very crappy and broken.
Find attached the diff between 1.02-r2 and my 1.03-r1 testing build.

IMHO, 1.03 is worse than 1.04 as it has bug that can't be fixed with
configuration tuning.
My test environment is not big, but 1.04 works at least at two my x86 machines
resending mail to faraway postfix.

i have added my proposal for nullmailer-1.04 to my overlay at
http://overlays.gentoo.org/dev/bangert/browser/ebuilds/mail-mta/nullmailer

i'll look into testing some of these on monday.

Created an attachment (id=144497) [edit]
adding nodjb USE flag to Thilo's ebuild.

By the way. Thilo's ebuild also produces following QA notice
 * QA: stop using the bindnow-flags function ... simply drop it from your
ebuild

It's not fixed in this patch.

leonid: i had forgotten to commit the removal of the append-ldflags line...
fixed now.

also, the nodjb flag is very unlikely to reach the tree... its a negative USE
flag, which should not be used. you could use a -djb use flag, but IMHO the
changes you attach to it, dont warrant a USE flag. there are other mechanisms
to disallow the installation of specific files.

The only reason that made me select negative flag is keeping backward
compatibility with existing installations. If it's not necessary, then I agree
that positive flag is much better.

I really don't see another way to achieve the same with settings. I want to
make some dependency optional, isn't USE flag right tool for that ?

If I mask daemontools then I'll be unable to install nullmailer.
If I put daemontools to "provided" then I'll lie to portage. Once another
package will strictly require daemontools and it'll assume that it's installed,
so I'll get broken system.

hmm, yeah - you are right. i forgot about that (who doesnt want daemontools on
their system ;-). 

then i'd still prefer another name - like daemontools.
robbat2, whats your opinion?

I'd like to take a middle ground like dev-util/git.

Make this change the postinst output, and take daemontools+supervise-scripts
out of the [R]DEPEND. DO still create everything in /var/nullmailer/service/.
FYI, runit can also use the /var/nullmailer/service/ stuff, so it isn't really
daemontool-specific that way.

-elog "To start nullmailer at boot you have to enable the /etc/init.d/svscan rc
file"
-elog "and create the following link :"
-elog "ln -fs /var/nullmailer/service /service/nullmailer"
-elog "As an alternative, we also provide an init.d script."
+elog "To start nullmailer at boot you may use either the nullmailer init.d"
+elog "script, or emerge sys-process/supervise-scripts, enable the"
+elog "svscan init.d script and create the following link:"
+elog "ln -fs /var/nullmailer/service /service/nullmailer"

1.04 works like a charm for me (no auth or login though)

robbat2: great compromise.
then there is the mailwrapper issue. any specific reason why nullmailer deps on
the masked version of mailwrapper?

mailwrapper stuff should be removed, see the stuff from ferdy before - it was a
failed experiment in Gentoo.

Created an attachment (id=144702) [edit]
1.04 vs 1.02-r2

great. i have updated the ebuild in my overlay - find attached a diff to
1.02-r2.

feel free to cherry pick :)
comments, critics and flames welcome.

comments on the latest patch:
- please install the ChangeLog
- ipv6 non-optional. The patch should always be applied, the configure test
will handle the system correctly.
- should have a !virtual/mta in RDEPEND

Other than that, if it works for you, +1 for you to commit it, and feel free to
list yourself in the metadata too.

nullmailer-1.04 is in the tree now.

there was another problem with the sample config - the syntax for smtp auth had
changed. we now install a version of the file which is accurate again. i was
also able to test smtp auth and it works fine for me - both PLAIN and LOGIN.

i haven't removed the mask on 1.04 yet - but will do so tonight (that's in
roughly 12 hours) - unless somebody beats me to it.

also i thought we might remove the older unstable ebuilds and get 1.04 marked
stable soonish (as in 30 days) - if nothing shows up.

mask on nullmailer-1.04 lifted.
thanks everybody