Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 185574 - dev-db/sqlite-3.4.1 version bump (test request for amd64)
Summary: dev-db/sqlite-3.4.1 version bump (test request for amd64)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2007-07-16 19:02 UTC by Vladimir Brik
Modified: 2007-10-05 14:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sqlite-3.4.0.ebuild (sqlite-3.4.0.ebuild,1.90 KB, text/plain)
2007-07-16 19:03 UTC, Vladimir Brik
Details
patch to disable expression test 104 (test_expr.patch,524 bytes, patch)
2007-07-16 19:04 UTC, Vladimir Brik
Details | Diff
patch to disable types3-1.3 test (test_types3.patch,621 bytes, patch)
2007-07-16 19:04 UTC, Vladimir Brik
Details | Diff
SIGFPE on 64-bit platforms fix 1/2 (sqlite_patchset_4130.diff,1.58 KB, patch)
2007-07-17 12:49 UTC, Vladimir Brik
Details | Diff
SIGFPE on 64-bit platforms fix 2/2 (sqlite_patchset_4131.diff,382 bytes, patch)
2007-07-17 12:50 UTC, Vladimir Brik
Details | Diff
64-bit/tcl regression failure with types3-1.3 fix 1/2 (sqlite_patchset_4134.diff,833 bytes, patch)
2007-07-17 12:52 UTC, Vladimir Brik
Details | Diff
64-bit/tcl regression failure with types3-1.3 fix 2/2 (sqlite_patchset_4135.diff,1.88 KB, patch)
2007-07-17 12:52 UTC, Vladimir Brik
Details | Diff
sqlite-3.4.0.ebuild updated to use official patches for test case failures on 64 bit systems (sqlite-3.4.0.ebuild,2.09 KB, text/plain)
2007-07-17 12:59 UTC, Vladimir Brik
Details
sqlite-3.4.0.ebuild with copyright header restored (sqlite-3.4.0.ebuild,2.20 KB, text/plain)
2007-07-17 16:36 UTC, Vladimir Brik
Details
sqlite-3.4.1.ebuild (sqlite-3.4.1.ebuild,1.91 KB, text/plain)
2007-07-22 18:49 UTC, Vladimir Brik
Details
Build+Failure log (dev-db:sqlite-3.4.1:20070819-010813.log,697.25 KB, text/plain)
2007-08-19 01:17 UTC, Thomas Anderson (tanderson) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Brik 2007-07-16 19:02:05 UTC
Attached are the ebuild for sqlite 3.4 and associated patches.

sqlite 3.4 was released on June 18th, 2007. Latest version in portage is 3.3.17. 

Most notably, 3.4 fixed two database corruption bugs, which claimed a few of my 15GB+ databases. Due to these bugs updating is "strongly recommended" (see sqlite.org News section). Full changelog is here: http://www.sqlite.org/changes.html

There are a few issues with sqlite test suite, at least on 64 bit systems. I attached patches to comment those tests out. These might be related to similar 64 bit issues in 3.3.17 ebuild, which also applied patches to remove some tests. However, different tests failed on my system. Therefore, the attached ebuild does not apply old patches, but includes two new ones.

sqlite 3.4 appears to be running fine on x64_86 and x86, though I did not use it extensively. I could only test the test suite on x64_86.

I hope you will find this useful.
Comment 1 Vladimir Brik 2007-07-16 19:03:18 UTC
Created attachment 125066 [details]
sqlite-3.4.0.ebuild
Comment 2 Vladimir Brik 2007-07-16 19:04:07 UTC
Created attachment 125067 [details, diff]
patch to disable expression test 104
Comment 3 Vladimir Brik 2007-07-16 19:04:55 UTC
Created attachment 125069 [details, diff]
patch to disable types3-1.3 test
Comment 4 Vladimir Brik 2007-07-17 12:49:36 UTC
Created attachment 125153 [details, diff]
SIGFPE on 64-bit platforms fix 1/2
Comment 5 Vladimir Brik 2007-07-17 12:50:17 UTC
Created attachment 125155 [details, diff]
SIGFPE on 64-bit platforms fix 2/2
Comment 6 Vladimir Brik 2007-07-17 12:52:02 UTC
Created attachment 125156 [details, diff]
64-bit/tcl regression failure with types3-1.3 fix 1/2
Comment 7 Vladimir Brik 2007-07-17 12:52:28 UTC
Created attachment 125157 [details, diff]
64-bit/tcl regression failure with types3-1.3 fix 2/2
Comment 8 Vladimir Brik 2007-07-17 12:59:31 UTC
Created attachment 125158 [details]
sqlite-3.4.0.ebuild updated to use official patches for test case failures on 64 bit systems
Comment 9 Vladimir Brik 2007-07-17 13:04:02 UTC
added patches from sqlite.org to fix test cases that failed on 64 bit systems. Previously those test cases were just removed.

sqlite tickets:
Ticket 2465: 64-bit/tcl regression failure with types3-1.3
http://www.sqlite.org/cvstrac/tktview?tn=2465,39

Ticket 2507: test_expr expr-1.104 fails (64-bit int handling)
http://www.sqlite.org/cvstrac/tktview?tn=2507,35
Comment 10 Petteri Räty (RETIRED) gentoo-dev 2007-07-17 13:12:16 UTC
(In reply to comment #8)
> Created an attachment (id=125158) [edit]
> sqlite-3.4.0.ebuild updated to use official patches for test case failures on
> 64 bit systems
> 

Why did you remove copyright from the top?
Comment 11 Vladimir Brik 2007-07-17 16:36:09 UTC
Created attachment 125171 [details]
sqlite-3.4.0.ebuild with copyright header restored

(In reply to comment #10)
> Why did you remove copyright from the top?
> 
Is that a problem? 

The ebuild I attached is a bastardized version of sqlite-3.3.17.ebuild with different patches. I didn't know what the header what supposed to look like and just took off the whole top. I figured somebody else was going to edit the thing anyway.
Comment 12 Petteri Räty (RETIRED) gentoo-dev 2007-07-17 21:13:25 UTC
(In reply to comment #11)
> 
> The ebuild I attached is a bastardized version of sqlite-3.3.17.ebuild with
> different patches. I didn't know what the header what supposed to look like and
> just took off the whole top. I figured somebody else was going to edit the
> thing anyway.
> 

Well it's there to make sure that copyright goes to Gentoo Foundation as far I think but of course if your contributions are limited to a couple of lines it's not copyrightable in itself.
Comment 13 Vladimir Brik 2007-07-22 18:49:29 UTC
Created attachment 125695 [details]
sqlite-3.4.1.ebuild

New version of sqlite is out, most notably fixing another database corruption bug. Test suite's TLC issues on 64 bit platforms have been fixed as well and no longer require patching.
Comment 14 Petteri Räty (RETIRED) gentoo-dev 2007-07-24 15:13:07 UTC
(In reply to comment #13)
> Created an attachment (id=125695) [edit]
> sqlite-3.4.1.ebuild
> 
> New version of sqlite is out, most notably fixing another database corruption
> bug. Test suite's TLC issues on 64 bit platforms have been fixed as well and no
> longer require patching.
> 

Please attach diffs against current ebuilds in the future so it's easy to see what has changed. Thanks.
Comment 15 Petteri Räty (RETIRED) gentoo-dev 2007-07-24 15:24:50 UTC
Version bump committed. amd64: please verify the test suite to be working
Comment 16 Vladimir Brik 2007-08-15 17:47:06 UTC
(In reply to comment #15)
> Version bump committed. amd64: please verify the test suite to be working
> 

All tests are passed without errors.

Comment 17 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-19 01:11:00 UTC
====amd64====

I am having a testsuite problem....

Attaching build log....

Portage 2.1.2.12 (default-linux/amd64/2007.0, gcc-4.1.2, glibc-2.5-r4, 2.6.22-gentoo-r2 x86_64)
=================================================================
System uname: 2.6.22-gentoo-r2 x86_64 unknown
Gentoo Base System release 1.12.9
Timestamp of tree: Sat, 18 Aug 2007 11:20:01 +0000
ccache version 2.4 [enabled]
dev-lang/python:     2.4.4-r4
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.21
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/gconf /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-march=athlon64 -O2 -pipe"
DISTDIR="/distfiles"
FEATURES="ccache collision-protect distlocks metadata-transfer multilib-strict parallel-fetch sandbox sfperms strict test userpriv"
GENTOO_MIRRORS="http://mirrors.acm.cs.rpi.edu/gentoo/ http://distfiles.gentoo.org/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/overlay"
SYNC="rsync://192.168.1.30/gentoo-portage"
USE="X acl aiglx aim amd64 berkdb bitmap-fonts branding cli cracklib crypt cups dri fortran gdbm gpm gtk iconv imap ipv6 isdnlog midi mmx mpeg3 mudflap ncurses nls nptl nptlonly nvidia opengl openmp pam pcre perl pppd python qt3 readline reflection session sockets spl sqlite3 sse sse2 ssl tcpd test truetype-fonts type1-fonts unicode vim xcomposite xine xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 18 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-19 01:17:38 UTC
Created attachment 128504 [details]
Build+Failure log
Comment 19 Petteri Räty (RETIRED) gentoo-dev 2007-08-19 09:02:40 UTC
(In reply to comment #18)
> Created an attachment (id=128504) [edit]
> Build+Failure log
> 

USE="nothreadsafe" ?
Comment 20 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-19 11:31:05 UTC
(In reply to comment #19)
> (In reply to comment #18)
> > Created an attachment (id=128504) [edit]
> > Build+Failure log
> > 
> 
> USE="nothreadsafe" ?
> 
I redid the tests with that USE flag and all tests passed.
Comment 21 Petteri Räty (RETIRED) gentoo-dev 2007-08-19 12:14:46 UTC
(In reply to comment #20)
> > 
> I redid the tests with that USE flag and all tests passed.
> 

Well it should rather be the other way around :)
Comment 22 Sergey Dryabzhinsky 2007-08-25 09:04:08 UTC
Version 3.4.2 released. Bump?
Comment 23 Jakub Moc (RETIRED) gentoo-dev 2007-10-05 14:34:56 UTC
(In reply to comment #22)
> Version 3.4.2 released. Bump?

No, not here. This bug is about version bump, done, closing. Anything else -> new bug.