Bugzilla Bug 184984

From: Colin Percival <cperciva@freebsd.org>
To: Free Software Distribution Vendors <vendor-sec@lst.de>, Diego 'Flameeyes'
Pettenò <flameeyes@gmail.com>
Cc: Ludwig Nussel <ludwig.nussel@suse.de>, team@security.debian.org
Subject: security issues in libarchive
Date: Wed, 11 Jul 2007 10:14:49 -0700

Hi guys,

It seems that more linux vendors are distributing libarchive than I expected,
so I might as well send the details to vendor-sec rather than sending separate
emails to all the individual vendors contacting me.

I've attached FreeBSD's draft advisory and patch for libarchive 2.x; I also
have a patch for libarchive 1.x which is almost identical aside from cosmetic
changes due to API differences, but it sounds like most or all of you are
only shipping libarchive 2.x so I haven't attached that.

All versions of libarchive are affected by these issues, with the exception of
one which was introduced quite recently when a new readline() function was
added; if the final hunk of patch does not apply, you probably don't have that
recently added code+bug.

Tim Kientzle will be publishing an advisory for these issues on the libarchive
website and will release version 2.2.4 of libarchive with these issues fixed;
I don't know what the final URLs will be, but you should be able to find them
from http://people.freebsd.org/~kientzle/libarchive/ once this becomes public.

Please do not publish any advisories or mention this publicly until 15:00 UTC
on July 12th.

Thanks,
Colin Percival
FreeBSD Security Officer


=============================================================================
FreeBSD-SA-07:05.libarchive                                 Security Advisory
                                                          The FreeBSD Project

Topic:          Errors handling corrupt tar files in libarchive(3)

Category:       core
Module:         libarchive
Announced:      2007-07-12
Credits:        CPNI, CERT-FI, Tim Kientzle, Colin Percival
Affects:        FreeBSD 5.3 and later.
Corrected:      2007-07-12 15:XX:XX UTC (RELENG_6, 6.2-STABLE)
                2007-07-12 15:XX:XX UTC (RELENG_6_2, 6.2-RELEASE-p6)
                2007-07-12 15:XX:XX UTC (RELENG_6_1, 6.1-RELEASE-p18)
                2007-07-12 15:XX:XX UTC (RELENG_5, 5.5-STABLE)
                2007-07-12 15:XX:XX UTC (RELENG_5_5, 5.5-RELEASE-p14)
CVE Name:       CVE-2007-3641, CVE-2007-3644, CVE-2007-3645

For general information regarding FreeBSD Security Advisories,
including descriptions of the fields above, security branches, and the
following sections, please visit <URL:http://security.FreeBSD.org/>.

I.   Background

The libarchive library provides a flexible interface for reading and
writing streaming archive files such as tar and cpio, and has been the
basis for FreeBSD's implementation of the tar(1) utility since FreeBSD 5.3.

II.  Problem Description

Several problems have been found in the code used to parse the tar and 
pax interchange formats.  These include entering an infinite loop if an
archive prematurely ends within a pax extension header or if certain
types of corruption occur in pax extension headers [CVE-2007-3644];
dereferencing a NULL pointer if an archive prematurely ends within a
tar header immediately following a pax extension header or if certain
other types of corruption occur in pax extension headers [CVE-2007-3645];
and miscomputing the length of a buffer resulting in a buffer overflow
if yet another type of corruption occurs in a pax extension header
[CVE-2007-3641].

III. Impact

An attacker who can cause a corrupt archive of his choice to be parsed
by libarchive, including by having "tar -x" (extract) or "tar -t" (list
entries) run on it, can cause libarchive to enter an infinite loop, to
core dump, or possibly to execute arbitrary code provided by the 
attacker.

IV.  Workaround

No workaround is available, but systems which do not read tar or pax
extension archives provided by untrusted sources are not vulnerable.
Note that while these issues do not affect libarchive's ability to
parse cpio, ISO9660, or zip format archives, libarchive automatically
detects the format of an archive, so external metadata (e.g., a file
name) is not sufficient to ensure that a file will not be parsed using
the vulnerable tar/pax format parser.

V.   Solution

Perform one of the following:

1) Upgrade your vulnerable system to 5-STABLE, or 6-STABLE, or to the
RELENG_6_2, RELENG_6_1, or RELENG_5_5 security branch dated after the
correction date.

2) To patch your present system:

The following patches have been verified to apply to FreeBSD 5.5, 6.1,
and 6.2 systems.

a) Download the relevant patch from the location below, and verify the
detached PGP signature using your PGP utility.

[FreeBSD 5.5, 6.1, and 6.2]
# fetch http://security.FreeBSD.org/patches/SA-07:05/libarchive.patch
# fetch http://security.FreeBSD.org/patches/SA-07:05/libarchive.patch.asc

b) Execute the following commands as root:

# cd /usr/src
# patch < /path/to/patch
# cd /usr/src/lib/libarchive
# make obj && make depend && make && make install

VI.  Correction details

The following list contains the revision numbers of each file that was
corrected in FreeBSD.

Branch                                                           Revision
  Path
-------------------------------------------------------------------------
RELENG_5
  src/lib/libarchive/archive_read_support_format_tar.c           1.26.2.8
RELENG_5_5
  src/UPDATING                                            1.342.2.35.2.14
  src/sys/conf/newvers.sh                                  1.62.2.21.2.16
  src/lib/libarchive/archive_read_support_format_tar.c       1.26.2.7.2.1
RELENG_6
  src/lib/libarchive/archive_read_support_format_tar.c           1.32.2.5
RELENG_6_2
  src/UPDATING                                             1.416.2.29.2.9
  src/sys/conf/newvers.sh                                   1.69.2.13.2.9
  src/lib/libarchive/archive_read_support_format_tar.c       1.32.2.2.2.1
RELENG_6_1
  src/UPDATING                                            1.416.2.22.2.20
  src/sys/conf/newvers.sh                                  1.69.2.11.2.20
  src/lib/libarchive/archive_read_support_format_tar.c           1.32.6.1
-------------------------------------------------------------------------

VII. References

http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-3641
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-3644
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-3645

The latest revision of this advisory is available at
http://security.FreeBSD.org/advisories/FreeBSD-SA-07:05.libarchive.asc


---

I have the patches, what should I do? Prepare for secret release or?

yes, please provide some ebuilds and attach them here, dont commit yet (unless
this goes public faster than you are)

Created an attachment (id=124629) [details]
libarchive-6stable.patch

Patch (updated from the second mail, with Matt Dillon's fix).

Created an attachment (id=124630) [details]
bsdtar-2.2.3-r1.ebuild

*** Bug 185085 has been marked as a duplicate of this bug. ***

public

I suppose that at this point we could mark 2.2.4 stable and be done with it
(I'll add a 2.2.4-r1 to fix a bug, but that's not urgent).

amd64, please test and stable bsdtar-2.2.4 (or, even better, 2.2.4-r1 if it's
around when you stable)

(In reply to comment #7)
> amd64, please test and stable bsdtar-2.2.4 (or, even better, 2.2.4-r1 if it's
> around when you stable)
> 

done

The package was renamed today (to avoid publishing a glsa bound to be
invalidated by the move).

that was GLSA 200708-03, thanks everybody!