Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!
Not eligible to see or edit group visibility for this bug.
View Bug Activity | Format For Printing | XML | Clone This Bug
Most archive programs have a mode where they will accept a pre-prepared list of files to archive, either from stdin or from a command line argument which specifies a file (which can usually be stdin as well). lha is no exception, but someone #if 0'd the feature because of a problem with the MinGW library on Cygwin. Blech. The attached patch adds the appropriate autotools magic to automatically detect the MinGW compiler and disable the feature only in that environment. The attached ebuild has been modified to apply the patch and rerun the autotools to build a new configure. Also, I would appreciate some help from one of the Japanese-speaking developers to send this patch to upstream as the whole upstream site is in Japanese. - John
Created an attachment (id=124497) [details] New autotools magic to detect problematic environment.
Created an attachment (id=124499) [details] New ebuild.
This bug breaks app-backup//flexbackup's lha archive mode.
Created an attachment (id=124542) [details] Slightly cleaner new ebuild. Left in one spurious line of commented out code.
Created an attachment (id=124977) [details] Yet cleaner ebuild, with the help of the Gentoo Sunrise team. Cleanups based on guidance from the Gentoo Sunrise folks: Use autotools eclass, include RDEPEND="" for documentation, include a message on die for emake, use ${P} in patch file name. Not included or implemented in any way was the suggestion that renaming the ebuild from "lha-114i-r7" to "lha-1.14i-r7" would more closely match the upstream tarball and would allow MY_P to simplify from "${PN}-1.14i-ac20050924p1" to "${P}-ac20050924p1". I think this would cause "upgrade" issues because, according to the version comparison rules, "114i" > "1.14i".
Created an attachment (id=125637) [details] More cleanup of the the ebuild with the help of drac from Gentoo Sunrise. * Use fresh ebuild header from /usr/portage/header.txt. * Quote ${WORKDIR} properly. * Eliminate unnecessary doc file 00readme.autoconf from install. File is merely documentation of the configure script options and is mostly in Japanese anyway.
Fixed in -r7, thanks.
Going to leave this open so that, when usata comes back, he can (hopefully) forward it to upstream. (Upstream site is in Japanese.) - John
(In reply to comment #8) > Going to leave this open so that, when usata comes back, he can (hopefully) > forward it to upstream. (Upstream site is in Japanese.) He's retired, you'll have to do it yourself.
