Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 184545 - net-dialup/ppp does not install headers
Summary: net-dialup/ppp does not install headers
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-07 22:12 UTC by Robert Buchholz (RETIRED)
Modified: 2007-07-09 07:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Buchholz (RETIRED) gentoo-dev 2007-07-07 22:12:27 UTC
Currently, ppp does not install its header files (pppd.h and others).
These are needed by the pptp plugin of NetworkManager (not yet in portage).

From ppp-2.4.4/pppd/Makefile

HEADERS = ccp.h chap-new.h ecp.h fsm.h ipcp.h \
        ipxcp.h lcp.h magic.h md5.h patchlevel.h pathnames.h pppd.h \
        upap.h eap.h mplscp.h
...
install-devel:
        mkdir -p $(INCDIR)/pppd
        $(INSTALL) -c -m 644 $(HEADERS) $(INCDIR)/pppd
Comment 1 Alin Năstac (RETIRED) gentoo-dev 2007-07-08 07:18:29 UTC
Usually pppd dependent packages have all the necessary pppd header files included in their source tree and ebuild do nothing more than correcting the PPPD_VER (see net-dialup/pptpd).
What header files do you need?
Comment 2 Robert Buchholz (RETIRED) gentoo-dev 2007-07-08 13:35:09 UTC
The nm-pppt plugin ships with several versions of the ppp header files and allows to specify the version to use in ./configure. So it would work with the code from the ptpd ebuild. But it also allows to link to a given ppp include dir and figures out the version itself.

From a maintenance point of view, I don't understand why packages would want to do the first thing. This creates a lot of work when a new ppp version should come out, because I'd need to patch nm-pptp to contain the new headers.

As for your question, it needs fsm.h, ipcp.h, patchlevel.h and pppd.h. But if you decide to install the headers, why not all of them? Debian's ppp-devel ships with the whole list:
http://packages.debian.org/cgi-bin/search_contents.pl?searchmode=filelist&word=ppp-dev
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2007-07-09 07:16:48 UTC
Fixed in 2.4.4-r9 by running make install-devel in src_install().

I will ask arch teams to stabilize it.