Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 184432 - nvidia-drivers-100.14.* fix to install the menu item and icon for nvidia-settings
Summary: nvidia-drivers-100.14.* fix to install the menu item and icon for nvidia-sett...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: X11 External Driver Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-06 17:16 UTC by Robert Golding
Modified: 2007-07-12 14:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Golding 2007-07-06 17:16:49 UTC
When I first emerged the 100 series of nvidia-drivers (which include the nvidia-settings) the emerge didn't install the icon or desktop/menu files.

I patched the ebuild;
//
## usr/portage/x11-drivers/nvidia-drivers/nvidia-drivers-100.14.11.ebuild patch

@@ -286,6 +286,6 @@

	# Install icon and .desktop entry
-	doicon "${FILESDIR}/nvidia-settings.png" || die "doicon"
-	domenu "${FILESDIR}/nvidia-settings.desktop" || die "domenu"
+	doicon "${FILESDIR}/icon/nvidia-settings.png" || die "doicon"
+	domenu "${FILESDIR}/icon/nvidia-settings.desktop" || die "domenu"

	doman doc/nvidia-settings.1 || die
// 
and copied the 'files/icon' dir from media-video/nvidia-settings to x11-drivers/nvidia-drivers.


Reproducible: Always

Steps to Reproduce:
1. patch nvidia-drivers-100.* as per above
2. cp -pR /usr/portage/media-video/nvidia-settings/files/icon /usr/portage/x11-drivers/nvidia-drivers/files/
3. ebuild /usr/portage/x11-drivers/nvidia-drivers/nvidia-drivers-100.14.11.ebuild digest
4. emerge nvidia-drivers

Actual Results:  
Now have the menu item for 'NVIDIA X Server Settings' with icon

Expected Results:  
nvidia-settings to be added to menu with icon

I hand edited the ebuild for the patch as I am not comfortable with making diff/patch files.

This has worked with both 100.14.09 and 100.14.11.
Comment 1 Paul Bredbury 2007-07-06 18:15:24 UTC
The Gentoo devs forgot to populate /usr/portage/x11-drivers/nvidia-drivers/files/ with nvidia-settings.{png,desktop}

doicon and domenu in /usr/portage/eclass/eutils.eclass are far too fault-tolerant, meaning that the "|| die" sanity protections in the ebuild are useless.

The BASH code should *not* be skipping over these errors.
Comment 2 Doug Goldstein (RETIRED) gentoo-dev 2007-07-06 18:28:16 UTC
yeah trapni committed these ebuilds without all the necessary files.
Comment 3 Robert Golding 2007-07-07 03:37:19 UTC
(In reply to comment #2)
> yeah trapni committed these ebuilds without all the necessary files.
> 

I just retried the fix by only copying the two files (nvidia-settings.{png,desktop} to x11-drivers/nvidia-drivers/files and didn't patch the ebuild, just did a digest. Worked well.

Can the dev please populate the files dir as noted above?
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2007-07-07 15:09:27 UTC
it's a masked ebuild that's under development. minor issue in the grand scheme of things. it will be fixed shortly.
Comment 5 Paul Bredbury 2007-07-07 15:17:13 UTC
> it's a masked ebuild that's under development. minor issue in the grand scheme
> of things. it will be fixed shortly.

Stop being so damned mysterious. State what you're up to, and you might actually get some *help*.

Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2007-07-07 16:46:38 UTC
I apologize. We were debating some security issues as well as a new approach to the nvidia-drivers. Also I've been completely slammed outside of Gentoo (moving, buying furniture,etc)

I wanted to just commit everything at once completely done but you're right. I need to work with everyone a bit. I'm committing a snapshot ebuild that fixes a couple of bugs. I know this ebuild works since I've tested it and I'm using it. More changes will come but I haven't tested those too well.
Comment 7 burzmali 2007-07-12 06:21:25 UTC
Can we have building nvidia-settings be optional?
Comment 8 Ed Catmur 2007-07-12 12:05:29 UTC
(In reply to comment #7)
> Can we have building nvidia-settings be optional?
Bug 182622.  Please saerch before spamming unrelated bugs.
Comment 9 Doug Goldstein (RETIRED) gentoo-dev 2007-07-12 14:13:02 UTC
This was fixed.