Bugzilla Bug 183442

In file included from /usr/include/dbus-1.0/dbus/dbus-glib.h:137,
                 from manager.c:46:
/usr/include/dbus-1.0/dbus/dbus-gtype-specialized.h:169: warning: redundant
redeclaration of ‘dbus_g_type_map_peek_vtable’
/usr/include/dbus-1.0/dbus/dbus-gtype-specialized.h:162: warning: previous
declaration of ‘dbus_g_type_map_peek_vtable’ was here
/usr/include/dbus-1.0/dbus/dbus-gtype-specialized.h:170: warning: redundant
redeclaration of ‘dbus_g_type_collection_peek_vtable’
/usr/include/dbus-1.0/dbus/dbus-gtype-specialized.h:163: warning: previous
declaration of ‘dbus_g_type_collection_peek_vtable’ was here
manager.c: In function ‘gvm_local_user’:
manager.c:3214: warning: assignment makes pointer from integer without a cast
manager.c:3215: error: ‘struct utmp’ has no member named ‘ut_type’
manager.c:3215: error: ‘USER_PROCESS’ undeclared (first use in this
function)
manager.c:3215: error: (Each undeclared identifier is reported only once
manager.c:3215: error: for each function it appears in.)
manager.c:3215: error: ‘struct utmp’ has no member named ‘ut_user’
gmake[2]: *** [manager.o] Error 1
gmake[2]: Leaving directory
`/var/tmp/portage/gnome-base/gnome-volume-manager-2.17.0/work/gnome-volume-manager-2.17.0/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory
`/var/tmp/portage/gnome-base/gnome-volume-manager-2.17.0/work/gnome-volume-manager-2.17.0'
gmake: *** [all] Error 2

Created an attachment (id=123235) [edit]
Patch from FreeBSD Ports tree

Also tested on Linux :)

Why the locale changes?  The rest of it looks protected to only change on
freebsd, but the locale changes are global, and add "new" functionality.  I'm
reluctant to apply global changes without upstream's approval, since I don't
know exactly what they do.

Does it work without that part on freebsd?  Can we apply just the minimal
changes to get it to work on freebsd for now, and wait for upstream on the
rest?

(In reply to comment #2)
> Why the locale changes?

locale options are part of file systems, not FreeBSD itself. You would need
them to mount FreeBSD partitions in Linux I think.
Note that some options like nodiratime only apply to specific file systems like
XFS.

> The rest of it looks protected to only change on
> freebsd, but the locale changes are global, and add "new" functionality.  I'm
> reluctant to apply global changes without upstream's approval, since I don't
> know exactly what they do.
> 
> Does it work without that part on freebsd? 

No, but if it matters that much we could #ifdef around it.

Okay, if it's necessary, I'll apply and test.

Done.  Thanks, uber.