Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 183344 - Ebuild cleanups for games-rpg/nwn and games-rpg/nwn-data
Summary: Ebuild cleanups for games-rpg/nwn and games-rpg/nwn-data
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-26 23:32 UTC by Ian Leonard
Modified: 2007-09-04 20:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Add Gold CD support to nwn-data-1.29-r1.ebuild (nwn-data-1.29-r1-gold-support.patch,3.27 KB, patch)
2007-06-26 23:33 UTC, Ian Leonard
Details | Diff
Change packages nwn-data-1.29-r1.ebuild depends on (nwn-data-1.29-r1-change-depends.patch,676 bytes, patch)
2007-06-26 23:35 UTC, Ian Leonard
Details | Diff
Cleanup packages downloaded by nwn-1.68-r1.ebuild (nwn-1.68-r1-cleanup-src-uri.patch,2.70 KB, patch)
2007-06-26 23:36 UTC, Ian Leonard
Details | Diff
Second cleanup packages downloaded by nwn (nwn-1.68-r1-cleanup-src-uri-try2.patch,2.33 KB, patch)
2007-06-30 08:42 UTC, Ian Leonard
Details | Diff
Second add gold support to nwn-data-1.29-r1 (nwn-data-1.29-r1-gold-support-rnd2.patch,4.13 KB, patch)
2007-07-01 02:50 UTC, Ian Leonard
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Leonard 2007-06-26 23:32:07 UTC
With Summer, I've been able to finish putting together some cleanups for the Neverwinter Nights ebuilds.  

Changes:

1. Add support for the Gold CD set to nwn-data. Takes care of bug #61990
2. Add USE variable 'bioware-cabinets' to control dependencies of unshield and biounzip in nwn-data.  I did this because the Gold CD set uses only .zip's. I wasn't aware of a pre-existing USE variable for controlling this.
3. Cleanup the choice of which linux client to download by nwn. Currently, it's downloading the original, sou, and hou client without caring which one it will actually use.  The change saves 240MB-260MB (more for localized versions) from downloading. It also removes the separate download of dialog.zip.  I don't know the history of this requirement, but the dialog.tlk within is md5 equivalent to the dialog.tlk within the English and Spanish linux client tarballs (assuming same for the rest).

Reproducible: Always
Comment 1 Ian Leonard 2007-06-26 23:33:07 UTC
Created attachment 123163 [details, diff]
Add Gold CD support to nwn-data-1.29-r1.ebuild
Comment 2 Ian Leonard 2007-06-26 23:35:05 UTC
Created attachment 123165 [details, diff]
Change packages nwn-data-1.29-r1.ebuild depends on
Comment 3 Ian Leonard 2007-06-26 23:36:22 UTC
Created attachment 123167 [details, diff]
Cleanup packages downloaded by nwn-1.68-r1.ebuild
Comment 4 Ian Leonard 2007-06-30 08:42:09 UTC
Created attachment 123451 [details, diff]
Second cleanup packages downloaded by nwn

Original patch breaks SoU for SoU & HoU users.  I did not expect module data to be hiding within a client tarball.  I'm going to look into this further, but didn't want someone wasting time looking into a patch I knew to be broken.
Comment 5 Ian Leonard 2007-07-01 02:50:06 UTC
Created attachment 123494 [details, diff]
Second add gold support to nwn-data-1.29-r1

Looking further, nwn-data removes the contents of the nwm folder which contains the official modules.  This makes the two client tarballs necessary for a SoU & HoU user.  I don't understand the reasoning behind the cleaning of nwm, and don't see a point in making further changes to nwn-data to support only one client tarball until knowing.

Attached: A hopefully finished gold support patch for nwn-data.  Changes from the original are to correctly follow Bioware's unzip order (disk 1 should be last).
Comment 6 CL Chong 2007-08-17 10:03:59 UTC
(In reply to comment #4)
> Created an attachment (id=123451) [edit]
> Second cleanup packages downloaded by nwn
> 
> Original patch breaks SoU for SoU & HoU users.  I did not expect module data to
> be hiding within a client tarball.  I'm going to look into this further, but
> didn't want someone wasting time looking into a patch I knew to be broken.
> 
usage of the changed ebuild result in the following errors

>>> Unpacking source...
/usr/local/portage/games-rpg/nwn/nwn-1.68-r1.ebuild: line 207: cd: en: No such file or directory
>>> Unpacking English_linuxclient168_xp1.tar.gz to /var/tmp/portage/games-rpg/nwn-1.68-r1/work/nwn
/usr/local/portage/games-rpg/nwn/nwn-1.68-r1.ebuild: line 238: cd: en: No such file or directory

Comment 7 Dominik Kozaczko 2007-08-17 14:19:43 UTC
I don't want to file new bugreport so I write here:

nwn-data does not support Polish edition of SoU & HoU released by CDProjekt (http://www.cdprojekt.info/). Both expansions were recently released on one DVD. Installer (nwn-data-1.68-r1) says it found Original/Gold edition and installs 3 original disks fine but then it crashes on SoU/HoU with:

"unzip:  cannot find or open /media/dvdrw/Data_Shared.zip, /media/dvdrw/Data_Shared.zip.zip or /media/dvdrw/Data_Shared.zip.ZIP."

Directory structure of the DVD:

minder@logrus /media/dvdrw $ find .
.
./DirectX
./DirectX/Apr2005_d3dx9_25_x64.cab
./DirectX/Apr2005_d3dx9_25_x86.cab
./DirectX/Apr2006_MDX1_x86.cab
./DirectX/Apr2006_MDX1_x86_Archive.cab
./DirectX/Apr2006_XACT_x64.cab
./DirectX/Apr2006_XACT_x86.cab
./DirectX/Apr2006_d3dx9_30_x64.cab
./DirectX/Apr2006_d3dx9_30_x86.cab
./DirectX/Apr2006_xinput_x64.cab
./DirectX/Apr2006_xinput_x86.cab
./DirectX/Aug2005_d3dx9_27_x64.cab
./DirectX/Aug2005_d3dx9_27_x86.cab
./DirectX/Aug2006_XACT_x64.cab
./DirectX/Aug2006_XACT_x86.cab
./DirectX/Aug2006_xinput_x64.cab
./DirectX/Aug2006_xinput_x86.cab
./DirectX/BDA.cab
./DirectX/BDANT.cab
./DirectX/BDAXP.cab
./DirectX/DSETUP.dll
./DirectX/DXSETUP.exe
./DirectX/Dec2005_d3dx9_28_x64.cab
./DirectX/Dec2005_d3dx9_28_x86.cab
./DirectX/DirectX.cab
./DirectX/Feb2005_d3dx9_24_x64.cab
./DirectX/Feb2005_d3dx9_24_x86.cab
./DirectX/Feb2006_XACT_x64.cab
./DirectX/Feb2006_XACT_x86.cab
./DirectX/Feb2006_d3dx9_29_x64.cab
./DirectX/Feb2006_d3dx9_29_x86.cab
./DirectX/JUN2006_XACT_x64.cab
./DirectX/JUN2006_XACT_x86.cab
./DirectX/Jun2005_d3dx9_26_x64.cab
./DirectX/Jun2005_d3dx9_26_x86.cab
./DirectX/Oct2005_xinput_x64.cab
./DirectX/Oct2005_xinput_x86.cab
./DirectX/dsetup32.dll
./DirectX/dxdllreg_x86.cab
./DirectX/dxnt.cab
./DirectX/dxupdate.cab
./ISSetup.dll
./Instrukcja
./Instrukcja/Acrobat Reader
./Instrukcja/Acrobat Reader/AdbeRdr60_pol.exe
./Instrukcja/Acrobat Reader/AdbeRdr70_pol_full.exe
./Instrukcja/Instrukcja Hordes of the Underdark.pdf
./Instrukcja/Instrukcja Shadows of Undrentide.pdf
./Instrukcja/KartaPomocy.pdf
./Instrukcja/Poradnik Neverwinter Nights - Hordes of the Underdark.pdf
./Instrukcja/Poradnik Neverwinter Nights - Shadows of Undrentide.pdf
./_Setup.dll
./autorun.exe
./autorun.inf
./data
./data/background.bmp
./data/button1_down.bmp
./data/button1_over.bmp
./data/button2_down.bmp
./data/button2_over.bmp
./data/mus_autorun.wav
./data/mus_autorun2.wav
./data1.cab
./data1.hdr
./data2.cab
./data3.cab
./data4.cab
./data5.cab
./data6.cab
./layout.bin
./nwn.ico
./setup.bmp
./setup.exe
./setup.ini
./setup.inx


I have no experience with ebuilds, but I will try to fix this. If anyone gets an idea, please post.
Comment 8 Dominik Kozaczko 2007-08-17 14:21:19 UTC
Sorry, I mean nwn-data-1.29-r1.
Comment 9 Dominik Kozaczko 2007-08-17 14:34:58 UTC
Additional info: I tried exporting only 4 CD_ROOT_# variables but this does not help. I can't copy all disks to one directory and then export CD_ROOT because data1.cab and data1.hdr files would be overwritten.

Also, I have problem installing clean NWN, without the expansion packs:

>>> Emerging (1 of 1) games-rpg/nwn-1.68-r1 to /
>>> Downloading 'http://nwdownloads.bioware.com/neverwinternights/patch/dialog/english/NWNEnglish1.68dialog.zip'
--16:30:43--  http://nwdownloads.bioware.com/neverwinternights/patch/dialog/english/NWNEnglish1.68dialog.zip
           => `/usr/portage/distfiles/NWNEnglish1.68dialog.zip'
Translacja nwdownloads.bioware.com... 204.50.199.10
Connecting to nwdownloads.bioware.com|204.50.199.10|:80... połączono.
Żądanie HTTP wysłano, oczekiwanie na odpowiedź... 404 Not Found
16:30:44 BŁĄD 404: Not Found.

!!! Couldn't download 'NWNEnglish1.68dialog.zip'. Aborting.
Comment 10 Dominik Kozaczko 2007-08-17 16:45:38 UTC
I tried to make an ebuild for Polish edition of SoU+HoU but unshield and cabextract are unable to handle data files:

# cabextract /media/dvdrw/data1.cab 
/media/dvdrw/data1.cab: WARNING; found InstallShield header. This is probably an InstallShield file. Use UNSHIELD (http://synce.sf.net) to unpack it.
/media/dvdrw/data1.cab: no valid cabinets found

All done, errors in processing 1 file(s)

# unshield -D 3 x /media/dvdrw/data1.cab 
[unshield_read_headers:226] Reading header from .hdr file 1.
[unshield_read_headers:281] Version 0x020004b0 handled as major version 0
[unshield_get_cab_descriptor:81] Cabinet descriptor: 0000256c 00009c80 00009c80 00000044
[unshield_get_cab_descriptor:83] Directory count: 17
[unshield_get_cab_descriptor:84] File count: 387
Przerwane

"Przewane" is Polish for "Aborted". This was done in /tmp directory as root, so it's not read/write error.
Comment 11 Chris Gianelloni (RETIRED) gentoo-dev 2007-08-18 01:13:26 UTC
Please file a new bug for your Polish support/problems.  It doesn't belong here.

As for the reasoning behind cleaning nwm, it is so we can support all of the various media sets out there without issues.
Comment 12 Denis Dupeyron (RETIRED) gentoo-dev 2007-09-04 20:14:32 UTC
(In reply to comment #6)
> usage of the changed ebuild result in the following errors
> 
> >>> Unpacking source...
> /usr/local/portage/games-rpg/nwn/nwn-1.68-r1.ebuild: line 207: cd: en: No such
> file or directory
> >>> Unpacking English_linuxclient168_xp1.tar.gz to /var/tmp/portage/games-rpg/nwn-1.68-r1/work/nwn
> /usr/local/portage/games-rpg/nwn/nwn-1.68-r1.ebuild: line 238: cd: en: No such
> file or directory

This is now fixed. Thanks for reporting it.

Denis.