Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 182957
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Matthias Schwarzott <zzam@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 182957 depends on: Show dependency tree
Bug 182957 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-06-23 08:28 0000
As the description says, I think it is better to let sys-fs/device-mapper
itself install the related udev rules file
/etc/udev/rules.d/64-device-mapper.rules. This ways the rules also can use the
new parameters dedicated for udev interfacing Kay added to device-mapper
without even more ugly version checks inside udev ebuild.

The move can be protected by blockers if necessary.
A. All older udev ebuilds blocking new added device-mapper ebuild.
B. New device-mapper ebuild blocking older udev ebuilds.

------- Comment #1 From Matthias Schwarzott 2007-06-26 16:36:13 0000 -------
According to jakub we don't need blockers for CONFIG_PROTECTED files.
That means just adding the file to device-mapper will work.

@robbat2: Is it ok, that I just bump device-mapper to 1.02.19-r1 and add that
file?
And then either immediately, or some weeks later remove it from udev-ebuild.

------- Comment #2 From Robin Johnson 2007-06-26 23:13:40 0000 -------
zzam: Ok with me if you just add it via a bump.
Related question, how can we get it cleaned up for users that don't use
device-mapper (since udev won't add any new version, but the old one will
remain).

------- Comment #3 From Matthias Schwarzott 2007-06-27 09:43:08 0000 -------
I suggest adding this to udev's pkg_postinst:
    # 64-device-mapper.rules now gets installed by sys-fs/device-mapper
    # remove it if user don't has sys-fs/device-mapper installed
    if has_version "<sys-fs/udev-113" &&
        [[ -f "${ROOT}"/etc/udev/rules.d/64-device-mapper.rules ]] &&
        ! has_version sys-fs/device-mapper
    then
            rm -f "${ROOT}"/etc/udev/rules.d/64-device-mapper.rules
            einfo "Removed unneeded file 64-device-mapper.rules"
    fi


And to catch the ugly case of emergeing device-mapper. Then udev-112-r1, and
then udev-113 I suggest to add this to pkg_preinst of udev to change mtime of
file, and portage will not remove it:

    if has_version "<sys-fs/udev-113" &&
        [[ -f "${ROOT}"/etc/udev/rules.d/64-device-mapper.rules ]] &&
        has_version sys-fs/device-mapper
    then
        # change mtime to definitely keep the file
        touch "${ROOT}"/etc/udev/rules.d/64-device-mapper.rules
    fi

------- Comment #4 From Matthias Schwarzott 2007-06-27 09:59:50 0000 -------
Commited sys-fs/device-mapper-1.02.19-r1 and sys-fs/udev-113.

Move done!

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug