Bugzilla Bug 182616

I miss some really often used options in genkernel.conf. I have to set makeopts
and kernel-cc every time I use genkernel. Would it be possible, to make some
more options, especially this, available through e.g. MAKEOPTS="-j6" and
KERNEL-CC="distcc". Like it is handled in make.conf?

Reproducible: Always

Steps to Reproduce:



Expected Results:  
Every option is available through it's upper case pendant in genkernel.conf and
is overwritten by the command-line option.

Absolutely.  I would love for all genkernel options to be configurable within
the genkernel.conf file.  After all, it doesn't make sense to not have
configuration in the configuration file, right?

As far as your expected results, they're spot on.  I want genkernel.conf to be
able to control all aspects of the build, yet still be capable of being
overwritten on the command line.

Would you be willing to help add this sort of thing to genkernel?  Don't worry,
you wouldn't be on your own for it.  You would have help.  This was actually
one of my milestones that I would like to see implemented for genkernel 3.5,
which will be the next important update.

Hi Chris,

sure I'm willing to help. If there is time for it beside dealing with gentoo on
some floating-point unit-less PowerPC, I will do. Planning this to do for the
next 2 weeks.

greets

Created an attachment (id=132877) [edit]
Patch against genkernel-3.4.9_pre3 that implements complete config file
defaulting of all command line options.

Chris,

I couldn't resist.  I've implemented the request, refactoring the argument
processing code to more naturally support configuration file overriding and
architecture defaults.  Let me know if you think I'm on the right track.

- John 

I should add that this change is rather sweeping and, although I've done a fair
amount of testing, it needs more.  Also, I would like to improve the internal
comments documenting the code in determine_real_args() that creates intelligent
interaction between different command line arguments (e.g., --no-clean implies
--no-mrproper).

- John

OK.  I've updated this in SVN.  For any further enhancements, let's file a new
bug.

Created an attachment (id=135452) [edit]
Patch as applied to genkernel SVN

Here's the patch that I ended up applying.  I'm putting it here for you to
check out and also so I have it somewhere in case I need to back this out.  As
such, I'm rolling a genkernel 3.4.9_pre8 with this patch in it so we can test
genkernel without introducing a bunch more changes.

This is in 3.4.9_pre8 and we'll be testing it shortly.

To echo kumba, you rock!  Testing now.

Thanks, Chris.

Created an attachment (id=135544) [edit]
Patch adds --mdadm to the configuration infrastructure.

Chris, forgive me if I'm doing this wrong, but since this was a correction
specifically on this topic and not a *new* enhancement, it appeared appropriate
to add it to this bug.

Between 3.4.9_pre3, on which I based my config default enhancements, and
3.4.9_pre8, a new command line option (--mdadm) was introduced which was not
covered by the new mechanism.  This patch, which is against 3.4.9_pre8, adds
that command line option to the config default mechanism.

- John

(From update of attachment 135544 [edit])
Change of heart.  Created new bug per Chris Gianelloni's wishes.  See
bug#198694.