Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 182616 - Extend genkernel.conf options
Summary: Extend genkernel.conf options
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2007-06-19 22:41 UTC by Daniel Glaser
Modified: 2007-11-10 15:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against genkernel-3.4.9_pre3 that implements complete config file defaulting of all command line options. (genkernel-3.4.9_pre3-with-conf-defaults-r1.patch,35.50 KB, patch)
2007-10-08 02:19 UTC, John R. Graham
Details | Diff
Patch as applied to genkernel SVN (patch,34.29 KB, patch)
2007-11-07 21:37 UTC, Chris Gianelloni (RETIRED)
Details | Diff
Patch adds --mdadm to the configuration infrastructure. (genkernel-3.4.9_pre8-mdadm.patch,1.28 KB, patch)
2007-11-09 04:55 UTC, John R. Graham
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Glaser 2007-06-19 22:41:58 UTC
I miss some really often used options in genkernel.conf. I have to set makeopts and kernel-cc every time I use genkernel. Would it be possible, to make some more options, especially this, available through e.g. MAKEOPTS="-j6" and KERNEL-CC="distcc". Like it is handled in make.conf?

Reproducible: Always

Steps to Reproduce:



Expected Results:  
Every option is available through it's upper case pendant in genkernel.conf and is overwritten by the command-line option.
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2007-06-23 13:44:07 UTC
Absolutely.  I would love for all genkernel options to be configurable within the genkernel.conf file.  After all, it doesn't make sense to not have configuration in the configuration file, right?

As far as your expected results, they're spot on.  I want genkernel.conf to be able to control all aspects of the build, yet still be capable of being overwritten on the command line.

Would you be willing to help add this sort of thing to genkernel?  Don't worry, you wouldn't be on your own for it.  You would have help.  This was actually one of my milestones that I would like to see implemented for genkernel 3.5, which will be the next important update.
Comment 2 Daniel Glaser 2007-06-25 00:45:18 UTC
Hi Chris,

sure I'm willing to help. If there is time for it beside dealing with gentoo on some floating-point unit-less PowerPC, I will do. Planning this to do for the next 2 weeks.

greets
Comment 3 John R. Graham gentoo-dev 2007-10-08 02:19:04 UTC
Created attachment 132877 [details, diff]
Patch against genkernel-3.4.9_pre3 that implements complete config file defaulting of all command line options.

Chris,

I couldn't resist.  I've implemented the request, refactoring the argument processing code to more naturally support configuration file overriding and architecture defaults.  Let me know if you think I'm on the right track.

- John
Comment 4 John R. Graham gentoo-dev 2007-10-08 02:32:02 UTC
I should add that this change is rather sweeping and, although I've done a fair amount of testing, it needs more.  Also, I would like to improve the internal comments documenting the code in determine_real_args() that creates intelligent interaction between different command line arguments (e.g., --no-clean implies --no-mrproper).

- John
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2007-11-07 21:35:49 UTC
OK.  I've updated this in SVN.  For any further enhancements, let's file a new bug.
Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2007-11-07 21:37:34 UTC
Created attachment 135452 [details, diff]
Patch as applied to genkernel SVN

Here's the patch that I ended up applying.  I'm putting it here for you to check out and also so I have it somewhere in case I need to back this out.  As such, I'm rolling a genkernel 3.4.9_pre8 with this patch in it so we can test genkernel without introducing a bunch more changes.
Comment 7 Chris Gianelloni (RETIRED) gentoo-dev 2007-11-07 21:58:19 UTC
This is in 3.4.9_pre8 and we'll be testing it shortly.
Comment 8 John R. Graham gentoo-dev 2007-11-09 04:02:34 UTC
To echo kumba, you rock!  Testing now.

Thanks, Chris.
Comment 9 John R. Graham gentoo-dev 2007-11-09 04:55:05 UTC
Created attachment 135544 [details, diff]
Patch adds --mdadm to the configuration infrastructure.

Chris, forgive me if I'm doing this wrong, but since this was a correction specifically on this topic and not a *new* enhancement, it appeared appropriate to add it to this bug.

Between 3.4.9_pre3, on which I based my config default enhancements, and 3.4.9_pre8, a new command line option (--mdadm) was introduced which was not covered by the new mechanism.  This patch, which is against 3.4.9_pre8, adds that command line option to the config default mechanism.

- John
Comment 10 John R. Graham gentoo-dev 2007-11-10 15:04:57 UTC
Comment on attachment 135544 [details, diff]
Patch adds --mdadm to the configuration infrastructure.

Change of heart.  Created new bug per Chris Gianelloni's wishes.  See bug#198694.