Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 182528 - games-fps/alephone bump request w/ebuild
Summary: games-fps/alephone bump request w/ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-19 01:12 UTC by trefoil
Modified: 2007-08-31 16:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
alephone-20070525-configure.patch (alephone-20070525-configure.patch,915 bytes, patch)
2007-06-19 01:13 UTC, trefoil
Details | Diff
alephone-20070525.ebuild (alephone-20070525.ebuild,1.92 KB, text/plain)
2007-06-20 18:37 UTC, trefoil
Details
alephone-20070525-configure.patch (alephone-20070525-configure.patch,1.44 KB, patch)
2007-06-20 18:38 UTC, trefoil
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description trefoil 2007-06-19 01:12:54 UTC
Hello, here's a diff of the ebuild that's working well for me, and next is a revised patch for configure.ac. I've tested with and without all the use flags, on x86. I think smpeg should probably be a useflag, but didn't want to change it too much. Lua is packaged with alephone now.

--- /usr/portage/games-fps/alephone/alephone-20061228.ebuild    2007-02-14 11:35:49.000000000 -0500
+++ alephone-20070525.ebuild    2007-06-18 21:00:19.000000000 -0400
@@ -11,13 +11,15 @@
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="amd64 x86"
-IUSE="lua opengl speex"
+IUSE="lua opengl speex mad vorbis sndfile"
 
-DEPEND="lua? ( dev-lang/lua )
-       opengl? ( virtual/opengl )
+DEPEND="opengl? ( virtual/opengl )
        speex? ( media-libs/speex )
+       mad? ( media-libs/libmad )
+       !mad? ( media-libs/smpeg )
+       vorbis? ( media-libs/libvorbis )
+       sndfile? ( media-libs/libsndfile )
        dev-libs/boost
-       media-libs/smpeg
        media-libs/libsdl
        media-libs/sdl-image
        media-libs/sdl-sound
@@ -38,8 +40,11 @@
 src_compile() {
        egamesconf \
                --disable-dependency-tracking \
-               $(use_enable lua) \
                $(use_enable opengl) \
+               $(use_enable mad) \
+               $(use_enable vorbis) \
+               $(use_enable sndfile) \
+               $(use_enable lua) \
                $(use_enable speex) \
                || die
        emake || die "emake failed"




Reproducible: Always

Steps to Reproduce:
Comment 1 trefoil 2007-06-19 01:13:57 UTC
Created attachment 122498 [details, diff]
alephone-20070525-configure.patch

This is simply the previous patch with the Lua bits removed.
Comment 2 trefoil 2007-06-19 01:19:00 UTC
Yeah, smpeg gets linked in if it's installed, libmad or no. Should it get fixed in the configure patch, same as speex?
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2007-06-20 09:29:30 UTC
Yeah.
Comment 4 trefoil 2007-06-20 18:37:12 UTC
Created attachment 122630 [details]
alephone-20070525.ebuild

Sorry, I know next to nothing about autotools or configure, this is a bit beyond me.

But from what I can tell, there are bad 'automagic' dependencies on Speex, smpeg, ALSA, and sdl-image (not a hard dep after all?). What I don't understand is the line "+CPPFLAGS="$CPPFLAGS -I/usr/include/speex", and if it's required for the other deps. I'm attaching my last ebuild with an smpeg fix, but as far as fixing ALSA and sdl-image, if that's desired, I'd prefer someone with more experience take a look at it.

I did test both with and without smpeg on x86, and it works fine.
Comment 5 trefoil 2007-06-20 18:38:37 UTC
Created attachment 122631 [details, diff]
alephone-20070525-configure.patch
Comment 6 trefoil 2007-06-20 18:41:20 UTC
Lastly, it seems sdl-sound is no longer a dependency. :b
Comment 7 trefoil 2007-07-11 18:59:08 UTC
To reiterate, these are the differing dependencies:

-lua (now built in)
-sdl-sound
+libmad
+libvorbis
+libsndfile

And these are the automagic dependencies which need fixing AFAICT:

speex
smpeg
alsa
sdl-image

That's it. This version is still working well for me on x86.
Comment 8 Tupone Alfredo gentoo-dev 2007-08-31 16:11:05 UTC
Version 0.18.1 (20070819) is now in portage.
Thanks for report and work on ebuild