Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 182168 - dev-util/subversion-1.4.4: Mistake in `append-flags` line + Suggestion of dropping support of apr-util:0
Summary: dev-util/subversion-1.4.4: Mistake in `append-flags` line + Suggestion of dro...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Paul de Vrieze (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-15 19:21 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2007-06-17 17:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2007-06-15 19:21:09 UTC
There is line:
append-flags `/usr/bin/apr-config${apr_suffix} --cppflags`

It should be changed to:
append-flags `/usr/bin/apr${apr_suffix}-config --cppflags`
Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2007-06-15 19:45:34 UTC
I have also small suggestion. Stable subversion-1.3.2-r4 depends on >=dev-libs/apr-util-1.2.8, so dev-util/subversion-1.4.4 can have similar dependency. There's no need of supporting old apr{,-util}:0.

--- subversion-1.4.4.ebuild
+++ subversion-1.4.4.ebuild
@@ -15,7 +15,7 @@
 RESTRICT="test"

 COMMONDEPEND="apache2? ( ${APACHE2_DEPEND} )
-       !apache2? ( >=dev-libs/apr-util-0.9.7 )
+       !apache2? ( >=dev-libs/apr-util-1.2.8 )
        python? ( >=dev-lang/python-2.0 )
        perl? ( >=dev-lang/perl-5.8.6-r6
                !=dev-lang/perl-5.8.7 )
@@ -86,9 +86,7 @@
                        apr_suffix="-1"
                fi
        else
-               if has_version ">dev-libs/apr-util-1"; then
-                       apr_suffix="-1"
-               fi
+               apr_suffix="-1"
                myconf="--without-apxs"
        fi
Comment 2 Christian Heim (RETIRED) gentoo-dev 2007-06-17 16:40:46 UTC
(In reply to comment #0)
> There is line:
> append-flags `/usr/bin/apr-config${apr_suffix} --cppflags`
> 
> It should be changed to:
> append-flags `/usr/bin/apr${apr_suffix}-config --cppflags`

That's right, and I just committed a fix ebuild to the tree.

Wrt #c2, I can't do that yet. Otherwise we would completely break apache-2 (as only apache-2.0.58-r2 is marked stable, not 2.2.4*). Besides, subversion will automatically pick up apr-1.2.8 if it is stable on your architecture.
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2007-06-17 17:04:11 UTC
(In reply to comment #2)
> Wrt #c2, I can't do that yet. Otherwise we would completely break apache-2
> (as only apache-2.0.58-r2 is marked stable, not 2.2.4*).

But Subversion 1.4.* isn't marked stable and Apache 2.2.* will be probably stabilised before Subversion 1.4.*.

> Besides, subversion will automatically pick up apr-1.2.8 if it is stable on
> your architecture.
I have ACCEPT_KEYWORDS="x86 ~x86" from always :) .