Bugzilla Bug 181822

last round of checks before unmasking flac 1.1.4 :


/bin/sh ../../libtool --tag=CXX   --mode=compile x86_64-pc-linux-gnu-g++
-DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../alsaplayer   -D_REENTRANT
-march=athlon64 -O2 -pipe  -march=athlon64 -O2 -pipe -c -o FlacStream.lo
FlacStream.cpp
 x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../alsaplayer
-D_REENTRANT -march=athlon64 -O2 -pipe -march=athlon64 -O2 -pipe -c
FlacStream.cpp  -fPIC -DPIC -o .libs/FlacStream.o
FlacStream.cpp: In member function 'virtual bool Flac::FlacStream::open()':
FlacStream.cpp:154: error: invalid conversion from
'FLAC__StreamDecoderReadStatus (*)(const FLAC__StreamDecoder*, FLAC__byte*,
unsigned int*, void*)' to 'FLAC__StreamDecoderReadStatus (*)(const
FLAC__StreamDecoder*, FLAC__byte*, size_t*, void*)'
FlacStream.cpp:154: error:   initializing argument 2 of
'FLAC__StreamDecoderInitStatus
FLAC__stream_decoder_init_stream(FLAC__StreamDecoder*,
FLAC__StreamDecoderReadStatus (*)(const FLAC__StreamDecoder*, FLAC__byte*,
size_t*, void*), FLAC__StreamDecoderSeekStatus (*)(const FLAC__StreamDecoder*,
FLAC__uint64, void*), FLAC__StreamDecoderTellStatus (*)(const
FLAC__StreamDecoder*, FLAC__uint64*, void*), FLAC__StreamDecoderLengthStatus
(*)(const FLAC__StreamDecoder*, FLAC__uint64*, void*), FLAC__bool (*)(const
FLAC__StreamDecoder*, void*), FLAC__StreamDecoderWriteStatus (*)(const
FLAC__StreamDecoder*, const FLAC__Frame*, const FLAC__int32* const*, void*),
void (*)(const FLAC__StreamDecoder*, const FLAC__StreamMetadata*, void*), void
(*)(const FLAC__StreamDecoder*, FLAC__StreamDecoderErrorStatus, void*), void*)'
make[3]: *** [FlacStream.lo] Error 1
make[3]: Leaving directory
`/var/tmp/portage/media-sound/alsaplayer-0.99.80_rc1/work/alsaplayer-0.99.80-rc1/input/flac'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/var/tmp/portage/media-sound/alsaplayer-0.99.80_rc1/work/alsaplayer-0.99.80-rc1/input'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/tmp/portage/media-sound/alsaplayer-0.99.80_rc1/work/alsaplayer-0.99.80-rc1'
make: *** [all] Error 2





please just leave that one open until it's resolved so that people do not
believe we're just lazy to unmask flac 1.1.4 ;)


sizeof(unsigned) == 4, sizeof(size_t) == 8 here

Created an attachment (id=122212) [details]
Fix for flac 64 bit build

This patch will fix this issue, but it will break with flac < 1.4. So, test the
flac version in the ebuild if you want to apply it.

I committed a modified version into the svn that will hopefully work in any
cases. Will be with next release.

(In reply to comment #1)

> This patch will fix this issue, but it will break with flac < 1.4.

Sorry, it was flac < 1.1.4 of course

aballier: would you like me to lock this version to <flac-1.1.3 in the
meantime?

(In reply to comment #3)
> aballier: would you like me to lock this version to <flac-1.1.3 in the
> meantime?

It'd be probably saner, yes, just ~dep to flac 1.1.2. But please leave that bug
open until the new release (or the patch) hits the tree so that I'll easily
know when to unmask flac 1.1.4 by looking at blockers of bug #152007 (now that
they're all setup properly)

Hi,
Sorry for the slow response.  I'll have to have a closer look at this patch
this coming weekend, since at the moment, I'm right in the middle of study for
my last exam this semester.

Does anyone know if this problem is specific to AMD64, or has it been verified
on other architectures too?  Seeing as I don't have any AMD64 kit, it's
incredibly difficult for me to test my changes.  (My boxes are x86 and mips.)

I'll see if I can reproduce it on mips (this is my main platform at the moment)
and see what happens... but would appreciate feedback from others who may have
experienced this on architectures other than AMD64.

Been a month and this is only thing stopping flac-1.1.4 unmasking so either
apply it, drop USE flac from alsaplayer or let amd64 package.use.mask it. So
ping..

(In reply to comment #3)
> aballier: would you like me to lock this version to <flac-1.1.3 in the
> meantime?
> 

works fine on ~x86 and flac-1.1.4 so don't.

Patch committed, flac dep raised to >=flac-1.1.3. Thanks Dominique for patch,
aballier for testing..

(was after discussing with dirtyepic)

> aballier for testing..

s/testing/reporting/

dep raising to >=flac-1.1.3 breaks deps on (stable) akode and xine-lib (at
least!) !! 

(In reply to comment #10)
> dep raising to >=flac-1.1.3 breaks deps on (stable) akode and xine-lib (at
> least!) !! 
> 

I don't see any stable KEYWORDS here.

alsaplayer-0.99.80_rc1.ebuild:KEYWORDS="~amd64 ~mips ~ppc ~sparc ~x86"
flac-1.1.3.ebuild:KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64
~sh ~sparc ~x86 ~x86-fbsd"
flac-1.1.4.ebuild:KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64
~sh ~sparc ~x86 ~x86-fbsd"

So, basically you're saying you locally unmasked flac-1.1.3 or 1.1.4 and it
breaks? So don't, it's not ready for stable yet.

No breakage here.