First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 181783
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
zip.patch Patch patch Arfrever Frehtes Taifersar Arahesis 2007-06-12 19:49 0000 730 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 181783 depends on: Show dependency tree
Bug 181783 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2007-06-12 16:30 0000 
CFLAGS are always ignored.

### List of files built with LDFLAGS ignored ###
/usr/bin/zip
/usr/bin/zipcloak
/usr/bin/zipsplit
/usr/bin/zipnote
### End of list                              ###

------- Comment #1 From Jakub Moc (RETIRED) 2007-06-12 17:48:20 0000 ------- 
OK, that was about enough.

1/ Use common sense when filing bugs (like, what about mailing gentoo-dev
mailing list first and asking about the best course of action here?
2/ If you have a patch, submit it *upstream* unless this is a *Gentoo-specific*
issue.

------- Comment #2 From Arfrever Frehtes Taifersar Arahesis 2007-06-12 18:14:58 0000 ------- 
This bug report also concerns CFLAGS. Unfortunately you didn't see it.
http://devmanual.gentoo.org/ebuild-writing/functions/src_compile/building/index.html
and http://devmanual.gentoo.org/general-concepts/user-environment/index.html
say that CFLAGS should be respected. I think that this bug report should be
reopened.

------- Comment #3 From Arfrever Frehtes Taifersar Arahesis 2007-06-12 19:48:32 0000 ------- 
I discovered that target "generic" has broken behaviour (and generally this
Makefile is strange). It uses variables from file "flags", so this file must be
recreated.

If "eval $(MAKE) zips `cat flags`" is changed to "eval $(MAKE) zips", then we
have new problems:
 1. CFLAGS doesn't contain probably necessary -D* flags.
 2. "LFLAGS1 =" line should be changed to "LFLAGS1 = $(LDFLAGS)" using sed.
 3. "LFLAGS2 = -s" line causes "QA Notice: Pre-stripped files found".
 4. OBJA isn't set and executable "zip" lacks code from 2 object files, because
there is in unix/Makefile:
OBJA =
...
zip$(EXE): $(OBJZ) $(OBJI) $(OBJA)
        $(BIND) -o zip$(EXE) $(LFLAGS1) $(OBJZ) $(OBJI) $(OBJA) $(LFLAGS2)



I think that recreating file "flags" is good decision.

------- Comment #4 From Arfrever Frehtes Taifersar Arahesis 2007-06-12 19:49:53 0000 ------- 
Created an attachment (id=121847) [details]
Patch

------- Comment #5 From SpanKY 2007-06-13 00:30:15 0000 ------- 
that patch is certainly not right ... you cant hardcode those flags in the
ebuild

ive cleaned up the build process in cvs
First Last Prev Next    No search results available      Search page      Enter new bug