Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 180669 - x11-libs/gtk+-2.10.12 file chooser resizing
Summary: x11-libs/gtk+-2.10.12 file chooser resizing
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-02 21:32 UTC by Andrew Hurst
Modified: 2007-06-14 20:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patchset as described. Use me after all (filechooserdialogbugfix.diff,19.59 KB, patch)
2007-06-03 12:19 UTC, Andrew Hurst
Details | Diff
Patchset as described .. version 2.0 (filechooserdialogbugfix.diff,19.58 KB, patch)
2007-06-03 14:47 UTC, Andrew Hurst
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Hurst 2007-06-02 21:32:57 UTC
As described in several places, including

http://forums.mozillazine.org/viewtopic.php?p=2896784&sid=50632971551ac982392637e1733aaef6

In applications using GTK+2 save dialog (in my case, GVim, Firefox, Gimp,...) the dialog in question continues to alternate between two widths.

Reproducible: Always

Steps to Reproduce:
1.Start Gvim
2. Choose 'File.. Save'
3.  Enjoy the show




Bug is fixed in GTK+ 2.11.0
Comment 1 Rémi Cardona (RETIRED) gentoo-dev 2007-06-03 10:03:53 UTC
We're waiting a bit to stabilize gnome 2.18 so no plans to add a new gtk right now. However if you can extract the patch and if it's not to big, we could possibly include it.

Thanks
Comment 2 Andrew Hurst 2007-06-03 11:01:40 UTC
Ok, here are the changes as submitted to Gnome's SVN

http://svn.gnome.org/viewcvs/gtk%2B/?view=query&dir=&file=&file_match=notregex&who=carlos&who_match=regex&comment=&comment_match=notregex&querysort=date&hours=2&date=explicit&mindate=2007-05-18+16%3A00%3A00&maxdate=2007-05-18+17%3A00%3A00&limit_changes=100

I've now learnt more about the Gnome development setup than I ever thought I would!

Want me to apply them to Gentoo's 2.10.12 and then attach the diffs?
Comment 3 Andrew Hurst 2007-06-03 12:18:25 UTC
The patches as from the link above work unchanged on 2.10.12
Attaching as single file...
Comment 4 Andrew Hurst 2007-06-03 12:19:32 UTC
Created attachment 121027 [details, diff]
Patchset as described. Use me after all
Comment 5 Andrew Hurst 2007-06-03 12:25:23 UTC
I have checked these patches do not interfere with those in /usr/portage/x11-libs/gtk+/files/

by doing a '$ grep filechooser *' there.
Comment 6 Andrew Hurst 2007-06-03 12:31:04 UTC
In the meantime, the workaround is to click the 'Browse for other folders' drop-down. =)
Comment 7 Rémi Cardona (RETIRED) gentoo-dev 2007-06-03 12:57:25 UTC
@gnome: any objections about adding this?

Andrew, thanks for your work :)
Comment 8 Andrew Hurst 2007-06-03 14:47:12 UTC
Created attachment 121038 [details, diff]
Patchset as described .. version 2.0

.. without the weird character on line 30

I didn't notice the Gnome svn server spitting that out earlier.

perhaps I should file a bug!
Comment 9 Andrew Hurst 2007-06-03 15:05:04 UTC
The weird character is in the original source code.
Comment 10 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-06-04 17:56:02 UTC
remi: Go ahead and apply.  Even money a 2.10.13 comes out before we stabilize 2.10.12, but it may still be worth it, and, of course, it will fix ~ boxes.
Comment 11 Mart Raudsepp gentoo-dev 2007-06-14 02:43:14 UTC
Fixed in the 2.10.13 version bump according to NEWS file and my quick testing of it in fluxbox (prior to upgrading I also reproduced the problem with gtk+-2.10.12 in fluxbox).
I am thinking about fast-tracking gtk+-2.10.13 to stable in 20 days instead of 30 together with pango-1.16.
Comment 12 Andrew Hurst 2007-06-14 11:43:40 UTC
2.10.13: Confirm fixed for me..

The patchset I posted was part of the 2.10.12 -> 2.10.13 version bump.
Comment 13 Rémi Cardona (RETIRED) gentoo-dev 2007-06-14 19:29:33 UTC
+1 on fast-tracking gtk+-2.10.13 along with pango-1.16.3

CC arches here or do we create another bug?
Comment 14 Mart Raudsepp gentoo-dev 2007-06-14 19:38:18 UTC
New bug when it's time, I'd say, with a note about this fix if we need more reasoning on why we do it earlier. For pango it's been in tree already longer and that's not exactly fast tracking - however someone should test if it works with GNOME-2.16 and in my experience it does (I have libraries at 2.18, including pango-1.16, and apps at 2.16 atm during upgrading and things work great).
Maybe newer glib too. What I have in mind with this stabilization bug is stabilization of GNOME 2.18 stuff that is in the lower stack which we could do earlier - gtk+ and lower.
Comment 15 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-06-14 20:09:17 UTC
We traditionally stabilize glib/gtk+ before the rest of a release.  I see no reason to not add pango/cariro to that.