Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 180667 - dev-util/cmake-2.4.6 comes with emacs and vim syntax files, should have useflags (ebuild provided)
Summary: dev-util/cmake-2.4.6 comes with emacs and vim syntax files, should have usefl...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: 184166
  Show dependency tree
 
Reported: 2007-06-02 21:21 UTC by Jack Kelly
Modified: 2007-06-07 16:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new cmake-2.4.6 ebuild (cmake-2.4.6.ebuild,1.78 KB, text/plain)
2007-06-02 21:22 UTC, Jack Kelly
Details
sitefile for emacs cmake-mode (50cmake-gentoo.el,220 bytes, text/plain)
2007-06-02 21:22 UTC, Jack Kelly
Details
ftdetect file for vim syntax highlighting (cmake.vim,217 bytes, text/plain)
2007-06-02 21:23 UTC, Jack Kelly
Details
ebuild that doesn't try to elisp-site-regen when USE="-emacs" (cmake-2.4.6.ebuild,1.80 KB, text/plain)
2007-06-02 21:54 UTC, Jack Kelly
Details
fixed sitefile for cmake-mode that uses the autoload system (50cmake-gentoo.el,244 bytes, text/plain)
2007-06-02 21:55 UTC, Jack Kelly
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Kelly 2007-06-02 21:21:19 UTC
While the tarball distributed by kitware contains a cmake-mode for emacs and syntax/autoindent files for vim, they aren't installed and do not have use flags.

Reproducible: Always

Steps to Reproduce:
1. emerge -pv cmake
2. note the lack of emacs and vim-syntax USE flags
3. cry
Comment 1 Jack Kelly 2007-06-02 21:22:02 UTC
Created attachment 120982 [details]
new cmake-2.4.6 ebuild

Add USE=emacs and USE=vim-syntax to cmake ebuild.
Comment 2 Jack Kelly 2007-06-02 21:22:36 UTC
Created attachment 120983 [details]
sitefile for emacs cmake-mode
Comment 3 Jack Kelly 2007-06-02 21:23:53 UTC
Created attachment 120984 [details]
ftdetect file for vim syntax highlighting

emacs is my editor of choice, so I'm not 100% on how vim does things. I did install vim and test this against a CMakeLists.txt file, but there could be pitfalls here I'm not aware of.
Comment 4 Ulrich Müller gentoo-dev 2007-06-02 21:32:22 UTC
Concerning the Emacs part, please fix the following:
1. pkg_post{inst,rm} should have:   use emacs && elisp-site-regen
2. Use "add-to-list" for load-path and auto-mode-alist
3. Please don't "require" or "load" packages in your site-init files.
   Use the autoload mechanism whereever possible. See bug #174469 and
   <http://overlays.gentoo.org/proj/emacs/wiki/sitefile%20problems>
   for further explanation.
Comment 5 Jack Kelly 2007-06-02 21:54:52 UTC
Created attachment 120991 [details]
ebuild that doesn't try to elisp-site-regen when USE="-emacs"
Comment 6 Jack Kelly 2007-06-02 21:55:30 UTC
Created attachment 120992 [details]
fixed sitefile for cmake-mode that uses the autoload system
Comment 7 Ulrich Müller gentoo-dev 2007-06-02 22:06:19 UTC
(In reply to comment #6)
> Created an attachment (id=120992) [edit]
> fixed sitefile for cmake-mode that uses the autoload system

Looks good to me. Also the ebuild, as far as Emacs is concerned.
I can't speak for vi, though.
Comment 8 Christian Faulhammer (RETIRED) gentoo-dev 2007-06-04 12:57:09 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=120992) [edit]
> > fixed sitefile for cmake-mode that uses the autoload system
> Looks good to me. Also the ebuild, as far as Emacs is concerned.
> I can't speak for vi, though.

 We will ask them...
KDE team: If you don't incorporate the fixes or speak against them, we will aplly them in two weeks time.
Comment 9 Wulf Krueger (RETIRED) gentoo-dev 2007-06-04 17:50:11 UTC
 (In reply to comment #8)
> KDE team: If you don't incorporate the fixes or speak against them, we will
> aplly them in two weeks time.

Let's hear the vim guys first, shall we? :-)

(Btw, last time I checked, the kde herd was responsive (q. e. d. ;-) ) to such requests so I don't see the need for a deadline yet.)
Comment 10 Mike Kelly (RETIRED) gentoo-dev 2007-06-04 18:10:54 UTC
At a glance, the vim stuff looks good to me. Don't have time to test it now, though.
Comment 11 Wulf Krueger (RETIRED) gentoo-dev 2007-06-07 16:27:42 UTC
I've implemented the changes in -r1 which I've just committed to CVS. Thanks, Jack, for bringing this to our attention and to my fellow devs for reviewing the emacs and vim parts.