Bugzilla Bug 180667

While the tarball distributed by kitware contains a cmake-mode for emacs and
syntax/autoindent files for vim, they aren't installed and do not have use
flags.

Reproducible: Always

Steps to Reproduce:
1. emerge -pv cmake
2. note the lack of emacs and vim-syntax USE flags
3. cry

Created an attachment (id=120982) [details]
new cmake-2.4.6 ebuild

Add USE=emacs and USE=vim-syntax to cmake ebuild.

Created an attachment (id=120983) [details]
sitefile for emacs cmake-mode

Created an attachment (id=120984) [details]
ftdetect file for vim syntax highlighting

emacs is my editor of choice, so I'm not 100% on how vim does things. I did
install vim and test this against a CMakeLists.txt file, but there could be
pitfalls here I'm not aware of.

Concerning the Emacs part, please fix the following:
1. pkg_post{inst,rm} should have:   use emacs && elisp-site-regen
2. Use "add-to-list" for load-path and auto-mode-alist
3. Please don't "require" or "load" packages in your site-init files.
   Use the autoload mechanism whereever possible. See bug #174469 and
   <http://overlays.gentoo.org/proj/emacs/wiki/sitefile%20problems>
   for further explanation.

Created an attachment (id=120991) [details]
ebuild that doesn't try to elisp-site-regen when USE="-emacs"

Created an attachment (id=120992) [details]
fixed sitefile for cmake-mode that uses the autoload system

(In reply to comment #6)
> Created an attachment (id=120992) [edit] [details]
> fixed sitefile for cmake-mode that uses the autoload system

Looks good to me. Also the ebuild, as far as Emacs is concerned.
I can't speak for vi, though.

(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=120992) [edit] [details]
> > fixed sitefile for cmake-mode that uses the autoload system
> Looks good to me. Also the ebuild, as far as Emacs is concerned.
> I can't speak for vi, though.

 We will ask them...
KDE team: If you don't incorporate the fixes or speak against them, we will
aplly them in two weeks time.

 (In reply to comment #8)
> KDE team: If you don't incorporate the fixes or speak against them, we will
> aplly them in two weeks time.

Let's hear the vim guys first, shall we? :-)

(Btw, last time I checked, the kde herd was responsive (q. e. d. ;-) ) to such
requests so I don't see the need for a deadline yet.)

At a glance, the vim stuff looks good to me. Don't have time to test it now,
though.

I've implemented the changes in -r1 which I've just committed to CVS. Thanks,
Jack, for bringing this to our attention and to my fellow devs for reviewing
the emacs and vim parts.