Bugzilla Bug 180340

Hello,

if one of your disks is faulty and not necessarily the one needed during the
boot process, vgscan won't return 0 and you won't be able to boot at all.
That could appended when you use a disk managed with evms or if for some
reason, your logical volumes become corrupted. By chance, vgchange will do the
job well and you will at least be able to switch to the single user if needed.

The idea is to live the $? = 0 test from the if condition in
/lib64/rcscripts/addons/lvm-start.sh:

+               /sbin/vgscan --mknodes --ignorelockingfailure >/dev/null
+               if [ -x /sbin/vgchange ] && \
+                  [ -f /etc/lvmtab -o -d /etc/lvm ]
+               then
+                       /sbin/vgchange --ignorelockingfailure -a y >/dev/null
                fi


Jj

Reproducible: Always

Sorry, the patch doesn't parse. :) It's a verbatim copy of current behaviour,
so what exactly is the idea here? Attach a unified diff since it's not really
apparent what are you fixing. Also post emerge --info.

(In reply to comment #1)
> Sorry, the patch doesn't parse. :) It's a verbatim copy of current behaviour,
> so what exactly is the idea here? Attach a unified diff since it's not really
> apparent what are you fixing. Also post emerge --info.
> 

Sorry, i was a bite on a hurry when i wrote that post. It is not so easy to
maintain so much packages on my computers, during my spare time (even if i
don't have time to use them all) and still have time to write something almost
"intelligible" in a foreign language when something goes wrong :).

Anyway, the idea was to increase the ability gentoo boots the system even if
something goes wrong.

I use on my computers evms, mdp and lvm disks. Some of the older evms disks are
no more recognized by evms_activate. Also, udev-start.sh calls evms_activate
and in my case will fail before the root filesystem is mounted. The system just
stops and gives me a dull ash prompt (That is why i commented out evms_activate
and vgscan from udev-start.sh, but that is out of the topic). Moreover, the
evms drive doesn't contain the root filesystem.

When lvm-start.sh is called, some of the evms disks are however recognized by
vgscan and vgchange but vgscan returns a status different from 0 and that will
make lvm-start.sh end with a failure. That's why it would be great not to check
the vgscan status and take only account of the vgchange one. 

Jj

Created an attachment (id=120764) [edit]
less restrictive checking

(In reply to comment #3)
> Created an attachment (id=120764) [edit]
> less restrictive checking

Much more clear now... 

Thanks for the patch. Looks good. Committed.