Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 1802
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Seemant Kulleen (RETIRED) <seemant@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Paul de Vrieze <pauldv@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
pnm2ppa.diff.1 Diff file on the ebuild patch Paul de Vrieze 2002-04-15 10:38 0000 306 bytes Details | Diff
pnm2ppa.diff.2 Replacement patchfile for pnm2ppa-r3 text/plain Paul de Vrieze 2002-04-15 10:40 0000 5.10 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 1802 depends on: Show dependency tree
Bug 1802 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2002-04-15 10:36 0000
Yesterdays patch was incomplete, (forgot to define __GNU_SYSTEM) don't know if
its critical. Also the ebuild makes a pnm2ppa that segfaults because of a
missing define in the CFLAGS

------- Comment #1 From Paul de Vrieze 2002-04-15 10:38:05 0000 -------
Created an attachment (id=571) [details]
Diff file on the ebuild

The new ebuild defines an extra make flag. This way pnm2ppa doesn't segfault
when running

------- Comment #2 From Paul de Vrieze 2002-04-15 10:40:42 0000 -------
Created an attachment (id=572) [details]
Replacement patchfile for pnm2ppa-r3

This is a replacement patch file. It is not a patch of the patch anymore
because that diff also sees a lot of filetime changes that are IMHO not
relevant. The only change though is in pnm2ppa.c, it now also defines 
_GNU_SOURCE.

------- Comment #3 From Seemant Kulleen (RETIRED) 2002-04-15 17:46:17 0000 -------
I did not see a patch.  I saw the ebuild file in the attachment.  The only
difference between that and the -r2 ebuild is an extra definition in CFLAGS.  Is
that all that is different? I had assumed that you 
had attached a diff to the pnm2ppa source as well, or am I mistaken in my
assumption?

Thanks

------- Comment #4 From Paul de Vrieze 2002-04-16 02:27:07 0000 -------
 Oops I attached the wrong file. You can change it yourself. 
On the 5th line of pnm2ppa.c (before include <string.h>) there needs to be a  
line: #define _GNU_SOURCE 
 
This stops a warning in the compile from appearing. (I didn't check wether it  
actually ran well without this patch) 
 
Paul 
 

------- Comment #5 From Seemant Kulleen (RETIRED) 2002-04-16 07:41:49 0000 -------
Any chance I can get you to test that?

------- Comment #6 From Paul de Vrieze 2002-04-16 07:58:48 0000 -------
If you wait a couple of hours, I'll test it (with the ebuild patch as it 
segfaults without). It should be done anyway though. The new version works by 
the way. 

------- Comment #7 From Seemant Kulleen (RETIRED) 2002-04-17 03:42:27 0000 -------
Thanks for this fix :)

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug