Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 179612 - www-apps/viewvc-1.0.3 ebuild problem
Summary: www-apps/viewvc-1.0.3 ebuild problem
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-24 08:50 UTC by Barry Wardell
Modified: 2007-10-26 16:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Barry Wardell 2007-05-24 08:50:55 UTC
The ebuild for ViewVC 1.0.3 has a line for installing the bin files:

cp -p bin/ ${D}/usr/share/webapps/${PN}/bin

However, when installing, it skips this copy operation because bin is a directory and it's not using the -r option for cp. A simply fix is to change this line to

cp -rp bin/ ${D}/usr/share/webapps/${PN}/

Note that I have also removed the 'bin' from the end.
Comment 1 Renat Lumpau (RETIRED) gentoo-dev 2007-05-26 22:14:53 UTC
Done
Comment 2 Matthias Foerste 2007-08-16 14:30:40 UTC
I stumbled upon this problem today - looks like the fix has not yet been committed?
Comment 3 Torsten Rehn 2007-09-20 13:14:07 UTC
You're right, I can't find anything of the fix in CVS at any revision.

cp: omitting directory `bin/asp'
cp: omitting directory `bin/cgi'
cp: omitting directory `bin/mod_python'

However, although I'm not that familiar with the package, I don't see any reason to alter the install location of those files (i.e. leave the target path as ${D}/usr/share/webapps/${PN}/bin).

I'll ask to get this reopened, so the web-apps herd can bring some light into this...
Comment 4 Christoph Mende (RETIRED) gentoo-dev 2007-09-20 13:33:45 UTC
reopening wrt comment #2 and #3
Comment 5 Barry Wardell 2007-09-20 13:52:29 UTC
This also appears to affect the ebuild for version 1.0.4.

Comment 6 Matthias Foerste 2007-09-21 09:50:52 UTC
The reason for 'bin' being removed from the end was that this dir was created earlier in the ebuild, so the files would end up in ${D}/usr/share/webapps/${PN}/bin/bin. Another way to fix it should be

cp -rp bin/* ${D}/usr/share/webapps/${PN}/bin
Comment 7 Gunnar Wrobel (RETIRED) gentoo-dev 2007-10-26 16:16:06 UTC
The directories within "bin" shouldn't get copied since they are being moved into other directories in /usr/share/webapps/viewvc.

This is a pretty shabby ebuild though. I should really fix it at some point.