Bugzilla Bug 179152

A few days ago gmail stopped working for users of the konqueror web browser
(spoofed as firefox).  Luckily, the issue is relatively easy to fix.  This is
just a small ebuild modification to let gmail users back into the fun.

Reproducible: Always

Created an attachment (id=119745) [details]
Updated ebuild to fix a gmail bug

Ben, your help is appreciated but please do the following next time:

- Don't attach archives.
- Attach a diff (diff -u <old ebuild> <new ebuild>) for the ebuild only.
- Attach the patch which you should create as described in
http://dev.gentoo.org/~masterdriverz/patch.xml

Reopen with a unified diff against the relevant file; thanks.

Uh, Jakub, please stop to annoy everyone (again). Resolving needinfo produced
only bug spam and is totally unnecessary.

Intend to let this bug sit for a few days, as I'm unsure, why carewolf is
posting this quick fix, but neither committing to trunk nor branch.

Created an attachment (id=120448) [details]
kdelibs-3.5.7-innerhtml.patch

Works for me.

Can someone advise a test scenario for this, please? 

Without any patch and with konqueror masquerading as Firefox 1.5.0.4, Gmail
seems to work just fine for me (and not just in basic view). I'm not using
Gmail much, though, so I might miss something.

Furthermore, the patch carewolf checked in is a one-liner now:

--- branches/KDE/3.5/kdelibs/khtml/html/html_elementimpl.cpp    2006/10/21
13:43:33     597736
+++ branches/KDE/3.5/kdelibs/khtml/html/html_elementimpl.cpp    2007/05/27
10:16:02     668699
@@ -503,7 +503,6 @@
         case ID_COLGROUP:
         case ID_FRAMESET:
         case ID_HEAD:
-        case ID_STYLE:
         case ID_TABLE:
         case ID_TBODY:
         case ID_TFOOT:

Created an attachment (id=120837) [details]
konqueror config for gmail/google

Testing config for konqueror

Created an attachment (id=120838) [details]
Broken gmail rendering

This is the broken display I get with komqueror when the above config.

Created an attachment (id=120840) [details]
Proper gmail rendering

After compiling kdelibs with Alon Bar-Lev's patch, konqueror displays GMail
properly.

Created an attachment (id=120841) [details]
Trivial patch for kdelibs-3.5.7.ebuild to apply Alon Bar-Lev's patch

Created an attachment (id=120845) [details]
have a look

FWIW, it works for me w/o the patch.

Are you sure?
It means that Gmail was modified...

I have kde-3.5.7 from the tree and you can see the screenshot, also Wulf
doesn't seem to have this problem.

 (In reply to comment #13)
> I have kde-3.5.7 from the tree and you can see the screenshot, also Wulf doesn't
> seem to have this problem.

Indeed. It works just fine for me, too, without any patch. I can't reproduce
the problem what ever I do - not with a new user not having a ~/.kde nor with
the ~/.kde from my main machine used in my testing environment. That and the
one-liner carewolf checked in make me hesitant to add any patch.

Could someone who has this problem try accessing Gmail with a new user (i. e.
with no ~/.kde)?

Recompiled kdelibs, I regret to say but gmail does not work for me. I don't
know how this is possible...

Created an attachment (id=120886) [details]
kdelibs-3.5.7-html-style.patch

Well... Tried the simpler patch and this also work... :)
So something should be applied... to make users happy.

philantrop: Please attach patches not paste them.

(In reply to comment #16)
> Well... Tried the simpler patch and this also work... :)
> So something should be applied... to make users happy.

Ok, if it fixes the evasive problem, I'll add it.

> philantrop: Please attach patches not paste them.

Alon, the patch most obviously was only meant to inform people about what was
actually committed and not intended for use in the ebuild or I would have made
it against the tarball and not KDE's svn. :-)

Thanks for the patch. Committed to CVS. (No revision bump because it's kdelibs
and even though the patch is rather generic, the problems only seems to be with
Gmail so far.)

I think revbump should be committed, since many people had moved from konqueror
to firefox because of this issue, they will not be able to get this work as
they wait for gmail to be work with current configuration.

There are a lot of gmail users out there...