Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 179152 - kde-base/kdelibs - KHTML Gmail fix
Summary: kde-base/kdelibs - KHTML Gmail fix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL: http://www.kdedevelopers.org/node/2807
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-19 21:48 UTC by Ben Hughes
Modified: 2007-06-01 20:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated ebuild to fix a gmail bug (kdelibs.tar.bz2,9.38 KB, application/octet-stream)
2007-05-19 21:51 UTC, Ben Hughes
Details
kdelibs-3.5.7-innerhtml.patch (kdelibs-3.5.7-innerhtml.patch,692 bytes, patch)
2007-05-27 14:42 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
konqueror config for gmail/google (browser config.png,49.22 KB, image/png)
2007-06-01 01:14 UTC, Jorge Manuel B. S. Vicetto (RETIRED)
Details
Broken gmail rendering (bad gmail.png,229.37 KB, image/png)
2007-06-01 01:15 UTC, Jorge Manuel B. S. Vicetto (RETIRED)
Details
Proper gmail rendering (good gmail.png,203.12 KB, image/png)
2007-06-01 03:13 UTC, Jorge Manuel B. S. Vicetto (RETIRED)
Details
Trivial patch for kdelibs-3.5.7.ebuild to apply Alon Bar-Lev's patch (kdelibs-3.5.7.diff,376 bytes, patch)
2007-06-01 03:24 UTC, Jorge Manuel B. S. Vicetto (RETIRED)
Details | Diff
have a look (konqueror-gmail.jpg,106.63 KB, image/jpeg)
2007-06-01 07:08 UTC, Piotr Jaroszyński (RETIRED)
Details
kdelibs-3.5.7-html-style.patch (kdelibs-3.5.7-html-style.patch,517 bytes, patch)
2007-06-01 19:14 UTC, Alon Bar-Lev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Hughes 2007-05-19 21:48:47 UTC
A few days ago gmail stopped working for users of the konqueror web browser (spoofed as firefox).  Luckily, the issue is relatively easy to fix.  This is just a small ebuild modification to let gmail users back into the fun.

Reproducible: Always
Comment 1 Ben Hughes 2007-05-19 21:51:54 UTC
Created attachment 119745 [details]
Updated ebuild to fix a gmail bug
Comment 2 Wulf Krueger (RETIRED) gentoo-dev 2007-05-19 22:38:39 UTC
Ben, your help is appreciated but please do the following next time:

- Don't attach archives.
- Attach a diff (diff -u <old ebuild> <new ebuild>) for the ebuild only.
- Attach the patch which you should create as described in http://dev.gentoo.org/~masterdriverz/patch.xml
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-05-20 18:56:43 UTC
Reopen with a unified diff against the relevant file; thanks.
Comment 4 Carsten Lohrke (RETIRED) gentoo-dev 2007-05-20 19:54:58 UTC
Uh, Jakub, please stop to annoy everyone (again). Resolving needinfo produced only bug spam and is totally unnecessary.

Intend to let this bug sit for a few days, as I'm unsure, why carewolf is posting this quick fix, but neither committing to trunk nor branch.
Comment 5 Alon Bar-Lev (RETIRED) gentoo-dev 2007-05-27 14:42:13 UTC
Created attachment 120448 [details, diff]
kdelibs-3.5.7-innerhtml.patch

Works for me.
Comment 6 Wulf Krueger (RETIRED) gentoo-dev 2007-05-30 18:40:29 UTC
Can someone advise a test scenario for this, please? 

Without any patch and with konqueror masquerading as Firefox 1.5.0.4, Gmail seems to work just fine for me (and not just in basic view). I'm not using Gmail much, though, so I might miss something.

Furthermore, the patch carewolf checked in is a one-liner now:

--- branches/KDE/3.5/kdelibs/khtml/html/html_elementimpl.cpp	2006/10/21 13:43:33	597736
+++ branches/KDE/3.5/kdelibs/khtml/html/html_elementimpl.cpp	2007/05/27 10:16:02	668699
@@ -503,7 +503,6 @@
         case ID_COLGROUP:
         case ID_FRAMESET:
         case ID_HEAD:
-        case ID_STYLE:
         case ID_TABLE:
         case ID_TBODY:
         case ID_TFOOT:
Comment 7 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2007-06-01 01:14:06 UTC
Created attachment 120837 [details]
konqueror config for gmail/google

Testing config for konqueror
Comment 8 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2007-06-01 01:15:51 UTC
Created attachment 120838 [details]
Broken gmail rendering

This is the broken display I get with komqueror when the above config.
Comment 9 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2007-06-01 03:13:37 UTC
Created attachment 120840 [details]
Proper gmail rendering

After compiling kdelibs with Alon Bar-Lev's patch, konqueror displays GMail properly.
Comment 10 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2007-06-01 03:24:52 UTC
Created attachment 120841 [details, diff]
Trivial patch for kdelibs-3.5.7.ebuild to apply Alon Bar-Lev's patch
Comment 11 Piotr Jaroszyński (RETIRED) gentoo-dev 2007-06-01 07:08:09 UTC
Created attachment 120845 [details]
have a look

FWIW, it works for me w/o the patch.
Comment 12 Alon Bar-Lev (RETIRED) gentoo-dev 2007-06-01 07:18:17 UTC
Are you sure?
It means that Gmail was modified...
Comment 13 Piotr Jaroszyński (RETIRED) gentoo-dev 2007-06-01 11:43:25 UTC
I have kde-3.5.7 from the tree and you can see the screenshot, also Wulf doesn't seem to have this problem.
Comment 14 Wulf Krueger (RETIRED) gentoo-dev 2007-06-01 17:06:41 UTC
 (In reply to comment #13)
> I have kde-3.5.7 from the tree and you can see the screenshot, also Wulf doesn't
> seem to have this problem.

Indeed. It works just fine for me, too, without any patch. I can't reproduce the problem what ever I do - not with a new user not having a ~/.kde nor with the ~/.kde from my main machine used in my testing environment. That and the one-liner carewolf checked in make me hesitant to add any patch.

Could someone who has this problem try accessing Gmail with a new user (i. e. with no ~/.kde)?
Comment 15 Alon Bar-Lev (RETIRED) gentoo-dev 2007-06-01 18:21:04 UTC
Recompiled kdelibs, I regret to say but gmail does not work for me. I don't know how this is possible...
Comment 16 Alon Bar-Lev (RETIRED) gentoo-dev 2007-06-01 19:14:23 UTC
Created attachment 120886 [details, diff]
kdelibs-3.5.7-html-style.patch

Well... Tried the simpler patch and this also work... :)
So something should be applied... to make users happy.

philantrop: Please attach patches not paste them.
Comment 17 Wulf Krueger (RETIRED) gentoo-dev 2007-06-01 20:10:55 UTC
(In reply to comment #16)
> Well... Tried the simpler patch and this also work... :)
> So something should be applied... to make users happy.

Ok, if it fixes the evasive problem, I'll add it.

> philantrop: Please attach patches not paste them.

Alon, the patch most obviously was only meant to inform people about what was actually committed and not intended for use in the ebuild or I would have made it against the tarball and not KDE's svn. :-)

Thanks for the patch. Committed to CVS. (No revision bump because it's kdelibs and even though the patch is rather generic, the problems only seems to be with Gmail so far.)
Comment 18 Alon Bar-Lev (RETIRED) gentoo-dev 2007-06-01 20:18:46 UTC
I think revbump should be committed, since many people had moved from konqueror to firefox because of this issue, they will not be able to get this work as they wait for gmail to be work with current configuration.

There are a lot of gmail users out there...