Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 178873
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Linux Gnome Desktop Team <gnome@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Thomas R. (TRauMa) <gentoo-bugs@digital-trauma.de>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
gparted-deps.diff Patch for deps patch Thomas R. (TRauMa) 2007-05-17 13:12 0000 706 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 178873 depends on: Show dependency tree
Bug 178873 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-05-17 13:12 0000
Hi, while playing with portage & binpkgs, I noticed gparted has unnecessary
deps, the bunch of file utils is only needed at runtime. See patch.

------- Comment #1 From Thomas R. (TRauMa) 2007-05-17 13:12:59 0000 -------
Created an attachment (id=119527) [details]
Patch for deps

------- Comment #2 From Gilles Dartiguelongue 2007-09-08 22:10:09 0000 -------
I fail to see what you are trying to achieve in your patch

I'm willing to close as invalid though since fs specific utils are required
both at compile time and at runtime because gparted (afaik) dynamically checks
for the presence of these utilities when it's launched.

If I'm wrong please explain better what you want.

------- Comment #3 From Thomas R. (TRauMa) 2007-09-09 12:26:10 0000 -------
The patch removes the utilities from the compile time deps, "because gparted
(afaik) dynamically checks for the presence of these utilities when it's
launched" and they don't need to be around at compile time. To quote the
README:

GParted stands for Gnome Partition Editor.

It uses libparted to detect and manipulate devices and partitiontables while
several (optional) filesystemtools
provide support for filesystems not included in libparted.
These optional packages will be detected at runtime and don't require a rebuild
of GParted.


So, on a host compiling packages on behalf of other hosts, these deps get
installed needlessly.

------- Comment #4 From Rémi Cardona 2007-09-09 17:06:30 0000 -------
If those tools are not needed at build time at all, there's no need to have
useflags for them and it'd be better to consider removing them altogether and
use elog to print out the names of those tools for specific FS support (pretty
much like file-roller and archivers support).

@herd: what do you guys think?

------- Comment #5 From Daniel Gryniewicz 2007-09-20 14:21:10 0000 -------
I'm not a huge fan of "You need to install x to get functionality y" as an
elog;  But, aside from that, there's no point in changing the structure of the
ebuild now.  It would just confuse users.

I've fixed this the same way Thomas suggested.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug