Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 178873 - Wrong DEPEND for sys-block/gparted-0.3.3
Summary: Wrong DEPEND for sys-block/gparted-0.3.3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-17 13:12 UTC by Thomas R. (TRauMa)
Modified: 2007-09-20 14:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for deps (gparted-deps.diff,706 bytes, patch)
2007-05-17 13:12 UTC, Thomas R. (TRauMa)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas R. (TRauMa) 2007-05-17 13:12:01 UTC
Hi, while playing with portage & binpkgs, I noticed gparted has unnecessary deps, the bunch of file utils is only needed at runtime. See patch.
Comment 1 Thomas R. (TRauMa) 2007-05-17 13:12:59 UTC
Created attachment 119527 [details, diff]
Patch for deps
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-09-08 22:10:09 UTC
I fail to see what you are trying to achieve in your patch

I'm willing to close as invalid though since fs specific utils are required both at compile time and at runtime because gparted (afaik) dynamically checks for the presence of these utilities when it's launched.

If I'm wrong please explain better what you want.
Comment 3 Thomas R. (TRauMa) 2007-09-09 12:26:10 UTC
The patch removes the utilities from the compile time deps, "because gparted (afaik) dynamically checks for the presence of these utilities when it's launched" and they don't need to be around at compile time. To quote the README:

GParted stands for Gnome Partition Editor.

It uses libparted to detect and manipulate devices and partitiontables while several (optional) filesystemtools
provide support for filesystems not included in libparted.
These optional packages will be detected at runtime and don't require a rebuild of GParted.


So, on a host compiling packages on behalf of other hosts, these deps get installed needlessly.
Comment 4 Rémi Cardona (RETIRED) gentoo-dev 2007-09-09 17:06:30 UTC
If those tools are not needed at build time at all, there's no need to have useflags for them and it'd be better to consider removing them altogether and use elog to print out the names of those tools for specific FS support (pretty much like file-roller and archivers support).

@herd: what do you guys think?
Comment 5 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-09-20 14:21:10 UTC
I'm not a huge fan of "You need to install x to get functionality y" as an elog;  But, aside from that, there's no point in changing the structure of the ebuild now.  It would just confuse users.

I've fixed this the same way Thomas suggested.