Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 178857 - net-www/mplayerplug-in - Build both 32bit and 64bit plugin on AMD64
Summary: net-www/mplayerplug-in - Build both 32bit and 64bit plugin on AMD64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High enhancement
Assignee: Joe Jezak (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-17 10:42 UTC by Jonas Jonsson
Modified: 2008-01-06 22:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayerplug-in-3.40-r1.ebuild (mplayerplug-in-3.40-r1.ebuild,3.51 KB, text/plain)
2007-05-17 11:13 UTC, Jonas Jonsson
Details
mplayerplug-in-3.45.ebuild (mplayerplug-in-3.45.ebuild,3.96 KB, text/plain)
2007-10-05 12:35 UTC, Jonas Jonsson
Details
mplayerplug-in-3.45.ebuild (mplayerplug-in-3.45.ebuild,4.07 KB, text/plain)
2007-12-06 23:45 UTC, Aline de Freitas
Details
mplayerplug-in-3.45.ebuild (mplayerplug-in-3.45.ebuild,4.09 KB, text/plain)
2007-12-06 23:50 UTC, Aline de Freitas
Details
mplayerplug-in-3.45.ebuild (mplayerplug-in-3.45.ebuild,4.16 KB, text/plain)
2007-12-15 00:44 UTC, Aline de Freitas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Jonsson 2007-05-17 10:42:35 UTC
If you are on AMD64 and install mplayerplug-in, it will build a 64 bit plugin that doesn't work with firefox-bin. I guess many people are running AMD64 with firefox-bin so this should help. I run both 32-bit and 64-bit firefox and it works good for me.

This isn't hard to do since mplayerplug-in has a configure option to build 32-bit instead of 64-bit.

I create the ebuild for #107922 but that bug is now closed, good thing by the way. So I open a new bug with just this problem.

Reproducible: Always

Steps to Reproduce:
Comment 1 Jonas Jonsson 2007-05-17 11:13:18 UTC
Created attachment 119513 [details]
mplayerplug-in-3.40-r1.ebuild

Updated ebuild to build both 32bit and 64bit.

There is however one problem, if you only have 64-bit firefox then this ebuild will require emul-x86 libs wich isn't what one wants. So if you are runing a 64-bit multilib installation but you don't use 32-bit firefox then this will pull in the emul-x86 libs for you. Hope you see the problem.

I don't know if you should opt for another use-flag or if one build the 32-bit only if you have firefox-bin installed.
Comment 2 Joe Jezak (RETIRED) gentoo-dev 2007-05-17 11:39:18 UTC
This won't quite work as is because if you only have firefox-bin installed, it doesn't come with all the dev libraries needed to build mplayerplug-in (or so I've been told, I don't have an x86/amd64 system).  I could probably include the binary gecko-sdk to fix this, I'll look into it I guess.  Steve, any comments?
Comment 3 Jonas Jonsson 2007-05-17 11:46:34 UTC
(In reply to comment #2)
> This won't quite work as is because if you only have firefox-bin installed, it
> doesn't come with all the dev libraries needed to build mplayerplug-in (or so
> I've been told, I don't have an x86/amd64 system).  I could probably include
> the binary gecko-sdk to fix this, I'll look into it I guess.  Steve, any
> comments?
> 

I could just unmerge mozilla-firefox and see if it builds with just firefox-bin.
Comment 4 Jonas Jonsson 2007-05-17 13:16:40 UTC
I unmerged mozilla-firefox and it doesn't build, but if I install xulrunner it will build a 32bit plugin that works in firefox-bin.
Comment 5 Oliver Jeeves 2007-08-09 18:53:12 UTC
Isn't there also a problem at the other end of the plugin?

Currently, it depends on mplayer, whereas I use mplayer-bin on my 64bit system to maintain compatability with the win32 codecs.

This means that there are 4 combinations of mplayer and firefox you're trying to satisfy. Would it make sense to instead have an mplayerplug-in-bin ebuild?
Comment 6 Jonas Jonsson 2007-08-12 13:57:57 UTC
(In reply to comment #5)
> Isn't there also a problem at the other end of the plugin?
> 
> Currently, it depends on mplayer, whereas I use mplayer-bin on my 64bit system
> to maintain compatability with the win32 codecs.
>

Well this is solved in bug #107922 , the mplayer-bin use-flag gives you the choice of either mplayer or mplayer-bin.

One must decide if both plugins should be built even thought only one will be used. I think we shall build both if the system is multilib. This is probably best for the users since he/she doesn't need reemerge if he/she installs both later on.

The problem is if the user only has firefox-bin, but couldn't the ebuild just depend on either xulrunner or firefox if the system is 64-bit.

 
Comment 7 Joe Jezak (RETIRED) gentoo-dev 2007-09-02 18:03:39 UTC
I added a dep for xulrunner.  This should work with firefox-bin now (but I won't dep on that explicitly.)  Is this enough for everyone here to get things working?  I admit still, that I'm still not familiar with AMD64/multilib issues since I only work with PPC machines. :)
Comment 8 Oliver Jeeves 2007-10-04 21:52:08 UTC
I can now emerge mplayerplug-in (3.45), but it won't work with firefox-bin, since it builds 64bit libraries and firefox-bin is a 32bit application.

xulrunner is built 64bit as well, as you'd expect, so you can't build 32bit binaries linked against it.

I think the solution to this is likely to involve having a separate mplayerplug-in-bin package.
Comment 9 Jonas Jonsson 2007-10-05 12:35:53 UTC
Created attachment 132651 [details]
mplayerplug-in-3.45.ebuild

You could try this updated ebuild, this will build for both firefox and firefox-bin if you use amd64 and has multilibprofile.
Comment 10 Oliver Jeeves 2007-10-06 11:16:27 UTC
I've just tested the new ebuild, and it works for me perfectly. Excellent stuff.
Comment 11 Aline de Freitas 2007-12-06 23:45:21 UTC
Created attachment 137919 [details]
mplayerplug-in-3.45.ebuild

It makes possible to choose between firefox, seamonkey or xulrunner by USE flags.
Comment 12 Aline de Freitas 2007-12-06 23:50:48 UTC
Created attachment 137920 [details]
mplayerplug-in-3.45.ebuild

Sorry, little mistake. Here's the right one.
Comment 13 Jonas Jonsson 2007-12-07 14:00:39 UTC
(In reply to comment #12)
> Created an attachment (id=137920) [edit]
> mplayerplug-in-3.45.ebuild
> 
> Sorry, little mistake. Here's the right one.
> 

Shouldn't there be a default fallback if none of the use flags are selected?
Comment 14 Aline de Freitas 2007-12-15 00:44:49 UTC
Created attachment 138528 [details]
mplayerplug-in-3.45.ebuild

Sure, I think now I've covered all the possibilities.

So, we have 3 new use flags: firefox, seamonkey and xulrunner.
If USE="firefox", then defaults to mozilla-firefox, and doesn't matter any of the others USE flags.
If USE="-firefox seamonkey", defaults to seamonkey, and doesn't matter if USE="xulrunner" ou "-xulrunner"
If USE="-firefox -seamonkey xulrunner", defaults to xulrunner.
And if USE="-firefox -seamonkey -xulrunner", defaults to mozilla-firefox.

Thanks,
Aline
Comment 15 Joe Jezak (RETIRED) gentoo-dev 2008-01-06 22:36:34 UTC
I added this to CVS, although I changed the dependencies a bit to simplify them:

firefox - This flag always enables firefox
seamonkey - This flag enables seamonkey, unless firefox is set
-firefox -seamonkey - Enables xulrunner

Feel free to reopen the bug if you still have problems.