Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 178781 - sys-apps/lm_sensors init.d bashisms
Summary: sys-apps/lm_sensors init.d bashisms
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Christian Heim (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-16 15:18 UTC by Mike McQuaid
Modified: 2007-05-18 07:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike McQuaid 2007-05-16 15:18:52 UTC
Bashisms in /etc/init.d/lm_sensors cause 

Line 26 of /etc/init.d/lm_sensors
if [ ${?} == 0 ]; then
should be
if [ ${?} = 0 ]; then

Line 59 of /etc/init.d/lm_sensors
i=$((i+1))
should be
i=$((${i}+1))
Comment 1 Christian Heim (RETIRED) gentoo-dev 2007-05-17 07:30:07 UTC
Thanks Mike, I've fixed them locally and I'm going to commit them in a minute.
Comment 2 Mike McQuaid 2007-05-17 22:54:40 UTC
Woops, noticed another.

Line 92 of /etc/init.d/lm_sensors
i=$((i-1))
should be
i=$(($i-1))
Comment 3 Christian Heim (RETIRED) gentoo-dev 2007-05-18 07:51:34 UTC
(In reply to comment #2)
> Woops, noticed another.
> 
> Line 92 of /etc/init.d/lm_sensors
> i=$((i-1))
> should be
> i=$(($i-1))

'k, fixed the remaining ones too.