Bugzilla Bug 178501

Current ebuilds for packages:

mail-filter/libmilter
mail-filter/dk-milter
mail-filter/sid-milter

are a bit old. I cleaned these ebuilds, enabled IPv6 functionality with ipv6
USE flag, tried it on x86/amd64 and also bumped versions.

Also, this sid-milter can be safely package.unmasked.


Reproducible: Always

Created an attachment (id=119209) [details]
New ebuild for libmilter

Created an attachment (id=119210) [details]
libmilter/files/site.config.m4

Created an attachment (id=119211) [details]
New ebuild for dk-milter

Created an attachment (id=119215) [details]
dk-milter/files/site.config.m4

Created an attachment (id=119219) [details]
dk-milter/files/postfix-queueID.patch

Created an attachment (id=119220) [details]
New ebuild for sid-milter

Created an attachment (id=119221) [details]
sid-milter/files/site.config.m4

Created an attachment (id=119222) [details]
sid-milter/files/postfix-queueID.patch

(In reply to comment #1)
> Created an attachment (id=119209) [edit] [details]
> New ebuild for libmilter

Consider adding poll USE flag building libmilter with poll() instead of
select() if poll() is available on your system.  During high loads, this can
become important.  Perhaps something like:

--- libmilter-8.14.1.ebuild.orig        2007-06-10 15:52:26.000000000 +0000
+++ libmilter-8.14.1.ebuild     2007-06-10 15:53:00.000000000 +0000
@@ -13,7 +13,7 @@
 LICENSE="Sendmail"
 SLOT="0"
 KEYWORDS="~x86 ~amd64"
-IUSE="ipv6"
+IUSE="ipv6 poll"

 DEPEND=""
 RDEPEND="${DEPEND}"
@@ -28,6 +28,7 @@
        confCCOPTS="${CFLAGS}"
        confENVDEF=""
        use ipv6 && confENVDEF="${confENVDEF} -DNETINET6"
+       use poll && confENVDEF="${confENVDEF} -DSM_CONF_POLL=1"
        sed -e "s:@@confCCOPTS@@:${confCCOPTS}:" \
                -e "s/@@confENVDEF@@/${confENVDEF}/" \
                "${FILESDIR}"/site.config.m4 >
${S}/devtools/Site/site.config.m4

I've already fixed the libmilter (needed for dkim-milter).

Could you please bump attach bumped dk-milter and sid-milter ebuilds?
Please make the new ebuilds look like the current dkim-milter version.

I am going to look at it now. Could you please add ipv6 and poll USE flags to
libmilter? It should be trivial (see my ebuild).

Already done it in version 8.14.1-r1.

Thanks for ipv6 and poll IUSE!

Going to attach dk-milter. I have used same approach with site config as with
libmilter as it is more elegant when adding IPv6 support. sid-milter will
follow soon.

Created an attachment (id=133164) [details]
Updated ebuild for dk-milter

Created an attachment (id=133166) [details]
dk-milter/files/gentoo.config.m4

Created an attachment (id=133167) [details]
dk-milter/files/dk-milter-0.6.0-postfix-queueID.patch

Created an attachment (id=133192) [details]
Updated ebuild for dk-milter

I have removed test phase as "make OPTIONS=check" does nothing, just bubble
through SUBDIRs. Also, I have fixed "make install" to install only dk-milter
stuff. This makes no difference for dk-milter, but sid-milter installs some
static library into /usr/lib, replacing symlink on 64-bit and breaking system.

Created an attachment (id=133194) [details]
Updated ebuild for sid-milter

Created an attachment (id=133195) [details]
sid-milter/files/gentoo.config.m4

Created an attachment (id=133197) [details]
sid-milter/files/sid-milter-0.2.14-postfix-queueID.patch

Ebuilds should be complete now. Please review and commit if everything is OK
:).

I've looked over your dk-milter and it isn't good enough. The patch is not
needed anymore and -DNETUNIX -DNETINET -DNETINET6 are useless for this package
(see the source).

Except src_test (which is pointless for this package) and configuration file
(not supported), please do exactly what dkim-milter does (e.g. generate
site.config.m4 based on .dist file, implement pkg_config, have similar
pkg_postinst, ...). We've worked hard to come up with this kind of ebuild, so
please reuse it.

The correct lib dir can be forced. See current libmilter ebuild.

-DNETINET6 is important. dk-milter/sid-milter will otherwise fail when
processing mail from postfix which was received by postfix over IPv6. I agree
about not using -DNETUNIX and -DNETINET.

pkg_postinst is similar (except 'elog' lines). I am not sure how exactly
dk-milter works when signing mails - I am using it currently only to check
signatures. I guess copying pkg_config and fixing key paths will work.

(In reply to comment #23)
> -DNETINET6 is important. dk-milter/sid-milter will otherwise fail when
> processing mail from postfix which was received by postfix over IPv6.

Yeah, I found where it's used. ipv6 useflag will make it through IUSE.

> pkg_postinst is similar (except 'elog' lines). I am not sure how exactly
> dk-milter works when signing mails - I am using it currently only to check
> signatures. I guess copying pkg_config and fixing key paths will work.

You have a point here. DomainKeys is obsolete so I don't know if there is
anyone (besides yahoo obviously) still interested in signing his/her mail with
it. I'll assume no one wants that and go your way.

I've commited dk-milter-0.6.0. I've added all the bells and whistles from
dkim-milter because it was easier for me to do this than correcting that crappy
key generator script.

I've changed the conf.d file and init.d file quite a bit. 
Since DK RFC is obsoleted by DKIM, the new default configuration is set on
verify-only.

sid-milter-0.2.14 is now in the tree, mostly as you posted here. You were right
about libar, it is useless (no header file is installed and all milters I've
committed so far had that library in their source tree).
Changes from your version:
 - install man page by hand (the build process breaks its format)
 - removed ipv6 flag (doesn't use -DNETINET6 at all)

I didn't added myself as maintainer because I don't intend to spend my time on
packages that are perfect candidates for removal. IMO Sender ID died the moment
MARID ceased to exist.