Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 178224
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Mozilla Gentoo Team <mozilla@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Togge <togge.gentoo@gmail.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
mozilla-launcher-1.56-comma.patch Patch that removes "," from the chars to escape patch Togge 2007-05-12 16:10 0000 489 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 178224 depends on: Show dependency tree
Bug 178224 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2007-05-12 16:07 0000 
www-client/mozilla-launcher-1.56 escapes "," breaking certain websites.
According to RFC2616: 3.2.3 URI Comparison and RFC2396: 3.4. Query Component,
commas are a valid delimiter for script params and must not be escaped. Since
mozilla-launcher escapes commas regardless of position within the URL it breaks
those sites that uses "," as a delimiter. And as the use of openURL() needs the
"-remote" option and if this is found mozilla-launcher passes the unmodified
command to the browser I fail to see why commas need to be escaped.

------- Comment #1 From Togge 2007-05-12 16:10:04 0000 ------- 
Created an attachment (id=119022) [details]
Patch that removes "," from the chars to escape

This patch works with the test cases described in bug #150404 as well as with
URL that use "," as a delimiter.

------- Comment #2 From Jakub Moc (RETIRED) 2007-05-12 16:29:42 0000 ------- 

*** This bug has been marked as a duplicate of bug 150404 ***

------- Comment #3 From Jakub Moc (RETIRED) 2007-05-12 16:44:37 0000 ------- 
Noone complained about a single broken website since the patch has been
commited. Unless you are able to provide a testcase for the alleged borkage, no
point in beating a dead horse and fixing what's not broken.

------- Comment #4 From Togge 2007-05-12 17:33:50 0000 ------- 
Here's a "broken" URL:
http://www.bovision.se/scripts/bovision/prenbesk.phtml?76118842,20097&confirmed=1&OBJGUID=76118842&OBJTYPE=CMBoLgh&nyabesk=1
as seen it uses both "," and "&" as delimiters. Also since the patch does *not*
break the test cases in bug #150404 I can't see why it should not be considered
especially since the current behavior is against the RFC's.

------- Comment #5 From Raúl Porcel 2008-01-01 14:09:49 0000 ------- 
Fixed in 1.57, thanks for the fix
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug